Skip to content

Add camera mismatch banner to dashboard #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add camera mismatch banner to dashboard #1921

wants to merge 16 commits into from

Conversation

alaninnovates
Copy link
Contributor

Description

Detects if a camera mismatch is present in any camera and displays a banner in the dashboard for better visibility to the user.

image

Closes #1920

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@alaninnovates alaninnovates requested a review from a team as a code owner April 19, 2025 05:53
@samfreund
Copy link
Member

Looks good, I'll test when I have a chance.

@crschardt
Copy link
Contributor

This is all front-end code. Shouldn't we also involve the back-end, at least to log that there is a conflict?

@samfreund
Copy link
Member

Yea I agree with Craig. If we could just get a log message, ideally with the camera that should be there, and the camera that is there. This should only happen once, when the camera is initially connected and mismatched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 left review comments

@samfreund samfreund samfreund left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make camera mismatch message more prominent
4 participants
@alaninnovates @samfreund @crschardt @mcm001