refactor: Update auth controller and tests to use and explicit types.

Author: PhuocHoan

apps/api/src/auth/auth.controller.spec.ts

@@ -7,6 +7,7 @@ import { UserRole } from '../users/enums/user-role.enum';
 import { AuthController } from './auth.controller';
 import { AuthService, type OAuthProfile } from './auth.service';
 
+import type { RequestWithUser } from '../types/request.interface';
 import type { Response, Request } from 'express';
 
 describe('AuthController', () => {
@@ -185,7 +186,7 @@ describe('AuthController', () => {
           avatarUrl: 'https://avatar.url',
           providerId: 'google-123',
         } as OAuthProfile,
-      } as unknown as Request;
+      } as unknown as RequestWithUser;
       const res = mockResponse();
 
       authService.validateOAuthLogin.mockResolvedValue({
@@ -212,7 +213,7 @@ describe('AuthController', () => {
           avatarUrl: 'https://avatar.url',
           providerId: 'github-123',
         } as OAuthProfile,
-      } as unknown as Request;
+      } as unknown as RequestWithUser;
       const res = mockResponse();
 
       authService.validateOAuthLogin.mockResolvedValue({

apps/api/src/auth/auth.controller.ts

@@ -40,16 +40,13 @@ import type {
   MessageResult,
   SafeUser,
 } from './auth.service';
+import type { RequestWithUser } from '../types/request.interface';
 import type {
   CookieOptions,
   Request as ExpressRequest,
   Response as ExpressResponse,
 } from 'express';
 
-// Express 5 compatible types - using full Express types instead of core types
-type Request = ExpressRequest;
-type Response = ExpressResponse;
-
 // so we can use 'lax' for better security
 const getCookieOptions = (): CookieOptions => {
   const isProduction = process.env.NODE_ENV === 'production';
@@ -78,7 +75,7 @@ export class AuthController {
   @Post('login')
   async signIn(
     @Body() loginDto: LoginDto,
-    @Res({ passthrough: true }) res: Response,
+    @Res({ passthrough: true }) res: ExpressResponse,
   ): Promise<{ user: SafeUser; message: string }> {
     const result = await this.authService.login(loginDto);
 
@@ -123,7 +120,7 @@ export class AuthController {
 
   @Post('logout')
   @HttpCode(HttpStatus.OK)
-  logout(@Res({ passthrough: true }) res: Response): MessageResult {
+  logout(@Res({ passthrough: true }) res: ExpressResponse): MessageResult {
     // Clear the cookie
     res.clearCookie('access_token', { path: '/' });
     return { message: 'Logout successful' };
@@ -139,8 +136,8 @@ export class AuthController {
   @Get('google/callback')
   @UseGuards(GoogleAuthGuard)
   async googleAuthRedirect(
-    @Req() req: Request,
-    @Res() res: Response,
+    @Req() req: RequestWithUser,
+    @Res() res: ExpressResponse,
   ): Promise<void> {
     const frontendUrl = this.configService.get<string>('FRONTEND_URL');
 
@@ -187,8 +184,8 @@ export class AuthController {
   @Get('github/callback')
   @UseGuards(GithubAuthGuard)
   async githubAuthRedirect(
-    @Req() req: Request,
-    @Res() res: Response,
+    @Req() req: RequestWithUser,
+    @Res() res: ExpressResponse,
   ): Promise<void> {
     const frontendUrl = this.configService.get<string>('FRONTEND_URL');
 
@@ -242,7 +239,7 @@ export class AuthController {
   @UseGuards(JwtAuthGuard)
   @HttpCode(HttpStatus.OK)
   async selectRole(
-    @Res({ passthrough: true }) res: Response,
+    @Res({ passthrough: true }) res: ExpressResponse,
     @CurrentUser() user: User,
     @Body() selectRoleDto: SelectRoleDto,
   ): Promise<{ user: SafeUser; accessToken: string; message: string }> {
@@ -353,7 +350,7 @@ export class AuthController {
   async deleteAccount(
     @CurrentUser() user: User,
     @Body() deleteAccountDto: DeleteAccountDto,
-    @Res({ passthrough: true }) res: Response,
+    @Res({ passthrough: true }) res: ExpressResponse,
   ): Promise<MessageResult> {
     const result = await this.authService.deleteAccount(
       user.id,