Skip to content

W2-B-029 - currencyConverter calls .toNumber() on string | Date | Decimal #739

Description

@likableai

Severity: High | Area: backend/rates | Evidence: src/services/rates/currencyConverter.ts:96,167 — TS2339
Impact: Rate fields from Prisma Decimal columns are union-typed; calling .toNumber() fails to compile and may throw at runtime. Fix: Normalize the rate to Decimal before arithmetic; use Number() only for comparisons. Acceptance: Conversions work with string, Decimal, and Date rate rows.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programseverity: highWave-2 issue severitywave-8Wave-8 backlog

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions