Add option to control configuration change watching in Engine

Author: U039b

mongoose/core/engine.py

@@ -51,7 +51,7 @@ class Engine(metaclass=Singleton):
     and managing their lifecycle (start, stop, reload).
     """
 
-    def __init__(self, config_path: str, interface: str = None):
+    def __init__(self, config_path: str, interface: str = None, watch_configuration_changes: bool = True):
         self.config_path = config_path
         self.config: Optional[Configuration] = None
         self.processing_queue = ProcessingQueue()
@@ -65,6 +65,7 @@ def __init__(self, config_path: str, interface: str = None):
         self._setup_components()
         self.started = False
         self.thread_id = threading.get_ident()
+        self.watch_configuration_changes = watch_configuration_changes
         self.webhook_configuration_watcher = DropInConfigurationWatcher(
             self.config.extra_configuration_dir / "webhook.d",
             DropInConfigurationHandler(WebhookForwarderConfiguration, self._handle_webhook_configuration_changes),
@@ -189,7 +190,8 @@ def start(self):
         # Reset the stop event in case it was set during a previous run
         self.processing_queue.stop_processing_event.clear()
 
-        self.webhook_configuration_watcher.run()
+        if self.watch_configuration_changes:
+            self.webhook_configuration_watcher.run()
 
         self.sink.start()
         self.database_storage.start()
@@ -215,7 +217,9 @@ def stop(self):
         self.started = False
 
         self.processing_queue.stop_processing()
-        self.webhook_configuration_watcher.stop()
+
+        if self.watch_configuration_changes:
+            self.webhook_configuration_watcher.stop()
 
         self.sink.stop()
         self.processing_queue.queues.clear()

tests/test_engine.py

@@ -24,7 +24,7 @@ def test_engine_initialization(tmp_path):
     with open(config_file, "w") as f:
         yaml.dump(config_content, f)
 
-    engine = Engine(str(config_file))
+    engine = Engine(str(config_file), watch_configuration_changes=False)
     assert isinstance(engine.config, Configuration)
     assert engine.config.collector.suricata.enable is True
     assert engine.config.collector.nf_stream.enable is False
@@ -52,7 +52,7 @@ def test_engine_start(mock_enrich_init, mock_file_start, mock_enrich_start, mock
     with open(config_file, "w") as f:
         yaml.dump(config_content, f)
 
-    engine = Engine(str(config_file))
+    engine = Engine(str(config_file), watch_configuration_changes=False)
     engine.start()
 
     assert mock_suricata_start.called
@@ -79,7 +79,7 @@ def test_engine_stop(mock_stop_processing, tmp_path):
     with open(config_file, "w") as f:
         yaml.dump(config_content, f)
 
-    engine = Engine(str(config_file))
+    engine = Engine(str(config_file), watch_configuration_changes=False)
     engine.stop()
     assert mock_stop_processing.called
 
@@ -94,7 +94,7 @@ def test_engine_reload(mock_setup, mock_load, mock_start, mock_stop, tmp_path):
     with open(config_file, "w") as f:
         yaml.dump(config_content, f)
 
-    engine = Engine(str(config_file))
+    engine = Engine(str(config_file), watch_configuration_changes=False)
     engine.reload()
 
     assert mock_stop.called