test: harden flaky conduit E2E assertions

Author: MCGPPeters

Picea.Abies.Conduit.Testing.E2E/AppHost/AppHostServerRegressionTests.cs

@@ -72,7 +72,13 @@ public async Task DeleteArticle_AsAuthor_ShouldRemoveItFromGlobalFeed()
         await _page.WaitForSelectorAsync("text='Delete Article'", new() { Timeout = 15000 });
         await _page.GetByText("Delete Article").First.ClickAsync();
 
-        await _page.WaitForURLAsync("**/");
+        await _page.WaitForFunctionAsync(
+            "() => window.location.pathname === '/'",
+            null,
+            new() { Timeout = 30000 });
+        await _page.WaitForSelectorAsync(
+            ".home-page, .feed-toggle, .article-preview",
+            new() { Timeout = 30000 });
         await _seeder.WaitForArticleDeletedAsync(article.Slug);
         await Expect(_page.Locator(".article-preview").Filter(new() { HasText = article.Title }))
             .ToHaveCountAsync(0, new() { Timeout = 10000 });

Picea.Abies.Conduit.Testing.E2E/CommentTests.cs

@@ -109,7 +109,7 @@ await Expect(_page.Locator($".card .card-block p:text-is('{comment.Body}')"))
         await _page.Locator(".card .card-footer .mod-options i.ion-trash-a").First
             .DispatchEventAsync("click");
 
-        await Expect(_page.Locator($"text={comment.Body}")).ToHaveCountAsync(0,
+        await Expect(_page.Locator($".card .card-block p:text-is('{comment.Body}')")).ToHaveCountAsync(0,
             new() { Timeout = 10000 });
     }
 
@@ -151,7 +151,7 @@ await route.FulfillAsync(new RouteFulfillOptions
 
         await _page.Locator(".card .card-footer .mod-options i.ion-trash-a").First.DispatchEventAsync("click");
 
-        await Expect(_page.Locator($"text={comment.Body}")).ToHaveCountAsync(0,
+        await Expect(_page.Locator($".card .card-block p:text-is('{comment.Body}')")).ToHaveCountAsync(0,
             new() { Timeout = 10000 });
     }
 

Picea.Abies.Conduit.Testing.E2E/Server/AuthenticationServerTests.cs

@@ -78,7 +78,7 @@ public async Task Login_WithInvalidCredentials_ShouldShowErrors()
         await _page.GetByPlaceholder("Password").FillAndWaitForPatch("wrongpassword");
         await _page.GetByRole(AriaRole.Button, new() { Name = "Sign in" }).ClickAsync();
 
-        await Expect(_page.Locator("h1")).ToContainTextAsync("Sign in", new() { Timeout = 10000 });
+        await Expect(_page.Locator(".auth-page h1")).ToContainTextAsync("Sign in", new() { Timeout = 10000 });
         await Expect(_page.Locator(".navbar a[href='/settings']")).ToHaveCountAsync(0, new() { Timeout = 10000 });
     }
 
@@ -98,7 +98,7 @@ public async Task Logout_FromSettings_ShouldClearSessionAndNavigateToHome()
             .ClickAsync();
 
         await _page.NavigateInApp("/settings");
-        await Expect(_page.Locator("h1")).ToContainTextAsync("Sign in", new() { Timeout = 10000 });
+        await Expect(_page.Locator(".auth-page h1")).ToContainTextAsync("Sign in", new() { Timeout = 10000 });
         await Expect(_page.Locator(".navbar a[href='/settings']")).ToHaveCountAsync(0, new() { Timeout = 10000 });
     }
 
@@ -119,7 +119,7 @@ public async Task Login_WithWrongPasswordAfterRegister_ShouldShowError()
         await _page.GetByPlaceholder("Password").FillAndWaitForPatch("wrongpassword");
         await _page.GetByRole(AriaRole.Button, new() { Name = "Sign in" }).ClickAsync();
 
-        await Expect(_page.Locator("h1")).ToContainTextAsync("Sign in", new() { Timeout = 10000 });
+        await Expect(_page.Locator(".auth-page h1")).ToContainTextAsync("Sign in", new() { Timeout = 10000 });
         await Expect(_page.Locator(".navbar a[href='/settings']")).ToHaveCountAsync(0, new() { Timeout = 10000 });
     }