Skip to content

Commit 6ee5889

Browse files
committed
fix: Address review feedback - remove fixed waits and ExcludeAssets
- Remove redundant WaitForTimeoutAsync(100) between fills - Remove redundant WaitForTimeoutAsync(500) before enabled check - Remove ExcludeAssets from ProjectReference (RemoveDuplicateAbiesJs target handles it) - Keep DispatchEventAsync('input') to ensure events fire in headless mode
1 parent 399230e commit 6ee5889

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

Abies.Conduit.E2E/PlaywrightFixture.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -277,26 +277,20 @@ protected async Task<string> CreateTestArticleAsync(string title, string descrip
277277

278278
await titleInput.FillAsync(title);
279279
await titleInput.DispatchEventAsync("input");
280-
await Page.WaitForTimeoutAsync(100);
281280

282281
await descInput.FillAsync(description);
283282
await descInput.DispatchEventAsync("input");
284-
await Page.WaitForTimeoutAsync(100);
285283

286284
await bodyInput.FillAsync(body);
287285
await bodyInput.DispatchEventAsync("input");
288-
await Page.WaitForTimeoutAsync(100);
289286

290287
foreach (var tag in tags)
291288
{
292289
await Page.GetByPlaceholder("Enter tags").FillAsync(tag);
293290
await Page.GetByPlaceholder("Enter tags").PressAsync("Enter");
294291
}
295292

296-
// Wait for form validation to update after input events
297-
await Page.WaitForTimeoutAsync(500);
298-
299-
// Wait for button to be enabled (form validation complete)
293+
// Wait for button to be enabled (form validation complete) - Playwright auto-retries
300294
var publishButton = Page.GetByRole(AriaRole.Button, new() { Name = "Publish Article" });
301295
await Expect(publishButton).ToBeEnabledAsync(new() { Timeout = 5000 });
302296

Abies.Conduit/Abies.Conduit.csproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,7 @@
2020
<InvariantGlobalization>true</InvariantGlobalization>
2121
</PropertyGroup>
2222
<ItemGroup>
23-
<ProjectReference Include="..\Abies\Abies.csproj">
24-
<!-- Exclude Content files from Abies project during publish to avoid NETSDK1152 conflict with local copy -->
25-
<ExcludeAssets>ContentFiles</ExcludeAssets>
26-
<PrivateAssets>ContentFiles</PrivateAssets>
27-
</ProjectReference>
23+
<ProjectReference Include="..\Abies\Abies.csproj" />
2824
</ItemGroup>
2925
<ItemGroup>
3026
<PackageReference Include="Markdig" Version="0.44.0" />

0 commit comments

Comments
 (0)