Skip to content

Conversation

@Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 5, 2026

Addresses this comment and a few other things.

Suggested commit message:

Apply assorted non-functional improvements (#2054)

Summary of changes:
- Improve the intentionality of some code in `AssertJNullnessAssertion`.
- Document a possible improvement of `ExplicitArgumentEnumeration`.
- Add class documentation to several `AssertJ*Rules` classes.
- Update the Checkstyle configuration to better match the 
  Picnic-internal codebase.
- Simplify the Surefire system properties configuration.

@Stephan202 Stephan202 added this to the 0.28.0 milestone Jan 5, 2026
@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Suggested commit message:

Apply assorted non-functional improvements (#2054)

Clarify `AssertJNullnessAssertion` fix construction and note a possible
follow-up for `ExplicitArgumentEnumeration`.

Add brief class docs to the assorted `AssertJ*Rules` collections.

Align Checkstyle and Surefire settings with internal defaults by
moving system properties and enabling additional checks.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.AssertJNullnessAssertion 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.AssertJNullnessAssertion 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice 🚀

Error Prone or automatically corrected through
application of google-java-format (GJF). -->
<module name="Checker">
<module name="NewlineAtEndOfFile" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't our formatter already do this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Java files: yes. But in the past we e.g. didn't have this for .eps files; I hope this one covers that. (But didn't check.)

@rickie rickie force-pushed the sschroevers/nonfunctional-improvements branch from 15ae871 to a981ad1 Compare January 6, 2026 09:39
Summary of changes:
- Improve the intentionality of some code in `AssertJNullnessAssertion`.
- Document a possible improvement of `ExplicitArgumentEnumeration`.
- Add class documentation to several `AssertJ*Rules` classes.
- Update the Checkstyle configuration to better match the
  Picnic-internal codebase.
@Stephan202 Stephan202 force-pushed the sschroevers/nonfunctional-improvements branch from a981ad1 to f1c3d88 Compare January 8, 2026 21:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Looks good. All 2 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.AssertJNullnessAssertion 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A task not related to code (build, formatting, process, ...)

Development

Successfully merging this pull request may close these issues.

3 participants