-
Notifications
You must be signed in to change notification settings - Fork 49
Apply assorted non-functional improvements #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Suggested commit message: |
|
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
|
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice 🚀
| Error Prone or automatically corrected through | ||
| application of google-java-format (GJF). --> | ||
| <module name="Checker"> | ||
| <module name="NewlineAtEndOfFile" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't our formatter already do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Java files: yes. But in the past we e.g. didn't have this for .eps files; I hope this one covers that. (But didn't check.)
15ae871 to
a981ad1
Compare
Summary of changes: - Improve the intentionality of some code in `AssertJNullnessAssertion`. - Document a possible improvement of `ExplicitArgumentEnumeration`. - Add class documentation to several `AssertJ*Rules` classes. - Update the Checkstyle configuration to better match the Picnic-internal codebase.
a981ad1 to
f1c3d88
Compare
|
|
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |



Addresses this comment and a few other things.
Suggested commit message: