Skip to content

Commit 400b4b2

Browse files
committed
Fix custom rewards not given if override set
1 parent 98441a6 commit 400b4b2

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

core/src/main/java/me/pikamug/quests/quests/BukkitQuest.java

+16-9
Original file line numberDiff line numberDiff line change
@@ -890,12 +890,24 @@ public void completeQuest(final Quester quester, final boolean allowMultiplayer)
890890
}
891891
issuedReward = true;
892892
}
893-
if (!rewards.getCustomRewards().isEmpty()) {
894-
issuedReward = true;
895-
if (plugin.getConfigSettings().getConsoleLogging() > 2) {
896-
for (final String s : rewards.getCustomRewards().keySet()) {
893+
for (final String s : rewards.getCustomRewards().keySet()) {
894+
CustomReward found = null;
895+
for (final CustomReward cr : plugin.getCustomRewards()) {
896+
if (cr.getName().equalsIgnoreCase(s)) {
897+
found = cr;
898+
break;
899+
}
900+
}
901+
if (found != null) {
902+
found.giveReward(player.getUniqueId(), rewards.getCustomRewards().get(s));
903+
issuedReward = true;
904+
if (plugin.getConfigSettings().getConsoleLogging() > 2) {
897905
plugin.getLogger().info(player.getUniqueId() + " was custom rewarded " + s);
898906
}
907+
} else {
908+
plugin.getLogger().warning("Quester \"" + player.getName() + "\" completed the Quest \""
909+
+ name + "\", but the Custom Reward \"" + s
910+
+ "\" could not be found. Does it still exist?");
899911
}
900912
}
901913

@@ -1064,11 +1076,6 @@ public void completeQuest(final Quester quester, final boolean allowMultiplayer)
10641076
plugin.getLogger().warning("Failed to notify player: "
10651077
+ "Custom Reward does not have an assigned name");
10661078
}
1067-
found.giveReward(p.getUniqueId(), rewards.getCustomRewards().get(s));
1068-
} else {
1069-
plugin.getLogger().warning("Quester \"" + player.getName() + "\" completed the Quest \""
1070-
+ name + "\", but the Custom Reward \"" + s
1071-
+ "\" could not be found. Does it still exist?");
10721079
}
10731080
}
10741081
}

0 commit comments

Comments
 (0)