Gstreamer: Doc update and Code Rabbit Fixes

Author: PinJinx

README.md

@@ -31,14 +31,16 @@ Quality couch keyboards are not so accessible, STT on Linux isn’t in a good st
 >
 > On Wayland, screen capture requires a working PipeWire + XDG Desktop Portal setup (typically provided by your desktop environment).
 >
-> Your user must also have permission to access `/dev/uinput`. A common setup is:
+> Your user must also have permission to access `/dev/uinput`. A recommended setup is:
 >
 > ```bash
+> sudo groupadd -f uinput
+>
 > sudo tee /etc/udev/rules.d/99-rein.rules <<EOF
-> KERNEL=="uinput", MODE="0660", GROUP="input"
+> KERNEL=="uinput", MODE="0660", GROUP="uinput"
 > EOF
 >
-> sudo usermod -aG input $USER
+> sudo usermod -aG uinput $USER
 >
 > sudo udevadm control --reload-rules
 > sudo udevadm trigger
@@ -55,7 +57,7 @@ Quality couch keyboards are not so accessible, STT on Linux isn’t in a good st
 > which should show:
 >
 > ```text
-> crw-rw---- 1 root input ... /dev/uinput
+> crw-rw---- 1 root uinput ... /dev/uinput
 > ```
 >
 > Additionally, some native dependencies are required. Install them via your package manager (see [`shell.nix`](shell.nix) for the list), or use `nix-shell` directly.

src/hooks/useWebRtcStream.ts

@@ -215,14 +215,17 @@ export function useWebRtcStream({ token }: UseWebRtcStreamOptions) {
 		const sendInputOffer = async () => {
 			const offer = await inputPc.createOffer()
 			await inputPc.setLocalDescription(offer)
-			await fetch("/api/webrtc/input-offer", {
+			const response = await fetch("/api/webrtc/input-offer", {
 				method: "POST",
 				headers: {
 					"Content-Type": "application/json",
 					...(token ? { Authorization: `Bearer ${token}` } : {}),
 				},
 				body: JSON.stringify({ sessionId: activeSessionId, sdp: offer.sdp }),
 			})
+			if (!response.ok) {
+				throw new Error(`[WebRTC] Input offer failed: ${response.status}`)
+			}
 		}
 
 		sendInputOffer().catch(console.error)

src/server/drivers/linux/index.ts

@@ -81,12 +81,7 @@ class UinputDevice {
 			console.error(
 				`[${this.name}] Ensure /dev/uinput exists and the process has write permission.`,
 			)
-			console.error(
-				`[${this.name}] Run: sudo chown root:input /dev/uinput && sudo chmod 0660 /dev/uinput  or add udev rule.`,
-			)
-			throw new Error(
-				`Failed to open /dev/uinput. Ensure your user has write permissions (run: sudo chown root:input /dev/uinput && sudo chmod 0660 /dev/uinput)`,
-			)
+			return false
 		}
 	}
 

src/server/server.ts

@@ -103,14 +103,19 @@ export function attachSignalingRoutes(
 				const match = pathname.match(route.pattern)
 				if (!match) continue
 
-				const anyRes = res as ServerResponse & { __handledByRein?: boolean }
+				const anyRes = res as ServerResponse & {
+					__handledByRein?: boolean
+					__reinOriginalWrite?: typeof originalWrite
+				}
 				anyRes.__handledByRein = true
 
 				const originalSetHeader = res.setHeader.bind(res)
 				const originalWriteHead = res.writeHead.bind(res)
 				const originalWrite = res.write.bind(res)
 				const originalEnd = res.end.bind(res)
 
+				anyRes.__reinOriginalWrite = originalWrite
+
 				res.setHeader = ((...args: Parameters<typeof res.setHeader>) => {
 					if (anyRes.__handledByRein && !reinStorage.getStore()) {
 						return res
@@ -144,16 +149,18 @@ export function attachSignalingRoutes(
 				}) as typeof res.end
 
 				const params = match.slice(1)
-				Promise.resolve(
-					reinStorage.run(true, () => route.handler(req, res, ...params)),
-				).catch((err) => {
-					logger.error(`Signaling route error: ${String(err)}`)
-					if (!res.headersSent) {
-						reinStorage.run(true, () => {
-							json(res, 500, { error: "Internal server error" })
-						})
-					}
-				})
+				Promise.resolve()
+					.then(() =>
+						reinStorage.run(true, () => route.handler(req, res, ...params)),
+					)
+					.catch((err) => {
+						logger.error(`Signaling route error: ${String(err)}`)
+						if (!res.headersSent) {
+							reinStorage.run(true, () => {
+								json(res, 500, { error: "Internal server error" })
+							})
+						}
+					})
 				return
 			}
 		},

src/utils/i18n.ts

@@ -11,7 +11,7 @@ export const i18n = {
 			connectedButNoVideo: "Establishing stream...",
 			establishingSecure: "Establishing secure connection",
 			settingUpScreen: "Setting up screen sharing",
-			checkNetwork: "Please check your network or token",
+			checkNetwork: "Attempting to connect to the host.",
 		},
 	},
 } as const