fix(fraudlabspro): address coderabbit review comments

Author: ashwins01

components/fraudlabs_pro/actions/custom-api-call/custom-api-call.mjs

@@ -53,19 +53,20 @@ export default {
       requestBody,
     } = this;
 
-    if (!relativeUrl || !relativeUrl.startsWith("/")) {
+    const path = relativeUrl?.trim();
+    if (!path || !path.startsWith("/")) {
       throw new ConfigurationError("**Relative URL** must start with `/`, for example `/order/screen`.");
     }
 
     const response = await this.fraudlabsProApp._apiRequest({
       $,
       method: requestMethod,
-      path: relativeUrl,
+      path,
       params,
       data: requestBody,
     });
 
-    $.export("$summary", `Successfully called \`${requestMethod.toUpperCase()} ${relativeUrl}\``);
+    $.export("$summary", `Successfully called \`${requestMethod.toUpperCase()} ${path}\``);
     return response;
   },
 };

components/fraudlabs_pro/actions/send-sms-verification/send-sms-verification.mjs

@@ -53,7 +53,7 @@ export default {
 
     const response = await this.fraudlabsProApp.sendSmsVerification({
       $,
-      params: {
+      data: {
         tel,
         mesg,
         ...(format && {

components/fraudlabs_pro/fraudlabs_pro.app.mjs

@@ -65,27 +65,42 @@ export default {
     _apiRequest({
       $ = this, method = "get", path, params, data, ...args
     }) {
-      const fields = {
+      const auth = {
         format: "json",
-        ...params,
-        ...data,
         key: this.$auth.api_key,
       };
-      if (FORM_BODY_METHODS.includes(method.toLowerCase())) {
+      const isFormBody = FORM_BODY_METHODS.includes(method.toLowerCase());
+      // `params` always go on the query string. For write verbs `data` is the
+      // form body; for read verbs there is no body, so fold `data` into the query.
+      const queryParams = isFormBody
+        ? {
+          ...auth,
+          ...params,
+        }
+        : {
+          ...auth,
+          ...params,
+          ...data,
+        };
+      if (isFormBody) {
         return axios($, {
           url: `${this._apiBaseUrl()}${path}`,
           method,
+          params: queryParams,
           headers: {
             "Content-Type": "application/x-www-form-urlencoded",
           },
-          data: new URLSearchParams(fields).toString(),
+          data: new URLSearchParams({
+            ...auth,
+            ...data,
+          }).toString(),
           ...args,
         });
       }
       return axios($, {
         url: `${this._apiBaseUrl()}${path}`,
         method,
-        params: fields,
+        params: queryParams,
         ...args,
       });
     },

components/fraudlabs_pro/sources/status-changed/status-changed.mjs

@@ -86,8 +86,8 @@ export default {
     this.http.respond({
       status: 200,
       body: {
-		  message: "Success",
-	  },
+        message: "Success",
+      },
     });
   },
 };