Skip to content

Commit 29a6b52

Browse files
PlainSeerPlainSeer
committed
chore: stage one-shot Freeze Export AC-flow validator
1 parent 842d699 commit 29a6b52

1 file changed

Lines changed: 75 additions & 0 deletions

File tree

‎.github/workflows/apply-freeze-export-ac-flow.yml‎

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
name: apply-freeze-export-ac-flow
2+
3+
on:
4+
create:
5+
6+
permissions:
7+
contents: write
8+
9+
jobs:
10+
apply-and-validate:
11+
if: github.ref == 'refs/heads/internal-freeze-ac-flow-trigger'
12+
runs-on: ubuntu-latest
13+
steps:
14+
- uses: actions/checkout@v4
15+
with:
16+
ref: main
17+
fetch-depth: 0
18+
- uses: actions/setup-python@v4
19+
with:
20+
python-version: 3.x
21+
- uses: mlugg/setup-zig@v2
22+
with:
23+
version: 0.16.0
24+
- name: Install dependencies
25+
run: |
26+
python -m pip install --upgrade pip
27+
pip install -r requirements.txt
28+
pip install pre-commit
29+
- name: Apply revised Freeze Export accounting
30+
run: |
31+
python3 - <<'PY'
32+
from pathlib import Path
33+
def repl(path, old, new):
34+
p = Path(path); text = p.read_text(); n = text.count(old)
35+
if n != 1: raise RuntimeError(f'{path}: expected one match, got {n}')
36+
p.write_text(text.replace(old, new, 1))
37+
38+
repl('apps/predbat/prediction.py', ''' # Some inverters (observed on AlphaESS) continue to discharge the battery\n # during Freeze Export to supply house load. The configured value is measured\n # battery-side power, so pass it through the normal discharge and inverter-loss\n # paths, cap it at remaining house demand, and never create additional export.\n if inverter_freeze_export_discharge_rate > 0 and battery_draw >= 0:\n freeze_house_demand = get_diff(battery_draw, pv_dc, pv_ac, load_yesterday, inverter_loss, inverter_loss_recp)\n if freeze_house_demand > 0:\n freeze_soc_available = min(inverter_freeze_export_discharge_rate * step / 60000.0, max(soc - reserve_expected, 0))\n freeze_draw_limit = freeze_soc_available * battery_loss_discharge\n freeze_draw_for_house = freeze_house_demand * inverter_loss_recp\n battery_draw = min(freeze_draw_limit, freeze_draw_for_house)\n''', ''' # Some inverters (observed on AlphaESS) continue a residual battery\n # discharge during Freeze Export. The configured value is measured battery-side\n # power; feed it into the normal AC energy balance so house load consumes it first\n # and any excess naturally becomes grid export.\n if inverter_freeze_export_discharge_rate > 0 and battery_draw >= 0:\n freeze_soc_available = min(inverter_freeze_export_discharge_rate * step / 60000.0, max(soc - reserve_expected, 0))\n freeze_draw_limit = freeze_soc_available * battery_loss_discharge\n battery_draw = max(battery_draw, freeze_draw_limit)\n''')
39+
40+
repl('apps/predbat/prediction_kernel.cpp', ''' // Some inverters (observed on AlphaESS) continue to discharge the battery\n // during Freeze Export to supply house load. The configured value is battery-side\n // power; route it through normal discharge and inverter losses and cap at load.\n if (inverter_freeze_export_discharge_rate > 0 && battery_draw >= 0) {\n const double freeze_house_demand = get_diff(battery_draw, pv_dc, pv_ac, load_yesterday, inverter_loss, inverter_loss_recp);\n if (freeze_house_demand > 0) {\n const double freeze_soc_available = std::min(inverter_freeze_export_discharge_rate * step / 60000.0, std::max(soc - reserve_expected, 0.0));\n const double freeze_draw_limit = freeze_soc_available * battery_loss_discharge;\n const double freeze_draw_for_house = freeze_house_demand * inverter_loss_recp;\n battery_draw = std::min(freeze_draw_limit, freeze_draw_for_house);\n }\n }\n''', ''' // Some inverters (observed on AlphaESS) continue a residual battery\n // discharge during Freeze Export. The configured value is battery-side power; feed\n // it into the normal AC energy balance so house load consumes it first and any excess\n // naturally becomes grid export.\n if (inverter_freeze_export_discharge_rate > 0 && battery_draw >= 0) {\n const double freeze_soc_available = std::min(inverter_freeze_export_discharge_rate * step / 60000.0, std::max(soc - reserve_expected, 0.0));\n const double freeze_draw_limit = freeze_soc_available * battery_loss_discharge;\n battery_draw = std::max(battery_draw, freeze_draw_limit);\n }\n''')
41+
42+
repl('apps/predbat/prediction_kernel.cpp', '#define PK_PARITY_REVISION 8\n', '#define PK_PARITY_REVISION 9\n')
43+
repl('apps/predbat/prediction_kernel.py', 'KERNEL_PARITY_REVISION = 8\n', 'KERNEL_PARITY_REVISION = 9\n')
44+
repl('apps/predbat/predbat.py', ' # Battery-side discharge (W) that may continue to supply house load during Freeze Export.\n', ' # Battery-side residual discharge (W) during Freeze Export; AC balance decides house use vs export.\n')
45+
repl('apps/predbat/tests/test_model.py', ''' # Freeze Export discharge should represent real battery energy supplied to house load.\n # Normal battery discharge is disabled here so only this configured path is under test.\n # 240 W for one hour is 0.24 kWh battery-side.\n''', ''' # Freeze Export residual discharge is real battery energy delivered to the AC side.\n # House load consumes it first and any excess can flow to grid export. Normal battery\n # discharge is disabled here so only this configured path is under test.\n # 240 W for one hour is 0.24 kWh battery-side.\n''')
46+
repl('apps/predbat/tests/test_model.py', ''' failed |= simple_scenario(\n "freeze_export_house_supply_no_load",\n my_predbat,\n 0,\n 0,\n assert_final_metric=0,\n assert_final_soc=10.0,\n battery_size=10.0,\n battery_soc=10.0,\n discharge=99,\n end_record=60,\n inverter_freeze_export_discharge_rate=240.0,\n battery_rate_max_charge=0.0,\n assert_battery_cycle=0.0,\n )\n''', ''' failed |= simple_scenario(\n "freeze_export_residual_exports_when_no_load",\n my_predbat,\n 0,\n 0,\n assert_final_metric=-1.2,\n assert_final_soc=9.76,\n battery_size=10.0,\n battery_soc=10.0,\n discharge=99,\n end_record=60,\n inverter_freeze_export_discharge_rate=240.0,\n battery_rate_max_charge=0.0,\n assert_battery_cycle=0.24,\n )\n''')
47+
PY
48+
- name: Pre-commit touched files
49+
run: |
50+
pre-commit run --files apps/predbat/predbat.py apps/predbat/prediction.py apps/predbat/prediction_kernel.cpp apps/predbat/prediction_kernel.py apps/predbat/tests/test_model.py || pre-commit run --files apps/predbat/predbat.py apps/predbat/prediction.py apps/predbat/prediction_kernel.cpp apps/predbat/prediction_kernel.py apps/predbat/tests/test_model.py
51+
- name: Build and test native kernel
52+
env:
53+
PREDBAT_KERNEL_REQUIRED: "1"
54+
run: |
55+
bash apps/predbat/build_kernel.sh
56+
cd coverage
57+
python3 ../apps/predbat/unit_test.py --quick
58+
cd ..
59+
- name: Cross-build all kernel binaries
60+
run: bash apps/predbat/build_kernel_cross.sh
61+
- name: Verify x86_64 kernel
62+
run: |
63+
cd coverage
64+
python3 ../apps/predbat/verify_kernel_binary.py ../apps/predbat/prediction_kernel_lib_x86_64.so
65+
- name: Publish one clean commit
66+
env:
67+
BASE_SHA: 842d69946d28d6fba46dc02f5ccacaf3db627b7c
68+
run: |
69+
git config user.name "github-actions[bot]"
70+
git config user.email "github-actions[bot]@users.noreply.github.com"
71+
rm -f .github/workflows/apply-freeze-export-ac-flow.yml
72+
git reset --soft "$BASE_SHA"
73+
git add -A
74+
git commit -m "fix(prediction): model Freeze Export residual AC flow"
75+
git push --force-with-lease origin HEAD:main

0 commit comments

Comments
 (0)