Explicit error messages, attempt to fix branching issue.

Author: PlatinumMaster

Handlers/MessageHandler.cs

@@ -14,6 +14,16 @@ public static void errorMessage(string title, string caption) {
                 Style = Style.None
             }).Show();
         }
+        
+        public static void warnMessage(string title, string caption) {
+            MessageBoxManager.GetMessageBoxStandardWindow(new MessageBoxStandardParams {
+                ButtonDefinitions = ButtonEnum.Ok,
+                ContentTitle = $"Warning: {title}",
+                ContentMessage = caption,
+                Icon = Icon.Warning,
+                Style = Style.None
+            }).Show();
+        }
 
         public static Task<ButtonResult> yesNoMessage(string title, string caption) {
             return MessageBoxManager.GetMessageBoxStandardWindow(new MessageBoxStandardParams {

Util.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
+using System.Runtime.InteropServices;
 using System.Text;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
@@ -21,7 +22,7 @@ public static void initializePatcher(string baseROMConfigurationPath, string con
             gameInfo = GameInformation.getGameConfiguration(patcher.getGameCode());
             try {
                 if (!CommandUpdateHandler.fetchScriptCommands()) {
-                    throw new Exception("Something is wrong!");
+                    throw new Exception("Something went wrong when fetching commands!");
                 }
             }
             catch (Exception e) {
@@ -45,7 +46,7 @@ public static void scriptToAssembler(string path, string game, string script, in
             }
         }
 
-        private static void subprocess(string program, string args) {
+        private static string subprocess(string program, string args) {
             var proc = new Process();
             proc.StartInfo = new ProcessStartInfo {
                 FileName = program,
@@ -55,21 +56,29 @@ private static void subprocess(string program, string args) {
                 CreateNoWindow = true
             };
 
-            proc.Start();
+            if (!proc.Start()) {
+                return
+                    $"Error: Program \"{program}\" was not found.\n" +
+                    "If this is one of the arm executables and you are not on Windows, make sure you have arm-none-eabi-binutils installed (and in your path), and try again.\n" +
+                    "If this is one of the arm executables and you are a Windows user, make sure arm-none-eabi-as and arm-none-eabi-objcopy are in the same folder as SwissArmyKnife, or in a location referred to by your system path.";
+            }
+            
+            StringBuilder Str = new StringBuilder();
+            while (!proc.StandardOutput.EndOfStream) {
+                Str.Append(proc.StandardOutput.ReadLine());
+            }
+            
             proc.WaitForExit();
 
-            var errorOutput = proc.StandardError.ReadToEnd();
-
-            if (proc.ExitCode != 0)
-                throw new Exception(errorOutput);
+            return Str.ToString();
         }
 
-        public static void assembler(string path, string output) {
-            subprocess("arm-none-eabi-as", $"-mthumb -c \"{path}\" -o \"{output}\"");
+        public static string assembler(string path, string output) {
+            return subprocess("arm-none-eabi-as", $"-mthumb -c \"{path}\" -o \"{output}\"");
         }
 
-        public static void objectCopy(string path, string output) {
-            subprocess("arm-none-eabi-objcopy", $"-O binary \"{path}\" \"{output}\"");
+        public static string objectCopy(string path, string output) {
+            return subprocess("arm-none-eabi-objcopy", $"-O binary \"{path}\" \"{output}\"");
         }
 
         private static async Task<string> handleFolderFileChoice(bool saving, bool isFile, Window parentInstance,
@@ -83,7 +92,7 @@ private static async Task<string> handleFolderFileChoice(bool saving, bool isFil
                     string[] resultArray =
                         await new OpenFileDialog {Filters = dialogFilter, AllowMultiple = false}.ShowAsync(
                             parentInstance);
-                    result = resultArray.Length != 0 ? resultArray[0] : null;
+                    result = resultArray != null && resultArray.Length != 0 ? resultArray[0] : null;
                 }
             }
             else {

ViewModels/Editors/ScriptEditorViewModel.cs

@@ -5,6 +5,7 @@
 using BeaterLibrary;
 using BeaterLibrary.Formats.Scripts;
 using ReactiveUI;
+using SwissArmyKnife.Avalonia.Handlers;
 using SwissArmyKnife.Avalonia.Utils;
 
 namespace SwissArmyKnife.Avalonia.ViewModels.Editors {
@@ -46,7 +47,7 @@ private void changeScript(int index) {
                     ));
             }
             catch (Exception ex) {
-                textDoc.Text = "Something went wrong when decompiling this script.";
+                textDoc.Text = "Something went wrong when decompiling this script.\n" + ex;
             }
         }
 
@@ -65,10 +66,21 @@ public override void onSaveChanges() {
                 _selectedIndex,
                 x => {
                     UI.patcher.saveToNarcFolder(UI.gameInfo.scripts, selectedIndex, x => {
-                        UI.scriptToAssembler("Temp.s", UI.gameInfo.title, textDoc.Text,
-                            UI.gameInfo.getScriptPluginsByScrId(selectedIndex));
-                        UI.assembler("Temp.s", "Temp.o");
-                        UI.objectCopy("Temp.o", x);
+                        UI.scriptToAssembler("Temp.s", UI.gameInfo.title, textDoc.Text, UI.gameInfo.getScriptPluginsByScrId(selectedIndex));
+                        
+                        // Hacky way to detect errors.
+                        string ASResult = UI.assembler("Temp.s", "Temp.o");
+                        MessageHandler.warnMessage("Assembler output", $"If you see any errors here, there was a compilation error, and the file was not created.\nThe output is as follows:\n\n{ASResult}");
+                        if (ASResult.Contains("Error")) {
+                            return;
+                        }
+                        
+                        string OBJResult = UI.objectCopy("Temp.o", x);
+                        MessageHandler.warnMessage("Objcopy output", $"If you see any errors here, there was a linking error, and the file was not created.\nThe output is as follows:\n\n{OBJResult}");
+                        if (OBJResult.Contains("Error")) {
+                            return;
+                        }
+
                         File.Delete("Temp.s");
                         File.Delete("Temp.o");
                     });

ViewModels/Editors/WildPokemonViewModel.cs

@@ -115,7 +115,7 @@ private void changeWildContainer(int index) {
                 }
             }
             catch (Exception ex) {
-                MessageHandler.errorMessage("Invalid wild encounter container", "This file is invalid.");
+                MessageHandler.errorMessage("Invalid wild encounter container", "This file is invalid.\n" + ex.ToString());
             }
         }
 

ViewModels/Editors/ZoneEntitiesViewModel.cs

@@ -156,6 +156,7 @@ public override void onSaveChanges() {
             currentZoneEntities.triggers = new List<Trigger>(triggers);
             currentZoneEntities.initializationScripts = new List<InitializationScript>(initScripts);
             currentZoneEntities.triggerRelatedEntries = new List<TriggerRelated>(triggerRelated);
+            // currentZoneEntities.serialize();
         }
     }
 }

ViewModels/NewProjectViewModel.cs

@@ -65,7 +65,7 @@ public NewProjectViewModel(baseROMConfiguration baseROMs, Window instance) {
                             UI.patcher.handleROM(false);
                         }
                         catch (Exception ex) {
-                            MessageHandler.errorMessage("Initialization Error", ex.Message);
+                            MessageHandler.errorMessage("Initialization Error", ex.ToString());
                         }
                     }
                 }
@@ -112,7 +112,7 @@ private bool createProjectStructure() {
                 return true;
             }
             catch (Exception e) {
-                MessageHandler.errorMessage("Project Creation", $"Failed to create project. \"{e.Message}\"");
+                MessageHandler.errorMessage("Project Creation", $"Failed to create project. \"{e}\"");
                 return false;
             }
         }