Skip to content

Commit 0002b0d

Browse files
committed
Parquet output: remove dead code found in full audit
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
1 parent 53e2b21 commit 0002b0d

8 files changed

Lines changed: 0 additions & 137 deletions

cpp/csp/adapters/parquet/ArrowBackedArrayBuilder.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,6 @@ std::shared_ptr<::arrow::DataType> ArrowBackedArrayBuilder::getDataType()
9595
return m_writer -> dataTypes()[0];
9696
}
9797

98-
std::shared_ptr<::arrow::ArrayBuilder> ArrowBackedArrayBuilder::getBuilder()
99-
{
100-
return m_writer -> builder();
101-
}
102-
10398
int64_t ArrowBackedArrayBuilder::length() const
10499
{
105100
return m_writer -> builder() -> length();

cpp/csp/adapters/parquet/ArrowBackedArrayBuilder.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ class ArrowBackedArrayBuilder : public ArrowSingleColumnArrayBuilder
3939

4040
// --- ArrowSingleColumnArrayBuilder interface ---
4141
std::shared_ptr<::arrow::DataType> getDataType() override;
42-
std::shared_ptr<::arrow::ArrayBuilder> getBuilder() override;
4342
int64_t length() const override;
4443
void handleRowFinished() override;
4544
std::shared_ptr<::arrow::Array> buildArray() override;

cpp/csp/adapters/parquet/ArrowSingleColumnArrayBuilder.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ class ArrowSingleColumnArrayBuilder
2525
virtual ~ArrowSingleColumnArrayBuilder() {}
2626

2727
virtual std::shared_ptr<::arrow::DataType> getDataType() = 0;
28-
virtual std::shared_ptr<::arrow::ArrayBuilder> getBuilder() = 0;
2928

3029
virtual int64_t length() const = 0;
3130

@@ -64,11 +63,6 @@ class ListColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
6463
return m_builderPtr -> type();
6564
}
6665

67-
virtual std::shared_ptr<::arrow::ArrayBuilder> getBuilder() override
68-
{
69-
return m_builderPtr;
70-
}
71-
7266
virtual int64_t length() const override
7367
{
7468
return m_builderPtr -> length();

cpp/csp/adapters/parquet/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
set(PARQUET_HEADER_FILES
22
ArrowBackedArrayBuilder.h
33
ArrowSingleColumnArrayBuilder.h
4-
FileNameGeneratorReplicator.h
54
ParquetDictBasketOutputWriter.h
65
ParquetInputAdapterManager.h
76
ParquetOutputAdapter.h
@@ -12,7 +11,6 @@ set(PARQUET_HEADER_FILES
1211
RecordBatchFileSink.h
1312
RecordBatchSink.h
1413
RecordBatchStreamSource.h
15-
RecordBatchWithFlag.h
1614
)
1715

1816
set(PARQUET_SOURCE_FILES

cpp/csp/adapters/parquet/FileNameGeneratorReplicator.h

Lines changed: 0 additions & 95 deletions
This file was deleted.

cpp/csp/adapters/parquet/ParquetWriter.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,6 @@ ListColumnParquetOutputAdapter *ParquetWriter::getListOutputAdapter(
110110
return res;
111111
}
112112

113-
PushInputAdapter *ParquetWriter::getStatusAdapter()
114-
{
115-
return nullptr;
116-
}
117-
118113
void ParquetWriter::start()
119114
{
120115
std::vector<std::shared_ptr<::arrow::Field>> arrowFields;

cpp/csp/adapters/parquet/ParquetWriter.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ class ParquetWriter : public EndCycleListener
4444
StructParquetOutputHandler *getStructOutputHandler( CspTypePtr &type, csp::DictionaryPtr fieldMap );
4545
ListColumnParquetOutputHandler *getListOutputHandler( CspTypePtr &elemType, const std::string &columnName );
4646

47-
PushInputAdapter *getStatusAdapter();
48-
4947
virtual void start();
5048
virtual void stop();
5149

cpp/csp/adapters/parquet/RecordBatchWithFlag.h

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)