Merge pull request #514 from Point72/fix/datetime

mildek · web-flow · commit 02e2a0fffb43 · 2025-04-02T09:53:46.000+02:00
fix: proper catching of datetime type in py_push_pull adapter
diff --git a/cpp/csp/python/PyPushPullInputAdapter.cpp b/cpp/csp/python/PyPushPullInputAdapter.cpp
@@ -69,11 +69,12 @@ class TypedPyPushPullInputAdapter : public PyPushPullInputAdapter
 
     void pushPyTick( bool live, PyObject * time, PyObject * value, PushBatch * batch ) override
     {
+        DateTime t = fromPython<DateTime>( time );
         try
         {
             if( !validatePyType( this -> dataType(), m_pyType.ptr(), value ) )
                 CSP_THROW( TypeError, "" );
-            pushTick<T>( live, fromPython<DateTime>( time ), std::move( fromPython<T>( value, *this -> dataType() ) ), batch );
+            pushTick<T>( live, t, std::move( fromPython<T>( value, *this -> dataType() ) ), batch );
         }
         catch( const TypeError & )
         {

Original file line number	Diff line number	Diff line change
`@@ -69,11 +69,12 @@ class TypedPyPushPullInputAdapter : public PyPushPullInputAdapter`
`69`	`69`
`70`	`70`	`void pushPyTick( bool live, PyObject * time, PyObject * value, PushBatch * batch ) override`
`71`	`71`	`{`
	`72`	`+ DateTime t = fromPython<DateTime>( time );`
`72`	`73`	`try`
`73`	`74`	`{`
`74`	`75`	`if( !validatePyType( this -> dataType(), m_pyType.ptr(), value ) )`
`75`	`76`	`CSP_THROW( TypeError, "" );`
`76`		`- pushTick<T>( live, fromPython<DateTime>( time ), std::move( fromPython<T>( value, *this -> dataType() ) ), batch );`
	`77`	`+ pushTick<T>( live, t, std::move( fromPython<T>( value, *this -> dataType() ) ), batch );`
`77`	`78`	`}`
`78`	`79`	`catch( const TypeError & )`
`79`	`80`	`{`