Skip to content

Commit 2ac4688

Browse files
arhamchopraarhamchopra
committed
Qualify arrow:: as ::arrow:: in writer headers to avoid namespace ambiguity
The introduction of namespace csp::adapters::arrow (for the new ColumnDispatcher/RecordBatchRowProcessor classes) creates ambiguity when writer-side headers use unqualified arrow:: inside namespace csp::adapters::parquet. The compiler finds the sibling csp::adapters::arrow namespace before the global ::arrow namespace. Also forward-declares ColumnDispatcher and RecordBatchRowProcessor in ParquetInputAdapterManager.h (moving full includes to .cpp) and adds direct includes for csp/core/Exception.h and arrow/table.h that were previously provided transitively through the now-deleted reader headers. Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
1 parent 468bd2a commit 2ac4688

10 files changed

Lines changed: 76 additions & 67 deletions

‎cpp/csp/adapters/parquet/ArrowSingleColumnArrayBuilder.h‎

Lines changed: 55 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ class ArrowSingleColumnArrayBuilder
2424

2525
virtual ~ArrowSingleColumnArrayBuilder() {}
2626

27-
virtual std::shared_ptr<arrow::DataType> getDataType() = 0;
28-
virtual std::shared_ptr<arrow::ArrayBuilder> getBuilder() = 0;
27+
virtual std::shared_ptr<::arrow::DataType> getDataType() = 0;
28+
virtual std::shared_ptr<::arrow::ArrayBuilder> getBuilder() = 0;
2929

3030
virtual int64_t length() const = 0;
3131

@@ -36,7 +36,7 @@ class ArrowSingleColumnArrayBuilder
3636
// Called for each row of the output parquet row, if no value was provided a null should be appended
3737
virtual void handleRowFinished() = 0;
3838
// Release the array from the currently built values
39-
virtual std::shared_ptr<arrow::Array> buildArray() = 0;
39+
virtual std::shared_ptr<::arrow::Array> buildArray() = 0;
4040

4141
private:
4242
const std::string m_columnName;
@@ -55,19 +55,19 @@ class StructColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
5555
FieldValueSetter fieldValueSetter )
5656
: ArrowSingleColumnArrayBuilder( columnName, chunkSize ),
5757
m_childArrayBuilders( childArrayBuilders ),
58-
m_builderPtr( std::make_shared<::arrow::StructBuilder>( type, arrow::default_memory_pool(),
58+
m_builderPtr( std::make_shared<::arrow::StructBuilder>( type, ::arrow::default_memory_pool(),
5959
getArrowChildArrayBuilders( childArrayBuilders ) ) ),
6060
m_fieldValueSetter( fieldValueSetter ),
6161
m_hasValue( false )
6262
{
6363
}
6464

65-
virtual std::shared_ptr<arrow::DataType> getDataType() override
65+
virtual std::shared_ptr<::arrow::DataType> getDataType() override
6666
{
6767
return m_builderPtr -> type();
6868
}
6969

70-
virtual std::shared_ptr<arrow::ArrayBuilder> getBuilder() override
70+
virtual std::shared_ptr<::arrow::ArrayBuilder> getBuilder() override
7171
{
7272
return m_builderPtr;
7373
}
@@ -96,9 +96,9 @@ class StructColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
9696
}
9797

9898
// Release the array from the currently built values
99-
virtual std::shared_ptr<arrow::Array> buildArray() override
99+
virtual std::shared_ptr<::arrow::Array> buildArray() override
100100
{
101-
std::shared_ptr<arrow::Array> array;
101+
std::shared_ptr<::arrow::Array> array;
102102
STATUS_OK_OR_THROW_RUNTIME( m_builderPtr -> Finish( &array ), "Failed to create arrow array" );
103103
return array;
104104
}
@@ -136,22 +136,22 @@ class ListColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
136136
using ColumnBuilderPtr = std::shared_ptr<ArrowSingleColumnArrayBuilder>;
137137

138138
ListColumnArrayBuilder( std::string columnName, std::uint32_t chunkSize,
139-
const std::shared_ptr<arrow::ArrayBuilder>& valueBuilder,
139+
const std::shared_ptr<::arrow::ArrayBuilder>& valueBuilder,
140140
const DialectGenericListWriterInterface::Ptr& listWriterInterface)
141141
: ArrowSingleColumnArrayBuilder( columnName, chunkSize ),
142142
m_valueBuilder( valueBuilder ),
143-
m_builderPtr( std::make_shared<::arrow::ListBuilder>( arrow::default_memory_pool(), m_valueBuilder ) ),
143+
m_builderPtr( std::make_shared<::arrow::ListBuilder>( ::arrow::default_memory_pool(), m_valueBuilder ) ),
144144
m_listWriterInterface(listWriterInterface)
145145
{
146146

147147
}
148148

149-
virtual std::shared_ptr<arrow::DataType> getDataType() override
149+
virtual std::shared_ptr<::arrow::DataType> getDataType() override
150150
{
151151
return m_builderPtr -> type();
152152
}
153153

154-
virtual std::shared_ptr<arrow::ArrayBuilder> getBuilder() override
154+
virtual std::shared_ptr<::arrow::ArrayBuilder> getBuilder() override
155155
{
156156
return m_builderPtr;
157157
}
@@ -177,9 +177,9 @@ class ListColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
177177
}
178178

179179
// Release the array from the currently built values
180-
virtual std::shared_ptr<arrow::Array> buildArray() override
180+
virtual std::shared_ptr<::arrow::Array> buildArray() override
181181
{
182-
std::shared_ptr<arrow::Array> array;
182+
std::shared_ptr<::arrow::Array> array;
183183
STATUS_OK_OR_THROW_RUNTIME( m_builderPtr -> Finish( &array ), "Failed to create arrow list array" );
184184
return array;
185185
}
@@ -190,16 +190,16 @@ class ListColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
190190
}
191191

192192
private:
193-
static std::shared_ptr<arrow::ArrayBuilder> createValueArrayBuilderForType( const std::shared_ptr<::arrow::DataType> &childType)
193+
static std::shared_ptr<::arrow::ArrayBuilder> createValueArrayBuilderForType( const std::shared_ptr<::arrow::DataType> &childType)
194194
{
195195
switch(childType->id())
196196
{
197-
case arrow::Type::INT64:
198-
return std::make_shared<arrow::Int64Builder>();
199-
case arrow::Type::DOUBLE:
200-
return std::make_shared<arrow::DoubleBuilder>();
201-
case arrow::Type::BOOL:
202-
return std::make_shared<arrow::BooleanBuilder>();
197+
case ::arrow::Type::INT64:
198+
return std::make_shared<::arrow::Int64Builder>();
199+
case ::arrow::Type::DOUBLE:
200+
return std::make_shared<::arrow::DoubleBuilder>();
201+
case ::arrow::Type::BOOL:
202+
return std::make_shared<::arrow::BooleanBuilder>();
203203
default:
204204
CSP_THROW(TypeError, "Trying to create arrow list array builder for unsupported element type " << childType->name());
205205
}
@@ -218,7 +218,7 @@ class ListColumnArrayBuilder : public ArrowSingleColumnArrayBuilder
218218
}
219219

220220
private:
221-
std::shared_ptr<arrow::ArrayBuilder> m_valueBuilder;
221+
std::shared_ptr<::arrow::ArrayBuilder> m_valueBuilder;
222222
std::shared_ptr<::arrow::ListBuilder> m_builderPtr;
223223
DialectGenericListWriterInterface::Ptr m_listWriterInterface;
224224
std::optional<DialectGenericType> m_value;
@@ -239,12 +239,12 @@ class BaseTypedArrayBuilder : public ArrowSingleColumnArrayBuilder
239239
CSP_TRUE_OR_THROW_RUNTIME( m_builderPtr -> Reserve( getChunkSize() ).ok(), "Failed to reserve arrow array size" );
240240
}
241241

242-
std::shared_ptr<arrow::ArrayBuilder> getBuilder() override
242+
std::shared_ptr<::arrow::ArrayBuilder> getBuilder() override
243243
{
244244
return m_builderPtr;
245245
}
246246

247-
std::shared_ptr<arrow::DataType> getDataType() override
247+
std::shared_ptr<::arrow::DataType> getDataType() override
248248
{
249249
return m_builderPtr -> type();
250250
}
@@ -267,9 +267,9 @@ class BaseTypedArrayBuilder : public ArrowSingleColumnArrayBuilder
267267
m_value = nullptr;
268268
}
269269

270-
std::shared_ptr<arrow::Array> buildArray() override
270+
std::shared_ptr<::arrow::Array> buildArray() override
271271
{
272-
std::shared_ptr<arrow::Array> array;
272+
std::shared_ptr<::arrow::Array> array;
273273
CSP_TRUE_OR_THROW_RUNTIME( m_builderPtr -> Finish( &array ).ok(), "Failed to create arrow array" );
274274
return array;
275275
}
@@ -308,10 +308,10 @@ class PrimitiveTypedArrayBuilder : public BaseTypedArrayBuilder<ValueType, Arrow
308308
}
309309
};
310310

311-
class StringArrayBuilder : public BaseTypedArrayBuilder<std::string, arrow::StringBuilder>
311+
class StringArrayBuilder : public BaseTypedArrayBuilder<std::string, ::arrow::StringBuilder>
312312
{
313313
public:
314-
using BaseTypedArrayBuilder<std::string, arrow::StringBuilder>::BaseTypedArrayBuilder;
314+
using BaseTypedArrayBuilder<std::string, ::arrow::StringBuilder>::BaseTypedArrayBuilder;
315315

316316
protected:
317317
void pushValueToArray()
@@ -322,10 +322,10 @@ class StringArrayBuilder : public BaseTypedArrayBuilder<std::string, arrow::Stri
322322
}
323323
};
324324

325-
class BytesArrayBuilder : public BaseTypedArrayBuilder<std::string, arrow::BinaryBuilder>
325+
class BytesArrayBuilder : public BaseTypedArrayBuilder<std::string, ::arrow::BinaryBuilder>
326326
{
327327
public:
328-
using BaseTypedArrayBuilder<std::string, arrow::BinaryBuilder>::BaseTypedArrayBuilder;
328+
using BaseTypedArrayBuilder<std::string, ::arrow::BinaryBuilder>::BaseTypedArrayBuilder;
329329

330330
protected:
331331
void pushValueToArray()
@@ -336,10 +336,10 @@ class BytesArrayBuilder : public BaseTypedArrayBuilder<std::string, arrow::Binar
336336
}
337337
};
338338

339-
class [[maybe_unused]] CStringArrayBuilder : public BaseTypedArrayBuilder<const char *, arrow::StringBuilder>
339+
class [[maybe_unused]] CStringArrayBuilder : public BaseTypedArrayBuilder<const char *, ::arrow::StringBuilder>
340340
{
341341
public:
342-
using BaseTypedArrayBuilder<const char *, arrow::StringBuilder>::BaseTypedArrayBuilder;
342+
using BaseTypedArrayBuilder<const char *, ::arrow::StringBuilder>::BaseTypedArrayBuilder;
343343

344344
[[maybe_unused]] void setValueCopyPtr( const char *value )
345345
{
@@ -359,15 +359,15 @@ class [[maybe_unused]] CStringArrayBuilder : public BaseTypedArrayBuilder<const
359359
};
360360

361361

362-
class DatetimeArrayBuilder : public BaseTypedArrayBuilder<csp::DateTime, arrow::TimestampBuilder>
362+
class DatetimeArrayBuilder : public BaseTypedArrayBuilder<csp::DateTime, ::arrow::TimestampBuilder>
363363
{
364364
public:
365365
DatetimeArrayBuilder( std::string columnName, std::uint32_t chunkSize )
366-
: BaseTypedArrayBuilder<csp::DateTime, arrow::TimestampBuilder>( columnName,
366+
: BaseTypedArrayBuilder<csp::DateTime, ::arrow::TimestampBuilder>( columnName,
367367
chunkSize,
368-
std::make_shared<arrow::TimestampType>( arrow::TimeUnit::NANO,
368+
std::make_shared<::arrow::TimestampType>( ::arrow::TimeUnit::NANO,
369369
"UTC" ),
370-
arrow::default_memory_pool() )
370+
::arrow::default_memory_pool() )
371371
{
372372
}
373373

@@ -379,11 +379,11 @@ class DatetimeArrayBuilder : public BaseTypedArrayBuilder<csp::DateTime, arrow::
379379
}
380380
};
381381

382-
class DateArrayBuilder : public BaseTypedArrayBuilder<csp::Date, arrow::Date32Builder>
382+
class DateArrayBuilder : public BaseTypedArrayBuilder<csp::Date, ::arrow::Date32Builder>
383383
{
384384
public:
385385
DateArrayBuilder( std::string columnName, std::uint32_t chunkSize )
386-
: BaseTypedArrayBuilder<csp::Date, arrow::Date32Builder>( columnName,
386+
: BaseTypedArrayBuilder<csp::Date, ::arrow::Date32Builder>( columnName,
387387
chunkSize )
388388
{
389389
}
@@ -403,12 +403,12 @@ class DateArrayBuilder : public BaseTypedArrayBuilder<csp::Date, arrow::Date32Bu
403403
}
404404
};
405405

406-
class TimeArrayBuilder : public BaseTypedArrayBuilder<csp::Time, arrow::Time64Builder>
406+
class TimeArrayBuilder : public BaseTypedArrayBuilder<csp::Time, ::arrow::Time64Builder>
407407
{
408408
public:
409409
TimeArrayBuilder( std::string columnName, std::uint32_t chunkSize )
410-
: BaseTypedArrayBuilder<csp::Time, arrow::Time64Builder>( columnName, chunkSize,
411-
std::make_shared<arrow::Time64Type>( arrow::TimeUnit::NANO ), arrow::default_memory_pool() )
410+
: BaseTypedArrayBuilder<csp::Time, ::arrow::Time64Builder>( columnName, chunkSize,
411+
std::make_shared<::arrow::Time64Type>( ::arrow::TimeUnit::NANO ), ::arrow::default_memory_pool() )
412412
{
413413
}
414414

@@ -419,13 +419,13 @@ class TimeArrayBuilder : public BaseTypedArrayBuilder<csp::Time, arrow::Time64Bu
419419
}
420420
};
421421

422-
class TimedeltaArrayBuilder : public BaseTypedArrayBuilder<csp::TimeDelta, arrow::DurationBuilder>
422+
class TimedeltaArrayBuilder : public BaseTypedArrayBuilder<csp::TimeDelta, ::arrow::DurationBuilder>
423423
{
424424
public:
425425
TimedeltaArrayBuilder( std::string columnName, std::uint32_t chunkSize )
426-
: BaseTypedArrayBuilder<csp::TimeDelta, arrow::DurationBuilder>(
427-
columnName, chunkSize, std::make_shared<arrow::DurationType>( arrow::TimeUnit::NANO ),
428-
arrow::default_memory_pool() )
426+
: BaseTypedArrayBuilder<csp::TimeDelta, ::arrow::DurationBuilder>(
427+
columnName, chunkSize, std::make_shared<::arrow::DurationType>( ::arrow::TimeUnit::NANO ),
428+
::arrow::default_memory_pool() )
429429
{
430430
}
431431

@@ -437,16 +437,16 @@ class TimedeltaArrayBuilder : public BaseTypedArrayBuilder<csp::TimeDelta, arrow
437437
}
438438
};
439439

440-
using BoolArrayBuilder = PrimitiveTypedArrayBuilder<bool, arrow::BooleanBuilder>;
441-
using Int8ArrayBuilder = PrimitiveTypedArrayBuilder<std::int8_t, arrow::Int8Builder>;
442-
using Int16ArrayBuilder = PrimitiveTypedArrayBuilder<std::int16_t, arrow::Int16Builder>;
443-
using Int32ArrayBuilder = PrimitiveTypedArrayBuilder<std::int32_t, arrow::Int32Builder>;
444-
using Int64ArrayBuilder = PrimitiveTypedArrayBuilder<std::int64_t, arrow::Int64Builder>;
445-
using UInt8ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint8_t, arrow::UInt8Builder>;
446-
using UInt16ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint16_t, arrow::UInt16Builder>;
447-
using UInt32ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint32_t, arrow::UInt32Builder>;
448-
using UInt64ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint64_t, arrow::UInt64Builder>;
449-
using DoubleArrayBuilder = PrimitiveTypedArrayBuilder<double, arrow::DoubleBuilder>;
440+
using BoolArrayBuilder = PrimitiveTypedArrayBuilder<bool, ::arrow::BooleanBuilder>;
441+
using Int8ArrayBuilder = PrimitiveTypedArrayBuilder<std::int8_t, ::arrow::Int8Builder>;
442+
using Int16ArrayBuilder = PrimitiveTypedArrayBuilder<std::int16_t, ::arrow::Int16Builder>;
443+
using Int32ArrayBuilder = PrimitiveTypedArrayBuilder<std::int32_t, ::arrow::Int32Builder>;
444+
using Int64ArrayBuilder = PrimitiveTypedArrayBuilder<std::int64_t, ::arrow::Int64Builder>;
445+
using UInt8ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint8_t, ::arrow::UInt8Builder>;
446+
using UInt16ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint16_t, ::arrow::UInt16Builder>;
447+
using UInt32ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint32_t, ::arrow::UInt32Builder>;
448+
using UInt64ArrayBuilder = PrimitiveTypedArrayBuilder<std::uint64_t, ::arrow::UInt64Builder>;
449+
using DoubleArrayBuilder = PrimitiveTypedArrayBuilder<double, ::arrow::DoubleBuilder>;
450450
}
451451

452452
#endif

‎cpp/csp/adapters/parquet/DialectGenericListWriterInterface.h‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
#define _IN_CSP_ADAPTERS_PARQUET_DialectGenericListWriterInterface_H
33

44
#include <memory>
5+
#include <functional>
6+
#include <csp/core/Exception.h>
57
#include <csp/engine/DialectGenericType.h>
68
#include <arrow/array/builder_base.h>
79

@@ -11,7 +13,7 @@ namespace csp::adapters::parquet
1113
class DialectGenericListWriterInterface
1214
{
1315
public:
14-
using ArrayBuilderPtr = std::shared_ptr<arrow::ArrayBuilder>;
16+
using ArrayBuilderPtr = std::shared_ptr<::arrow::ArrayBuilder>;
1517
using Ptr = std::shared_ptr<DialectGenericListWriterInterface>;
1618

1719
virtual void writeItems( const csp::DialectGenericType &listObject ) = 0;

‎cpp/csp/adapters/parquet/FileWriterWrapper.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class FileWriterWrapper
4040

4141

4242
static ::arrow::Compression::type resolveCompression( const std::string &compression );
43-
static std::unique_ptr<arrow::util::Codec> resolveCompressionCodec( const std::string &compression );
43+
static std::unique_ptr<::arrow::util::Codec> resolveCompressionCodec( const std::string &compression );
4444

4545
private:
4646
std::shared_ptr<::arrow::Schema> m_schema;

‎cpp/csp/adapters/parquet/FileWriterWrapperContainer.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include <arrow/array.h>
88
#include <arrow/builder.h>
99
#include <arrow/io/file.h>
10+
#include <arrow/table.h>
1011
#include <parquet/arrow/writer.h>
1112
#include <csp/core/Exception.h>
1213

‎cpp/csp/adapters/parquet/FileWriterWrapperContainer.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@ class FileWriterWrapperContainer
3535
protected:
3636
using WriterPtr = std::unique_ptr<FileWriterWrapper>;
3737

38-
static WriterPtr createSingleFileWrapper( const std::shared_ptr<arrow::Schema> &schema, bool isWriteArrowBinary );
38+
static WriterPtr createSingleFileWrapper( const std::shared_ptr<::arrow::Schema> &schema, bool isWriteArrowBinary );
3939
private:
4040
bool m_isOpen = false;
4141
};
4242

4343
class SingleFileWriterWrapperContainer final : public FileWriterWrapperContainer
4444
{
4545
public:
46-
SingleFileWriterWrapperContainer( std::shared_ptr<arrow::Schema> schema, bool isWriteArrowBinary );
46+
SingleFileWriterWrapperContainer( std::shared_ptr<::arrow::Schema> schema, bool isWriteArrowBinary );
4747
virtual void open( const std::string &fileName, const std::string &compression, bool allowOverwrite = false ) override;
4848
virtual void close() override;
4949
virtual void writeData( const std::vector<std::shared_ptr<ArrowSingleColumnArrayBuilder>> &columnBuilders ) override;
@@ -54,7 +54,7 @@ class SingleFileWriterWrapperContainer final : public FileWriterWrapperContainer
5454
class MultipleFileWriterWrapperContainer : public FileWriterWrapperContainer
5555
{
5656
public:
57-
MultipleFileWriterWrapperContainer( std::shared_ptr<arrow::Schema> schema, bool isWriteArrowBinary );
57+
MultipleFileWriterWrapperContainer( std::shared_ptr<::arrow::Schema> schema, bool isWriteArrowBinary );
5858
virtual void open( const std::string &fileName, const std::string &compression, bool allowOverwrite = false ) override;
5959
virtual void close() override;
6060
virtual void writeData( const std::vector<std::shared_ptr<ArrowSingleColumnArrayBuilder>> &columnBuilders ) override;

‎cpp/csp/adapters/parquet/ParquetInputAdapterManager.cpp‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#include <csp/adapters/parquet/ParquetInputAdapterManager.h>
2+
#include <csp/adapters/arrow/ColumnDispatcher.h>
3+
#include <csp/adapters/arrow/RecordBatchRowProcessor.h>
24
#include <csp/adapters/arrow/ArrowTypeVisitor.h>
35
#include <csp/engine/Dictionary.h>
46
#include <csp/engine/CspEnum.h>

‎cpp/csp/adapters/parquet/ParquetInputAdapterManager.h‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
#ifndef _IN_CSP_ADAPTERS_PARQUET_ParquetInputAdapterManager_H
22
#define _IN_CSP_ADAPTERS_PARQUET_ParquetInputAdapterManager_H
33

4-
#include <csp/adapters/arrow/ColumnDispatcher.h>
5-
#include <csp/adapters/arrow/RecordBatchRowProcessor.h>
64
#include <csp/adapters/parquet/RecordBatchStreamSource.h>
75
#include <csp/adapters/utils/StructAdapterInfo.h>
86
#include <csp/adapters/utils/ValueDispatcher.h>
@@ -14,6 +12,12 @@
1412
#include <string>
1513
#include <optional>
1614

15+
namespace csp::adapters::arrow
16+
{
17+
class ColumnDispatcher;
18+
class RecordBatchRowProcessor;
19+
}
20+
1721

1822
namespace csp::adapters::parquet
1923
{

‎cpp/csp/adapters/parquet/ParquetOutputAdapter.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class ListColumnParquetOutputHandler : public ParquetOutputHandler
9999
}
100100

101101
private:
102-
std::shared_ptr<arrow::ArrayBuilder> createValueBuilder( const CspTypePtr &elemType,
102+
std::shared_ptr<::arrow::ArrayBuilder> createValueBuilder( const CspTypePtr &elemType,
103103
DialectGenericListWriterInterface::Ptr &listWriterInterface );
104104

105105

‎cpp/csp/adapters/parquet/ParquetStatusUtils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#define STATUS_OK_OR_THROW_RUNTIME( EXPR, MESSAGE ) \
77
do \
88
{ \
9-
arrow::Status st = EXPR; \
9+
::arrow::Status st = EXPR; \
1010
CSP_TRUE_OR_THROW_RUNTIME( st.ok(), MESSAGE << ':' << st.ToString()); \
1111
} while( 0 )
1212

0 commit comments

Comments
 (0)