Nk/fix pydantic validate default warning (#636)

* Call validate_default insdie config, not annotation

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>

* Add test that no warning pops up

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>

---------

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>

Author: NeejWeej

csp/impl/wiring/signature.py

@@ -16,7 +16,6 @@
 
 if USE_PYDANTIC:
     from pydantic import (
-        Field,
         ValidationError,
         ValidationInfo,
         WrapValidator,
@@ -67,7 +66,7 @@ def _create_pydantic_models(self, name, inputs, outputs, defaults):
             for defn in inputs:
                 if defn.kind != ArgKind.ALARM:
                     default = defaults.get(defn.name, ...)
-                    typ = Annotated[adjust_annotations(defn.typ, make_optional=True), Field(validate_default=True)]
+                    typ = adjust_annotations(defn.typ, make_optional=True)
                     if defn.kind.is_scalar():  # Allow for SnapType and SnapKeyType
                         typ = Annotated[typ, WrapValidator(make_snap_validator(defn.typ))]
                     input_fields[f"{INPUT_PREFIX}{defn.name}"] = (typ, default)
@@ -89,7 +88,7 @@ def track_fields(cls, v, info):
                 return v
 
             # https://docs.pydantic.dev/latest/concepts/models/#dynamic-model-creation
-            config = {"arbitrary_types_allowed": True, "extra": "forbid"}
+            config = {"arbitrary_types_allowed": True, "extra": "forbid", "validate_default": True}
             validators = {
                 "validate_tvars": model_validator(mode="after")(validate_tvars),
                 "track_fields": field_validator("*", mode="before")(track_fields),

csp/tests/test_type_checking.py

@@ -4,6 +4,7 @@
 import sys
 import typing
 import unittest
+import warnings
 from datetime import datetime, time, timedelta
 from typing import Callable, Dict, List, Optional, Union
 
@@ -67,6 +68,12 @@ def graph():
 
         csp.run(graph, starttime=datetime(2020, 2, 7, 9), endtime=datetime(2020, 2, 7, 9, 1))
 
+    def test_const_eq_scalar_no_warning(self):
+        with warnings.catch_warnings(record=True) as caught:
+            warnings.simplefilter("always")
+            _ = csp.const(1) == 1
+            self.assertEqual(len(caught), 0)
+
     def test_runtime_type_check(self):
         ## native output type
         @csp.node