Skip to content

Commit 3eed9ee

Browse files
committed
websocket - raise a clear error is hostname isnt extracted from URI ( crashes otherwise ). Add Usage to example
Signed-off-by: Rob Ambalu <robert.ambalu@point72.com>
1 parent 7b38c87 commit 3eed9ee

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

csp/adapters/websocket.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,9 @@ def __init__(
405405
"""
406406
assert reconnect_interval >= timedelta(seconds=1)
407407
resp = urllib.parse.urlparse(uri)
408+
if resp.hostname is None:
409+
raise ValueError(f"Failed to parse host from URI: {uri}")
410+
408411
self._properties = dict(
409412
host=resp.hostname,
410413
# if no port is explicitly present in the uri, the resp.port is None

examples/03_using_adapters/websocket/e1_websocket_client.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ def g(uri: str):
2424

2525

2626
if __name__ == "__main__":
27+
if len(sys.argv) != 2:
28+
print("Usage: e1_websocket_client <uri>")
29+
sys.exit(1)
30+
2731
csp.run(
2832
g,
2933
starttime=datetime.utcnow(),

0 commit comments

Comments
 (0)