Parquet output: drop dead manager index-sink, harden stop() order

Remove the unused manager-level m_indexSink/setIndexSink (per-basket index
sinks are unaffected) and stop all writers before destroying any in stop().

Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>

Author: arhamchopra

cpp/csp/adapters/parquet/ParquetOutputAdapterManager.cpp

@@ -27,22 +27,20 @@ void ParquetOutputAdapterManager::start( DateTime starttime, DateTime endtime )
     m_parquetWriter -> start();
     for( auto &&writer:m_dictBasketWriters )
     {
-        // Only overwrite per-basket index sink if a shared one was explicitly set
-        if( m_indexSink.onBatch )
-            writer -> setIndexSink( m_indexSink );
         writer -> start();
     }
 }
 
 void ParquetOutputAdapterManager::stop()
 {
+    // Stop all writers (flush + close their files) before destroying any of them, so a basket
+    // writer can never observe a destroyed sibling during teardown.
     m_parquetWriter -> stop();
-    m_parquetWriter = nullptr;
-
     for( auto &&writer:m_dictBasketWriters )
     {
         writer -> stop();
     }
+    m_parquetWriter = nullptr;
     m_dictBasketWriters.clear();
 }
 

cpp/csp/adapters/parquet/ParquetOutputAdapterManager.h

@@ -53,7 +53,6 @@ class ParquetOutputAdapterManager final : public csp::AdapterManager
     void scheduleEndCycle();
 
     void setSink( RecordBatchSink sink );
-    void setIndexSink( RecordBatchSink sink ) { m_indexSink = std::move( sink ); }
     void setSinkFactory( SinkFactory factory ) { m_sinkFactory = std::move( factory ); }
 
 private:
@@ -67,7 +66,6 @@ class ParquetOutputAdapterManager final : public csp::AdapterManager
     std::unordered_map<std::string, int>                        m_dictBasketWriterIndexByName;
     std::vector<std::unique_ptr<ParquetDictBasketOutputWriter>> m_dictBasketWriters;
     ParquetOutputFilenameAdapter                                *m_outputFilenameAdapter;
-    RecordBatchSink                                             m_indexSink;
     SinkFactory                                                 m_sinkFactory;
 };