Address suggestions from copilot.

Author: larshg

common/include/pcl/console/print.h

@@ -287,7 +287,6 @@ namespace pcl
       va_list ap;
       while (true) {
         formatted.reset(new char[n]); /* Wrap the plain char array into the unique_ptr */
-        std::strcpy(&formatted[0], fmt_str.c_str());
         va_start(ap, fmt_str);
         final_n = vsnprintf(&formatted[0], n, fmt_str.c_str(), ap);
         va_end(ap);

sample_consensus/include/pcl/sample_consensus/sac_model.h

@@ -174,7 +174,7 @@ namespace pcl
 
         // Get a second point which is different than the first
         samples.resize (getSampleSize ());
-        for (unsigned int iter = 0; iter < getMaxSampleSize(); ++iter)
+        for (unsigned int iter = 0; iter < getMaxSampleChecks(); ++iter)
         {
           // Choose the random indices
           if (samples_radius_ < std::numeric_limits<double>::epsilon ())
@@ -192,7 +192,7 @@ namespace pcl
         PCL_DEBUG("[pcl::SampleConsensusModel::getSamples] WARNING: Could not select "
                   "%d sample points in %d iterations!\n",
                   getSampleSize(),
-                  getMaxSampleSize());
+                  getMaxSampleChecks());
         samples.clear ();
       }
 
@@ -351,7 +351,7 @@ namespace pcl
       }
 
       static unsigned int
-      getMaxSampleSize()
+      getMaxSampleChecks()
       {
         /** The maximum number of samples to try until we get a good one */
         static const unsigned int max_sample_checks_ = 1000;
@@ -556,7 +556,7 @@ namespace pcl
       IndicesPtr indices_;
 
       /** The maximum number of samples to try until we get a good one */
-      PCL_DEPRECATED(1, 18, "Use getMaxSampleSize() instead.")
+      PCL_DEPRECATED(1, 18, "Use getMaxSampleChecks() instead.")
       static const unsigned int max_sample_checks_ = 1000;
 
       /** \brief The minimum and maximum radius limits for the model.

test/common/test_console.cpp

@@ -6,15 +6,15 @@
 TEST(PCL, printStreamsMacros) {
   pcl::console::setVerbosityLevel(pcl::console::L_VERBOSE);
 
-  PCL_ALWAYS_STREAM("Always_stream\n");
+  PCL_ALWAYS_STREAM("Always_stream\n")
   PCL_ERROR_STREAM("Error_stream\n")
-  PCL_WARN_STREAM("Warn_stream\n");
+  PCL_WARN_STREAM("Warn_stream\n")
   PCL_INFO_STREAM("Info_stream: this is a point: " << pcl::PointXYZ(1.0, 2.0, 3.0)
-                                                   << "\n");
-  PCL_DEBUG_STREAM("Debug_stream\n");
+                                                   << "\n")
+  PCL_DEBUG_STREAM("Debug_stream\n")
   PCL_VERBOSE_STREAM("Verbose_stream: an Eigen vector: "
                      << "\n"
-                     << Eigen::Vector3f(1.0, 2.0, 3.0) << "\n");
+                     << Eigen::Vector3f(1.0, 2.0, 3.0) << "\n")
 }
 
 TEST(PCL, printMacros)