Address Copilot code review issues

Author: gnawme

examples/surface/example_nurbs_viewer_surface.cpp

@@ -48,7 +48,13 @@ main (int argc, char *argv[])
     return -1;
   }
 
-  const ON_NurbsSurface& on_surf = *dynamic_cast<const ON_NurbsSurface*>(on_object);
+  const ON_NurbsSurface* on_surf_ptr = dynamic_cast<const ON_NurbsSurface*>(on_object);
+  if (!on_surf_ptr)
+  {
+    std::cerr << "object[0] is not a NURBS surface." << std::endl;
+    return -1;
+  }
+  const ON_NurbsSurface& on_surf = *on_surf_ptr;
 
   pcl::PolygonMesh mesh;
   std::string mesh_id = "mesh_nurbs";
@@ -68,7 +74,13 @@ main (int argc, char *argv[])
       return -1;
     }
 
-    const ON_NurbsCurve& on_curv = *dynamic_cast<const ON_NurbsCurve*>(on_object);
+    const ON_NurbsCurve* on_curv_ptr = dynamic_cast<const ON_NurbsCurve*>(on_object);
+    if (!on_curv_ptr)
+    {
+      std::cerr << "object[1] is not a NURBS curve." << std::endl;
+      return -1;
+    }
+    const ON_NurbsCurve& on_curv = *on_curv_ptr;
 
     pcl::on_nurbs::Triangulation::convertTrimmedSurface2PolygonMesh (on_surf, on_curv, mesh,
                                                                      mesh_resolution);

examples/surface/test_nurbs_fitting_surface.cpp

@@ -20,7 +20,7 @@ CreateCylinderPoints (pcl::PointCloud<Point>::Ptr cloud, pcl::on_nurbs::vector_v
     p.y = static_cast<float>(r * sin (da));
     p.z = static_cast<float>(dh);
 
-    data.emplace_back(p.x, p.y, p.z);
+    data.emplace_back (p.x, p.y, p.z);
     cloud->push_back (p);
   }
 }

surface/src/on_nurbs/fitting_curve_2d_sdm.cpp

@@ -211,7 +211,7 @@ FittingCurve2dSDM::addCageRegularisation (double weight, unsigned &row)
 void
 FittingCurve2dSDM::assembleInterior (double wInt, double rScale, unsigned &row)
 {
-  unsigned nInt = static_cast<int>(m_data->interior.size ());
+  auto nInt = static_cast<unsigned>(m_data->interior.size ());
   m_data->interior_line_start.clear ();
   m_data->interior_line_end.clear ();
   m_data->interior_error.clear ();

surface/src/on_nurbs/fitting_surface_pdm.cpp

@@ -479,7 +479,7 @@ FittingSurface::initNurbsPCABoundingBox (int order, NurbsDataSurface *m_data, Ei
   for (unsigned i = 0; i < s; i++)
   {
     Eigen::Vector3d p (eigenvectors_inv * (m_data->interior[i] - mean));
-    m_data->interior_param.emplace_back(p (0), p (1));
+    m_data->interior_param.emplace_back (p (0), p (1));
 
     if (p (0) > v_max (0))
       v_max (0) = p (0);
@@ -1168,15 +1168,15 @@ FittingSurface::inverseMappingBoundary (const ON_NurbsSurface &nurbs, const Vect
   // NORTH - SOUTH
   for (std::size_t i = 0; i < (elementsV.size () - 1); i++)
   {
-    ini_points.emplace_back(WEST, elementsV[i] + 0.5 * (elementsV[i + 1] - elementsV[i]));
-    ini_points.emplace_back(EAST, elementsV[i] + 0.5 * (elementsV[i + 1] - elementsV[i]));
+    ini_points.emplace_back (WEST, elementsV[i] + 0.5 * (elementsV[i + 1] - elementsV[i]));
+    ini_points.emplace_back (EAST, elementsV[i] + 0.5 * (elementsV[i + 1] - elementsV[i]));
   }
 
   // WEST - EAST
   for (std::size_t i = 0; i < (elementsU.size () - 1); i++)
   {
-    ini_points.emplace_back(NORTH, elementsU[i] + 0.5 * (elementsU[i + 1] - elementsU[i]));
-    ini_points.emplace_back(SOUTH, elementsU[i] + 0.5 * (elementsU[i + 1] - elementsU[i]));
+    ini_points.emplace_back (NORTH, elementsU[i] + 0.5 * (elementsU[i + 1] - elementsU[i]));
+    ini_points.emplace_back (SOUTH, elementsU[i] + 0.5 * (elementsU[i + 1] - elementsU[i]));
   }
 
   for (std::size_t i = 0; i < ini_points.size (); i++)

surface/src/on_nurbs/sequential_fitter.cpp

@@ -615,7 +615,7 @@ SequentialFitter::PCL2ON (pcl::PointCloud<pcl::PointXYZRGB>::Ptr &pcl_cloud, con
 
     if (!std::isnan (pt.x) && !std::isnan (pt.y) && !std::isnan (pt.z))
     {
-      on_cloud.emplace_back(pt.x, pt.y, pt.z);
+      on_cloud.emplace_back (pt.x, pt.y, pt.z);
       numPoints++;
     }
 

surface/src/on_nurbs/triangulation.cpp

@@ -375,8 +375,8 @@ Triangulation::convertTrimmedSurface2PolygonMesh (const ON_NurbsSurface &nurbs,
     params[i] = param;
     pt_is_in[i] = (z (2) >= 0.0);
 
-    end.emplace_back(pc (0), pc (1), 0.0);
-    start.emplace_back(vp (0), vp (1), 0.0);
+    end.emplace_back (pc (0), pc (1), 0.0);
+    start.emplace_back (vp (0), vp (1), 0.0);
   }
 
   for (const auto &poly : polygons)