fix: struct.slt, update.slt and lateral join

Author: PokIsemaine

datafusion/sql/src/relation/join.rs

@@ -186,6 +186,7 @@ pub(crate) fn is_lateral_join(join: &Join) -> Result<bool> {
     let is_lateral_syntax = is_lateral(&join.relation);
     let is_apply_syntax = match join.join_operator {
         JoinOperator::FullOuter(..)
+        | JoinOperator::Right(..)
         | JoinOperator::RightOuter(..)
         | JoinOperator::RightAnti(..)
         | JoinOperator::RightSemi(..)

datafusion/sql/src/statement.rs

@@ -942,18 +942,24 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
                 returning,
                 or,
             } => {
-                let from =
+                let froms =
                     from.map(|update_table_from_kind| match update_table_from_kind {
-                        UpdateTableFromKind::BeforeSet(from) => from[0].clone(),
-                        UpdateTableFromKind::AfterSet(from) => from[0].clone(),
+                        UpdateTableFromKind::BeforeSet(froms) => froms.clone(),
+                        UpdateTableFromKind::AfterSet(froms) => froms.clone(),
                     });
+                // TODO: support multiple tables in UPDATE SET FROM
+                if froms.clone().is_some_and(|f| f.len() > 1) {
+                    println!("---------------------------------------------");
+                    plan_err!("Multiple tables in UPDATE SET FROM not yet supported")?;
+                }
+                let update_from = froms.map(|f| f.first().unwrap().clone());
                 if returning.is_some() {
                     plan_err!("Update-returning clause not yet supported")?;
                 }
                 if or.is_some() {
                     plan_err!("ON conflict not supported")?;
                 }
-                self.update_to_plan(table, assignments, from, selection)
+                self.update_to_plan(table, assignments, update_from, selection)
             }
 
             Statement::Delete(Delete {

datafusion/sqllogictest/test_files/struct.slt

@@ -286,7 +286,7 @@ drop table struct_values;
 statement ok
 CREATE OR REPLACE VIEW complex_view AS 
 SELECT {
-    'user': {
+    'user_information': {
         'info': {
             'personal': {
                 'name': 'John Doe',
@@ -347,22 +347,22 @@ SELECT {
 } AS complex_data;
 
 query T
-SELECT complex_data.user.info.personal.name FROM complex_view;
+SELECT complex_data.user_information.info.personal.name FROM complex_view;
 ----
 John Doe
 
 query I
-SELECT complex_data.user.info.personal.age FROM complex_view;
+SELECT complex_data.user_information.info.personal.age FROM complex_view;
 ----
 30
 
 query T
-SELECT complex_data.user.info.address.city FROM complex_view;
+SELECT complex_data.user_information.info.address.city FROM complex_view;
 ----
 Anytown
 
 query T
-SELECT complex_data.user.preferences.languages[2] FROM complex_view;
+SELECT complex_data.user_information.preferences.languages[2] FROM complex_view;
 ----
 es
 

datafusion/sqllogictest/test_files/update.slt

@@ -78,8 +78,8 @@ physical_plan_error This feature is not implemented: Unsupported logical plan: D
 statement ok
 create table t3(a int, b varchar, c double, d int);
 
-# set from multiple tables, sqlparser only supports from one table
-query error DataFusion error: SQL error: ParserError\("Expected end of statement, found: ,"\)
+# set from multiple tables, DataFusion only supports from one table
+query error DataFusion error: Error during planning: Multiple tables in UPDATE SET FROM not yet supported
 explain update t1 set b = t2.b, c = t3.a, d = 1 from t2, t3 where t1.a = t2.a and t1.a = t3.a;
 
 # test table alias