✨ Use PLMC amount in Evaluation

[lrazovic]

This pull request refactors the evaluation logic in the funding pallet, transitioning from using USD-based calculations to PLMC-based calculations in the evaluation round. The changes streamline the handling of evaluation bonds, improve consistency, and update related tests and utilities to align with the new approach.

Core Refactoring: Transition to PLMC-based Calculations

• Replaced usd_amount with plmc_bond in the do_evaluate function and related methods, ensuring all evaluation logic now operates using PLMC values. (pallets/funding/src/functions/2_evaluation.rs: [1] [2] [3]
• Updated the EvaluationParams struct to use plmc_amount instead of usd_amount, reflecting the shift to PLMC-based evaluations. (pallets/funding/src/instantiator/types.rs: pallets/funding/src/instantiator/types.rsL100-R126)

Utility and Helper Updates

• Modified utility functions like generate_evaluations_from_total_usd to generate_evaluations_from_total_plmc, ensuring compatibility with PLMC-based logic. (pallets/funding/src/instantiator/calculations.rs: pallets/funding/src/instantiator/calculations.rsL356-R393)
• Simplified the evaluation bond calculation logic by removing intermediate USD-to-PLMC conversion steps. (pallets/funding/src/instantiator/calculations.rs: pallets/funding/src/instantiator/calculations.rsL33-R33)

Tests and Mock Adjustments

• Refactored tests to use PLMC values directly instead of USD, ensuring test cases align with the new evaluation logic. (pallets/funding/src/tests/2_evaluation.rs: [1] [2]
• Removed unused constants like HOURS from the mock configuration to clean up the codebase. (pallets/funding/src/mock.rs: pallets/funding/src/mock.rsL282-L283)

Miscellaneous Improvements

• Introduced BlockProviderFor<T> as an alias for the block number provider, improving readability and consistency. (pallets/funding/src/lib.rs: pallets/funding/src/lib.rsR139)
• Removed unused imports, such as iter::zip, to streamline the code. (pallets/funding/src/instantiator/mod.rs: pallets/funding/src/instantiator/mod.rsL21-R21)

[lrazovic]

• [DNM] Instantiator refactor and cleanup #494
• Bid with receiving account: xcm support #490
• Possible bug fixes #491
• feat: specify amount to invest #489
• 🎨 Refactor the Price Buckets #488
• ⚡️ Remove AccountId and id from stored value #487
• ✨ Use PLMC amount in Evaluation #484 👈 (View in Graphite)
• ⚡️ Remove useless clone #486
• 🎨 Simplify the acceptable_assets #485
• 🎨 Macros update and documentation #483
• ⬆️ Bump to Polkadot SDK stable 2503-5 #482 : 1 other dependent PR (#493 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dastansam]

looks ok, but no integration tests (?)