🎨 Simplify the acceptable_assets

[lrazovic]

This pull request introduces several changes aimed at improving code quality, simplifying function calls, and enhancing maintainability across multiple files. The key updates include replacing direct object references with references (&), removing unused constants, and simplifying type constraints in struct definitions. Additionally, some error messages were clarified for better understanding.

Code Quality Improvements:

• Replaced direct object usage with references in function calls to improve efficiency and align with Rust's borrowing principles. This change is applied across multiple files, including pallets/funding/src/functions/misc.rs, integration-tests/src/tests/otm_edge_cases.rs, and others. [1] [2] [3]

• Removed unused constants such as USD_DECIMALS from imports in several files, including pallets/funding/src/functions/mod.rs and pallets/funding/src/instantiator/calculations.rs. [1] [2]

Simplifications in Struct Definitions:

• Simplified type constraints for generic parameters in structs like ProjectMetadata and BiddingTicketSizes by removing the FixedPointNumber constraint where it was unnecessary. This improves flexibility and reduces complexity. [1] [2]

Error Message Enhancements:

• Clarified error messages for user-facing errors, such as replacing "The amount is too low" with "The amount specified in the call is too low" for better context.

Test Updates:

• Updated test cases to reflect the use of references in function calls, ensuring consistency with the main codebase. Changes were made in files such as pallets/funding/src/tests/2_evaluation.rs and pallets/funding/src/tests/misc.rs. [1] [2]

Mock and Runtime Adjustments:

• Modified mock implementations and runtime APIs to align with the new reference-based function signatures, such as in pallets/funding/src/mock.rs.

[lrazovic]

• [DNM] Instantiator refactor and cleanup #494
• Bid with receiving account: xcm support #490
• Possible bug fixes #491
• feat: specify amount to invest #489
• 🎨 Refactor the Price Buckets #488
• ⚡️ Remove AccountId and id from stored value #487
• ✨ Use PLMC amount in Evaluation #484
• ⚡️ Remove useless clone #486
• 🎨 Simplify the acceptable_assets #485 👈 (View in Graphite)
• 🎨 Macros update and documentation #483
• ⬆️ Bump to Polkadot SDK stable 2503-5 #482 : 1 other dependent PR (#493 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors price conversion and asset management by switching to reference-based API calls, removing unused constants, clarifying error messages, and simplifying type constraints.

• Use &AssetId in price provider methods and drop the USD_DECIMALS parameter.
• Remove unnecessary FixedPointNumber bounds and unused imports.
• Add decimals() and all_ids_and_plmc() to AcceptedFundingAsset, and improve error messaging.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
runtimes/polimec/src/lib.rs	Replaced PLMCToAssetBalance with HereToForeignAsset and updated XCM payment API
polimec-common/common/src/lib.rs	Updated ProvideAssetPrice trait docs/signature and added convert_back_to_normal_price
polimec-common/common/src/assets.rs	Added decimals() and all_ids_and_plmc() to AcceptedFundingAsset
pallets/proxy-bonding/src/mock.rs	Changed get_price to accept &Location
pallets/proxy-bonding/src/functions.rs	Updated calculate_fee to use the new get_decimals_aware_price signature
pallets/funding/src/types.rs	Removed FixedPointNumber constraint from struct generics
pallets/funding/src/tests/runtime_api.rs	Adjusted tests to pass references to get_price
pallets/funding/src/tests/misc.rs	Aligned test calls with the reference-based price API
pallets/funding/src/tests/3_auction.rs	Refactored test to use &Location and the updated price API
pallets/funding/src/tests/2_evaluation.rs	Updated test price calls to use references
pallets/funding/src/mock.rs	Changed mock get_price to accept &Location
pallets/funding/src/lib.rs	Clarified TooLow/TooHigh error messages
pallets/funding/src/instantiator/calculations.rs	Simplified price lookup by removing USD_DECIMALS parameter
pallets/funding/src/functions/runtime_api.rs	Removed USD_DECIMALS import and updated get_decimals_aware_price usage
pallets/funding/src/functions/mod.rs	Cleaned up imports and removed unused constants
pallets/funding/src/functions/misc.rs	Switched to reference-based price calls and dropped USD_DECIMALS
pallets/funding/src/functions/2_evaluation.rs	Simplified repeated price retrieval calls
integration-tests/src/tests/transaction_payment.rs	Updated asset location usage and price API in integration tests
integration-tests/src/tests/otm_edge_cases.rs	Refined reference usage and removed USD_DECIMALS in edge-case tests
Cargo.toml	Added redundant_clone lint configuration

Comments suppressed due to low confidence (2)

pallets/funding/src/functions/misc.rs:53

• [nitpick] Consider accepting asset as a reference (&AcceptedFundingAsset) rather than by value to avoid unnecessary copying and align with other APIs that take references.

pub fn calculate_funding_asset_amount(

polimec-common/common/src/assets.rs:60

• The order of asset IDs in all_ids_and_plmc differs from the original all_ids vector; if ordering matters in downstream code, consider preserving the original sequence or documenting the change.

pub fn all_ids_and_plmc() -> [Location; AcceptedFundingAsset::VARIANT_COUNT + 1] {

[Copilot]

[nitpick] The logic to fetch the PLMC price is repeated in multiple places; extracting this into a helper method (e.g., get_plmc_price()) would reduce duplication and improve clarity.

[dastansam]

wouldn't this round down a lot of decimals compared to using Perquintill? is it negligible?

[lrazovic]

Merge activity

• Aug 4, 7:49 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Aug 4, 7:54 AM UTC: Graphite rebased this pull request as part of a merge.
• Aug 4, 7:55 AM UTC: @lrazovic merged this pull request with Graphite.