⚡️ Remove AccountId and id from stored value

[lrazovic]

This pull request refactors the EvaluationInfo structure and associated logic across the pallets/funding module to simplify its design by removing the id and project_id fields from the structure. The changes also update related functions, storage, and tests to accommodate this refactoring. Additionally, some minor cleanups were performed.

Refactoring of EvaluationInfo and Related Logic:

• EvaluationInfo Structure Simplification:

  • Removed the id and project_id fields from the EvaluationInfo struct definition in pallets/funding/src/types.rs. The struct now relies on external identifiers for these fields.
  • Updated the associated type alias EvaluationInfoOf<T> in pallets/funding/src/lib.rs to reflect the new structure.

• Function Updates:

  • Updated do_settle_evaluation in pallets/funding/src/functions/5_settlement.rs to accept evaluation_id as a separate parameter instead of using it from the EvaluationInfo struct. [1] [2]
  • Adjusted try_plmc_participation_lock to iterate over evaluation IDs and include them in updates to the Evaluations storage.
  • Modified settle_project and get_evaluations in pallets/funding/src/instantiator/chain_interactions.rs to handle the new structure. [1] [2]

• Storage Updates:

  • Updated all references to Evaluations storage to use external evaluation_id where necessary, ensuring compatibility with the new structure. [1] [2]

Test Adjustments:

• Test Updates for EvaluationInfo Changes:
  • Updated tests in pallets/funding/src/tests/5_settlement.rs to reflect the new EvaluationInfo structure by using tuples (AccountId, EvaluationId, EvaluationInfo) instead of the old structure. [1] [2] [3]
  • Adjusted assertions and test logic to handle the separation of evaluation_id from EvaluationInfo. [1] [2]

Minor Cleanups:

• Removed unused id and project_id fields from EvaluationInfo in pallets/funding/src/functions/2_evaluation.rs and associated logic. [1] [2]
• Removed unnecessary #[allow(unreachable_patterns)] directive in pallets/funding/src/lib.rs.
• Added BlockNumberFor import to pallets/funding/src/lib.rs for consistency.

These changes streamline the EvaluationInfo structure and improve the maintainability of the codebase by reducing redundancy and simplifying related logic.

[lrazovic]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [DNM] Instantiator refactor and cleanup #494
• Bid with receiving account: xcm support #490
• Possible bug fixes #491
• feat: specify amount to invest #489
• 🎨 Refactor the Price Buckets #488
• ⚡️ Remove AccountId and id from stored value #487 👈 (View in Graphite)
• ✨ Use PLMC amount in Evaluation #484
• ⚡️ Remove useless clone #486
• 🎨 Simplify the acceptable_assets #485
• 🎨 Macros update and documentation #483
• ⬆️ Bump to Polkadot SDK stable 2503-5 #482 : 1 other dependent PR (#493 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR removes the stored fields “id” and “project_id” from the EvaluationInfo struct and updates all related calls and tests accordingly. Key changes include:

• Updating the EvaluationInfo struct in pallets/funding/src/types.rs.
• Adjusting tests in pallets/funding/src/tests/5_settlement.rs and pallets/funding/src/tests/2_evaluation.rs to account for the changed struct.
• Modifying helper functions and instantiators to work with a tuple structure returned by get_evaluations.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pallets/funding/src/types.rs	Removed the id and project_id fields from EvaluationInfo.
pallets/funding/src/tests/5_settlement.rs	Updated tuple deconstruction and other references in tests.
pallets/funding/src/tests/2_evaluation.rs	Adjusted expected EvaluationInfo to match struct changes.
pallets/funding/src/lib.rs	Updated type alias and calls for EvaluationInfo.
pallets/funding/src/instantiator/chain_interactions.rs	Modified get_evaluations to return tuples instead of raw values.
pallets/funding/src/functions/misc.rs	Updated evaluation locking logic with tuple access.
pallets/funding/src/functions/5_settlement.rs	Changed do_settle_evaluation signature to include evaluation_id.
pallets/funding/src/functions/2_evaluation.rs	Updated EvaluationInfo instantiation to remove obsolete fields.

[Copilot]

[nitpick] Consider destructuring the tuple returned by get_evaluations instead of accessing its elements directly via indices (e.g. first_evaluation.0 and first_evaluation.1) to improve code readability.

[Copilot]

[nitpick] The revised tuple structure returned by get_evaluations requires careful handling; ensure that all call sites properly destructure and use the tuple values.