🎨 Refactor the Price Buckets

[lrazovic]

This pull request simplifies the create_bucket_from_metadata function and its usage across the pallets/funding module by removing unnecessary error handling and making the Bucket::new constructor more concise. Additionally, it includes minor cleanup in related files.

Simplification of create_bucket_from_metadata:

• pallets/funding/src/functions/misc.rs: Removed the Result return type and unnecessary error handling in the create_bucket_from_metadata function. The function now directly returns a BucketOf<T> object.
• pallets/funding/src/types.rs: Simplified the Bucket::new constructor by removing redundant parameters and calculations, and moved the 10% calculation logic into the constructor.

Updates to function calls:

• Updated all calls to create_bucket_from_metadata across the module to remove .unwrap() since the function no longer returns a Result. This change affects:
  • pallets/funding/src/benchmarking.rs
  • pallets/funding/src/functions/1_application.rs
  • pallets/funding/src/instantiator/calculations.rs [1] [2] [3]
  • pallets/funding/src/tests/1_application.rs
  • pallets/funding/src/tests/3_auction.rs
  • pallets/funding/src/tests/misc.rs [1] [2]

Code cleanup:

• pallets/funding/src/types.rs: Added Percent to the imports to support the updated Bucket::new implementation.
• polimec-common/common/src/lib.rs: Removed an unused parameter (usd_decimals) from the documentation of the ProvideAssetPrice trait.

[lrazovic]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [DNM] Instantiator refactor and cleanup #494
• Bid with receiving account: xcm support #490
• Possible bug fixes #491
• feat: specify amount to invest #489
• 🎨 Refactor the Price Buckets #488 👈 (View in Graphite)
• ⚡️ Remove AccountId and id from stored value #487
• ✨ Use PLMC amount in Evaluation #484
• ⚡️ Remove useless clone #486
• 🎨 Simplify the acceptable_assets #485
• 🎨 Macros update and documentation #483
• ⬆️ Bump to Polkadot SDK stable 2503-5 #482 : 1 other dependent PR (#493 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors the bucket creation process and updates related documentation and tests. The changes remove unnecessary error handling by eliminating unwraps and adjust the bucket initialization to compute parameters internally.

• Updated documentation for ProvideAssetPrice to remove the obsolete usd_decimals parameter.
• Refactored bucket creation across modules to return BucketOf directly.
• Modified tests and instantiator functions to align with the new bucket API.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
polimec-common/common/src/lib.rs	Removed outdated usd_decimals doc comment to match updated API.
pallets/funding/src/types.rs	Updated Bucket::new usage to compute delta_amount and delta_price.
pallets/funding/src/tests/*.rs	Removed unwrap calls to adapt to the new bucket creation API.
pallets/funding/src/instantiator/calculations.rs	Adjusted bucket creation to remove error handling.
pallets/funding/src/functions/misc.rs	Changed create_bucket_from_metadata to return BucketOf directly.

Comments suppressed due to low confidence (2)

polimec-common/common/src/lib.rs:387

• The documentation line for 'usd_decimals' has been removed to align with the updated function signature. Ensure all related documentation and code examples are updated accordingly.

/// * `usd_decimals`: The number of decimal places for the USD (or pricing) currency.

pallets/funding/src/functions/misc.rs:26

• [nitpick] The function 'create_bucket_from_metadata' now returns BucketOf directly, removing error handling. Confirm that this change is safe because the fixed point conversion used internally can never fail, otherwise consider reintroducing error management.

pub fn create_bucket_from_metadata(metadata: &ProjectMetadataOf<T>) -> BucketOf<T> {

[Copilot]

Pull Request Overview

This PR refactors the price bucket logic in the pallets/funding module by simplifying the bucket creation functions and cleaning up redundant error handling. Key changes include:

• Eliminating the Result return type from create_bucket_from_metadata and removing unnecessary unwrap calls.
• Simplifying the Bucket::new constructor to internally compute a 10% delta_price and delta_amount.
• Minor documentation cleanup in polimec-common.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
polimec-common/common/src/lib.rs	Removed an unused parameter from trait documentation.
pallets/funding/src/types.rs	Updated Bucket::new constructor to encapsulate 10% calculation logic.
pallets/funding/src/functions/misc.rs	Updated create_bucket_from_metadata to return BucketOf directly.
Various tests files in pallets/funding/src/tests/ and instantiator	Removed unwrap calls in bucket creation to match the new API.
pallets/funding/src/functions/1_application.rs and benchmarking.rs	Updated bucket creation call sites by removing .unwrap().

[Copilot]

Consider adding a comment explaining why the conversion using checked_from_rational with an expect call is guaranteed to succeed, to clarify that 10% is always representable.