Skip to content

Conversation

@lrazovic
Copy link
Member

@lrazovic lrazovic commented May 23, 2025

This PR updates dependencies in Cargo.toml and makes runtime changes in runtimes/polimec/src/lib.rs. The updates primarily include version bumps for various Polkadot-SDK dependencies.

Dependency Updates in Cargo.toml:

  • Updated versions for Substrate-related crates, including xcm-emulator, frame-benchmarking, frame-executive, sp-npos-elections, pallet-scheduler, pallet-xcm, and sp-api-proc-macro.

  • Updated runtime versions for westend-runtime, asset-hub-westend-runtime, and emulated-integration-tests-common.

Runtime Changes in runtimes/polimec/src/lib.rs:

  • Simplified the migrations module by removing already executed migration, such as RemovePallet, and other legacy migration logic.

  • Incremented the spec_version from 1_001_000 to 1_001_001 and the transaction_version from 8 to 9.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lrazovic lrazovic changed the title fix: bump frame-executive and sp-api-proc-macro 🚑️ Bump frame-executive and sp-api-proc-macro May 23, 2025
@lrazovic lrazovic marked this pull request as ready for review May 23, 2025 14:17
@graphite-app
Copy link

graphite-app bot commented May 23, 2025

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/23/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@lrazovic lrazovic requested review from Copilot and dastansam May 23, 2025 14:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Polkadot-SDK dependencies and streamlines the runtime by removing legacy migrations and bumping the runtime version.

  • Bumps several crate versions in Cargo.toml, including Substrate and XCM-related dependencies.
  • Removes outdated migration steps in runtimes/polimec/src/lib.rs and increments spec_version and transaction_version.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Cargo.toml Updated version numbers for various crates (e.g., xcm-emulator, frame-executive, pallet-scheduler, etc.).
runtimes/polimec/src/lib.rs Removed legacy migrations, simplified migrations module, bumped runtime version fields.
Comments suppressed due to low confidence (3)

runtimes/polimec/src/lib.rs:181

  • [nitpick] Since the migrations module now only contains a single type alias, consider adding module-level docs or removing the #[allow(missing_docs)] attribute to improve clarity.
#[allow(missing_docs)]

runtimes/polimec/src/lib.rs:184

  • [nitpick] The comment 'Add new ones here' may be misleading now that legacy migrations are gone. Consider updating or removing it to accurately reflect current migration responsibilities.
/// Unreleased migrations. Add new ones here:

Copy link
Member Author

lrazovic commented May 23, 2025

Merge activity

  • May 23, 2:35 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 23, 2:35 PM UTC: @lrazovic merged this pull request with Graphite.

@lrazovic lrazovic merged commit cef677b into main May 23, 2025
1 check passed
@lrazovic lrazovic deleted the 05-23-fix_bump_frame-executive_and_sp-api-proc-macro branch May 23, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants