migrate all /obj/item from /New() to /Initialize() (ParadiseSS13#31232)

* migrate all /obj/item from /New() to /Initialize()

* move GLOB.chemical_reagents_list creation to /world/New()

* review

* oops

* autodoc a smart var

Author: Toastical

code/__HELPERS/global_lists.dm

@@ -158,6 +158,8 @@
 
 	GLOB.emote_list = init_emote_list()
 
+	GLOB.chemical_reagents_list = init_reagent_list()
+
 	// Set up PCWJ recipes
 	initialize_cooking_recipes()
 
@@ -240,3 +242,10 @@
 				.[E.key_third_person] = list(E)
 			else
 				.[E.key_third_person] |= E
+
+/// Initialises all of /datum/reagent into a list indexed by reagent id.
+/proc/init_reagent_list()
+	. = list()
+	for(var/path in subtypesof(/datum/reagent))
+		var/datum/reagent/R = new path()
+		.[R.id] = R

code/game/gamemodes/nuclear/nuclearbomb.dm

@@ -730,8 +730,8 @@ GLOBAL_VAR(bomb_set)
 	. = ..()
 	. += SPAN_WARNING("This disk has had its safeties removed. It will not teleport back to the station if taken too far away.")
 
-/obj/item/disk/nuclear/New()
-	..()
+/obj/item/disk/nuclear/Initialize(mapload)
+	. = ..()
 	if(restricted_to_station)
 		START_PROCESSING(SSobj, src)
 	if(!training)

code/game/gamemodes/nuclear/pinpointer.dm

@@ -39,8 +39,8 @@
 	var/icon_medium = "pinonmedium"
 	var/icon_far = "pinonfar"
 
-/obj/item/pinpointer/New()
-	..()
+/obj/item/pinpointer/Initialize(mapload)
+	. = ..()
 	GLOB.pinpointer_list += src
 
 /obj/item/pinpointer/Destroy()

code/game/gamemodes/wizard/artefact.dm

@@ -273,8 +273,8 @@ GLOBAL_LIST_EMPTY(multiverse)
 	var/duplicate_self = 0 //Do we want the species randomized along with equipment should the user be duplicated in their entirety?
 	var/sword_type = /obj/item/multisword //type of sword to equip.
 
-/obj/item/multisword/New()
-	..()
+/obj/item/multisword/Initialize(mapload)
+	. = ..()
 	GLOB.multiverse |= src
 
 

code/game/gamemodes/wizard/godhand.dm

@@ -16,9 +16,9 @@
 	var/on_use_sound = null
 	var/datum/spell/touch/attached_spell
 
-/obj/item/melee/touch_attack/New(spell)
+/obj/item/melee/touch_attack/Initialize(mapload, spell)
+	. = ..()
 	attached_spell = spell
-	..()
 
 /obj/item/melee/touch_attack/Destroy()
 	if(attached_spell)

code/game/gamemodes/wizard/spellbook.dm

@@ -722,7 +722,7 @@
 	var/list/item_categories = list("Artefacts", "Weapons and Armors", "Staves", "Summons")
 	var/list/loadout_categories = list("Standard", "Unique")
 
-/obj/item/spellbook/proc/initialize()
+/obj/item/spellbook/proc/create_spellbook()
 	var/entry_types = subtypesof(/datum/spellbook_entry) - /datum/spellbook_entry/item - /datum/spellbook_entry/summon - /datum/spellbook_entry/loadout
 	for(var/T in entry_types)
 		var/datum/spellbook_entry/E = new T
@@ -735,9 +735,9 @@
 	main_tab = main_categories[1]
 	tab = categories[1]
 
-/obj/item/spellbook/New()
-	..()
-	initialize()
+/obj/item/spellbook/Initialize(mapload)
+	. = ..()
+	create_spellbook()
 
 /obj/item/spellbook/attackby__legacy__attackchain(obj/item/O as obj, mob/user as mob, params)
 	if(istype(O, /obj/item/contract))
@@ -970,13 +970,10 @@
 	uses = 1
 	desc = "This template spellbook was never meant for the eyes of man..."
 
-/obj/item/spellbook/oneuse/New()
-	..()
+/obj/item/spellbook/oneuse/Initialize(mapload)
+	. = ..()
 	name += spellname
 
-/obj/item/spellbook/oneuse/initialize() //No need to init
-	return
-
 /obj/item/spellbook/oneuse/attack_self__legacy__attackchain(mob/user)
 	var/datum/spell/S = new spell
 	for(var/datum/spell/knownspell in user.mind.spell_list)
@@ -1155,7 +1152,7 @@
 /obj/item/spellbook/oneuse/random
 	icon_state = "random_book"
 
-/obj/item/spellbook/oneuse/random/initialize()
+/obj/item/spellbook/oneuse/random/create_spellbook()
 	. = ..()
 	var/static/list/banned_spells = typesof(/obj/item/spellbook/oneuse/mime, /obj/item/spellbook/oneuse/emp)
 	var/real_type = pick(subtypesof(/obj/item/spellbook/oneuse) - banned_spells)

code/game/machinery/computer/communications.dm

@@ -595,9 +595,9 @@
 	SSshuttle.autoEvac()
 	return ..()
 
-/obj/item/circuitboard/communications/New()
+/obj/item/circuitboard/communications/Initialize(mapload)
+	. = ..()
 	GLOB.shuttle_caller_list += src
-	..()
 
 /obj/item/circuitboard/communications/Destroy()
 	GLOB.shuttle_caller_list -= src

code/game/machinery/dye_generator.dm

@@ -78,8 +78,8 @@
 	w_class = WEIGHT_CLASS_TINY
 	var/dye_color = "#FFFFFF"
 
-/obj/item/hair_dye_bottle/New()
-	..()
+/obj/item/hair_dye_bottle/Initialize(mapload)
+	. = ..()
 	update_icon(UPDATE_OVERLAYS)
 
 /obj/item/hair_dye_bottle/update_overlays()

code/game/objects/items.dm

@@ -199,18 +199,6 @@ GLOBAL_DATUM_INIT(welding_sparks, /mutable_appearance, mutable_appearance('icons
 
 	scatter_distance = 5
 
-/obj/item/New()
-	..()
-
-	if(!hitsound)
-		if(damtype == "fire")
-			hitsound = 'sound/items/welder.ogg'
-		if(damtype == "brute")
-			hitsound = "swing_hit"
-	LAZYINITLIST(attack_verb)
-	if(!move_resist)
-		determine_move_resist()
-
 /obj/item/Initialize(mapload)
 	. = ..()
 	for(var/path in actions_types)
@@ -219,6 +207,14 @@ GLOBAL_DATUM_INIT(welding_sparks, /mutable_appearance, mutable_appearance('icons
 		in_storage = TRUE
 	if(sharp)
 		AddComponent(/datum/component/surgery_initiator)
+	if(!hitsound)
+		if(damtype == "fire")
+			hitsound = 'sound/items/welder.ogg'
+		if(damtype == "brute")
+			hitsound = "swing_hit"
+	LAZYINITLIST(attack_verb)
+	if(!move_resist)
+		determine_move_resist()
 
 /// This proc is used to add text for items with ABSTRACT flag after default examine text.
 /obj/item/proc/customised_abstract_text(mob/living/carbon/owner)

code/game/objects/items/RCL.dm

@@ -152,8 +152,8 @@
 	last = loaded.place_turf(get_turf(loc), user, turn(user.dir, 180))
 	is_empty(user) //If we've run out, display message
 
-/obj/item/rcl/pre_loaded/New() //Comes preloaded with cable, for testing stuff
-	..()
+/obj/item/rcl/pre_loaded/Initialize(mapload) // Comes preloaded with cable, for testing stuff
+	. = ..()
 	loaded = new()
 	loaded.max_amount = max_amount
 	loaded.amount = max_amount