Skip to content

Commit 95aebd1

Browse files
SergeStinckwichhemalvarambhiaJames Fosterserpi90
authored
Release PolyMath v1.0.2 (#165)
* [skip CI] * [skip CI] * [skip CI] typos * [skip CI] * Update SMark to 1.0.3 * Update README.md * [Issue 152] Remove Magic From 'initialize' Methods (#153) * [issue-152] Improved code formatting. * [issue-152] Removed some reflection magic so that the code is easier to understand. * [issue-152] Improved code formatting. * Cleanup to load in PharoGs (#150) * Do not use an inst variable name as an argument * Don't use 'p' and 'q' as method temps They are defined as instance variables in the class. If they are not supposed to modify the instance variable, then they should have different names. * Don't begin a block with a dot GemStone isn't happy with empty statements. * Cleanup of Array constructors While legal syntax, GemStone has trouble parsing these. * Don't use instance var name as method argument * Add spacing to clarify when number ends GemStone doesn't like '11do:' as a number since 'd' is a legal exponent. * Spacing to clarify separation of statements * Fix typo with extra space. * [issue-154] Corrected the behaviour of findKey to return 'AllTheRest' when selector has no corresponding initialize message. (#155) * [issue-154] Corrected the behaviour of findKey, making it more testable in the subclass to mitigate risk. * [issue-154] Promoted the local variables in the test to state variable to remove duplication. * [issue-154] Extracted duplicate code to a custom assertion. * [skip CI] * [skip CI] * Create FUNDING.yml * Update FUNDING.yml * Remove curly braces, replaced with Arrays in most cases, should close #159 (#162) * Update dependencies to load from github, should close #160 (#161) * [Issue 154] Refactor PMAccuracy testDataTree method (#163) * [issue-154] Moved the test method to its own test case class so that we can break up the long test method and understand the message better. * [issue-154] Moved some test code to an intention-revealing test method & identified a possible smell. * [issue-154] Moved a block of code to its own intention-revealing test method. * [issue-154] Moved some test code to its own intention-revealing method. * [issue-154] Added a smell comment to help the next developer. * [issue-154] Added more smells to the smell comment. * [issue-154] Moved the test code to an intention-revealing test method, extracted the expected result to a role-revealing local variable. * [issue-154] Extracted test code to its own intention-revealing test method, with a comment identifying a coincidence between expected outcome and a default I discovered in the initialize method. * [issue-154] Added calls to the super class methods as required. * [issue-154] Put the call to the super class method in the right place. * [issue-154] Improved the name of the local variable. We still don't know the role it plays in the test yet so gave it a structural name. * [issue-154] Improved the name of a local variable. * [issue-154] Moved the test code to its own better named test method. * Update .travis.yml * Update appveyor.yml * Fix some of the red tests for Pharo 8 (#164) * Update appveyor.yml * Move from Pharo 7.0 to Pharo 8.0 * Update README.md Co-authored-by: Hemal Varambhia <[email protected]> Co-authored-by: James Foster <[email protected]> Co-authored-by: Julian Maestri <[email protected]>
1 parent 8bcf998 commit 95aebd1

File tree

51 files changed

+495
-510
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+495
-510
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ os:
66
- osx
77

88
smalltalk:
9-
- Pharo-6.1
109
- Pharo32-7.0
1110
- Pharo64-7.0
11+
- Pharo32-8.0
12+
- Pharo64-8.0
1213

1314
matrix:
1415
fast_finish: true

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
This file is currently not complete but will be improve step by step.
44

55
# Contributing code
6-
Use last version of Pharo 7.0 in order to use Iceberg.
6+
Use last version of Pharo 8.0 in order to use Iceberg.
77
## Fork the Pharo repository
88

99
All changes you'll do will be versionned in your own fork of the [PolyMath repository](https://github.com/PolyMathOrg/PolyMath). Then, from your fork you'll be able to issue pull requests to PolyMath, where they will be reviewed, and luckily, integrated.
1010

1111
Go to PolyMath github's repository and click on the fork button on the top right. Yes, this means that you'll need a github account to contribute to PolyMath, yes.
1212

1313
## Load last dev version of PolyMath
14-
In a fresh Pharo 7.0 image, load last development version of Polymath :
14+
In a fresh Pharo 8.0 image, load last development version of Polymath :
1515

1616
```Smalltalk
1717
Metacello new

FUNDING.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
github: SergeStinckwich

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<p align="center">
33
Scientific Computing with Pharo
44
<br>
5-
<a href="docs/"><strong>Explore the docs »</strong></a>
5+
<a href="https://github.com/PolyMathOrg/PolyMath/wiki"><strong>Explore the docs »</strong></a>
66
<br>
77
<br>
88
<a href="https://github.com/PolyMathOrg/PolyMath/issues/new?labels=Type%3A+Defect">Report a defect</a>
@@ -19,11 +19,12 @@
1919

2020
<img width="1675" alt="Screenshot 2019-04-24 at 11 12 57" src="https://user-images.githubusercontent.com/327334/56652094-66eb7780-6682-11e9-9753-101be18df67c.png">
2121

22-
You can load PolyMath 1.0 into a fresh Pharo 7.0 image with:
22+
23+
You can load PolyMath 1.0.1 into a fresh Pharo 7.0 image with:
2324

2425
```Smalltalk
2526
Metacello new
26-
repository: 'github://PolyMathOrg/PolyMath:v1.0/src';
27+
repository: 'github://PolyMathOrg/PolyMath:v1.0.1/src';
2728
baseline: 'PolyMath';
2829
load
2930
```
@@ -37,7 +38,8 @@ Metacello new
3738
load
3839
```
3940

40-
We have **806** green tests ! At the moment, all the development happens in the master branch (we are using trunk-based development).
41+
42+
We have **815** green tests ! At the moment, all the development happens in the master branch (we are using trunk-based development).
4143

4244
PolyMath is a Pharo project, similar to existing scientific libraries like NumPy, SciPy for Python or SciRuby for Ruby. PolyMath already provides the following basic functionalities:
4345
- complex and quaternions extensions,

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ environment:
66
CYG_MIRROR: http://cygwin.mirror.constant.com
77
SCI_RUN: /cygdrive/c/smalltalkCI-master/run.sh
88
matrix:
9-
- SMALLTALK: Pharo-7.0
9+
- SMALLTALK: Pharo-8.0
1010

1111
platform:
1212
- x86

src/BaselineOfPolyMath/BaselineOfPolyMath.class.st

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -177,19 +177,13 @@ BaselineOfPolyMath >> projectClass [
177177
{ #category : #dependencies }
178178
BaselineOfPolyMath >> sMark: spec [
179179
spec
180-
project: 'SMark'
181-
with: [ spec
182-
className: #ConfigurationOfSMark;
183-
versionString: '1.0.3';
184-
repository: 'http://smalltalkhub.com/mc/StefanMarr/SMark/main' ]
180+
baseline: 'SMark'
181+
with: [ spec repository: 'github://smarr/SMark:v1.0.4/repository' ]
185182
]
186183

187184
{ #category : #dependencies }
188185
BaselineOfPolyMath >> xmlWriter: spec [
189186
spec
190-
project: 'XMLWriter'
191-
with: [ spec
192-
className: #ConfigurationOfXMLWriter;
193-
versionString: '2.3.10';
194-
repository: 'http://smalltalkhub.com/mc/PharoExtras/XMLWriter/main' ]
187+
baseline: 'XMLWriter'
188+
with: [ spec repository: 'github://pharo-contributions/XML-XMLWriter:2.9.0/src' ]
195189
]

src/ExtendedNumberParser/ExtendedNumberParser.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ ExtendedNumberParser >> readNumberWithFractionPartNumberOfTrailingZeroInIntegerP
166166
fractionPart := 0.
167167
numberOfNonZeroFractionDigits := 0.
168168
numberOfTrailingZeroInFractionPart := 0]
169-
ifNotNil: [.
169+
ifNotNil: [
170170
numberOfNonZeroFractionDigits := lastNonZero.
171171
numberOfTrailingZeroInFractionPart := nDigits - lastNonZero].
172172
self readExponent

src/Math-Accuracy-Core/PMAccuracy.class.st

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Class {
1919
#classVars : [
2020
'DecimalPlaces'
2121
],
22-
#category : 'Math-Accuracy-Core'
22+
#category : #'Math-Accuracy-Core'
2323
}
2424

2525
{ #category : #accessing }
@@ -134,7 +134,7 @@ PMAccuracy >> argumentAt: aName [
134134
PMAccuracy >> asArray: aCol [
135135
^(aCol isCollection and: [ aCol isSequenceable and: [aCol isString not] ])
136136
ifTrue: [ aCol asArray ]
137-
ifFalse: [ {aCol} ]
137+
ifFalse: [ Array with: aCol ]
138138
]
139139

140140
{ #category : #private }
@@ -302,7 +302,7 @@ no isCollection ifFalse: [^1].
302302
PMAccuracy >> numberOfDifferentResultsAt: aname [
303303
|no|
304304
no := self resultsAt: aname.
305-
no isCollection ifFalse:[no:={no}].
305+
no isCollection ifFalse:[no:= Array with: no].
306306
^ no first isCollection ifTrue: [ no size ] ifFalse: [ 1 ]
307307
]
308308

@@ -426,7 +426,7 @@ PMAccuracy >> run: anArrayOfNames [
426426
<< 'Report for: ';
427427
<< self class name;
428428
cr.
429-
self ifSeveralterations: [ aStream << 'iterations: ' << iterations; cr ].
429+
self ifSeveralterations: [ aStream << 'iterations: ' << iterations asString; cr ].
430430
(self tree: dataTree removeAll type: self class name data: 'names')
431431
at: 'iterations' put: iterations;
432432
at: 'names' put: (self tree: KeyedTree new type: 'names' data: a).

src/Math-Benchmarks-ODE/PMODEBenchmark.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ PMODEBenchmark class >> runAllToXML: numOfIterations [
3838
xml.
3939
writer tag: 'smark' with: [
4040
(self runAll: numOfIterations) do: [ :runner |
41-
writer tag: 'suite' attributes: { #name -> runner suite class name asString } asDictionary with: [
41+
writer tag: 'suite' attributes: (Dictionary with: #name -> runner suite class name asString) with: [
4242
runner results keysAndValuesDo: [ :key :value |
4343
writer tag: key with: ((value inject: 0 into: [ :subTotal :result |
4444
subTotal + result total ]) / value size) asFloat asString] ] ] ].

src/Math-Core-Process/PMFixpoint.class.st

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ verbose ifFalse: [ ^self ].
6464
GrowlMorph
6565
openWithLabel: 'Info'
6666
contents: ('{1} iterations used.
67-
warning: {2}-cycle detected' format: {iterations. cycleLength})
67+
warning: {2}-cycle detected' format: (Array with: iterations with: cycleLength))
6868
color: Color gray muchDarker
6969
]
7070

@@ -151,7 +151,7 @@ PMFixpoint >> simpleInfo [
151151
verbose ifFalse: [ ^self ].
152152
GrowlMorph
153153
openWithLabel: 'Info'
154-
contents: ('{1} iterations needed.' format: {iterations})
154+
contents: ('{1} iterations needed.' format: (Array with: iterations))
155155
color: Color green muchDarker
156156
]
157157

@@ -161,7 +161,7 @@ verbose ifFalse: [ ^self ].
161161
GrowlMorph
162162
openWithLabel: 'Warning'
163163
contents: ('maximumIterations ({1}) reached.
164-
you can run evaluate a second time' format: {maximumIterations})
164+
you can run evaluate a second time' format: (Array with: maximumIterations))
165165
color: Color orange darker
166166
]
167167

0 commit comments

Comments
 (0)