fix: production hardening — crash bugs, security, logging, tests

CRITICAL BUG FIXES:
- Fix infinite recursion on error in trade.py/creator.py (tenacity retry w/ backoff)
- Fix cron.py Scheduler import shadowing (class overwrites import → stack overflow)
- Fix duplicate prompts_polymarket method in prompts.py
- Fix duplicate 'restricted' field in SimpleEvent model
- Remove pdb.set_trace() from polymarket.py
- Fix search.py executing API call at module import time

SECURITY:
- Validate POLYGON_WALLET_PRIVATE_KEY at init (fail fast)
- Harden format_trade_prompt_for_execution: bounds check (0,1], input validation
- Replace all bare 'except:pass' with specific exception types

OPERATIONAL:
- Add 30s HTTP timeouts to all httpx calls
- Add MAX_PAGINATION_ITERATIONS cap (100) to get_all_current_markets
- Replace all print() with structured logging
- Add .dockerignore, slim Dockerfile with layer caching

TESTING (0 → 47 tests):
- test_objects.py: Pydantic model validation (10)
- test_utils.py: preprocessing functions (8)
- test_prompts.py: prompt generation (10)
- test_executor.py: trade parsing + retain_keys (11)
- test_gamma.py: GammaMarketClient parsing (8)

CI: black --check, ruff lint, pytest (split lint+test jobs)

Author: TheophilusChinomona

.dockerignore

@@ -0,0 +1,15 @@
+.git
+.gitignore
+.github
+.venv
+__pycache__
+*.pyc
+*.pyo
+.env
+.env.*
+!.env.example
+tests/
+docs/images/
+*.md
+!README.md
+.pre-commit-config.yaml

.github/workflows/python-app.yml

@@ -13,8 +13,27 @@ permissions:
   contents: read
 
 jobs:
-  build:
+  lint:
+    runs-on: ubuntu-latest
 
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python 3.9
+      uses: actions/setup-python@v3
+      with:
+        python-version: "3.9"
+    - name: Install lint tools
+      run: |
+        python -m pip install --upgrade pip
+        pip install black ruff
+    - name: Lint with black (check only)
+      run: |
+        black --check --diff .
+    - name: Lint with ruff
+      run: |
+        ruff check .
+
+  test:
     runs-on: ubuntu-latest
 
     steps:
@@ -26,11 +45,8 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install black pytest
+        pip install pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-    - name: Lint with black
-      run: |
-        black .
-    - name: Test with unittest
+    - name: Run tests
       run: |
-        python -m unittest discover
+        python -m pytest tests/ -v

Dockerfile

@@ -1,6 +1,15 @@
-FROM python:3.9
+FROM python:3.9-slim
 
-COPY . /home
-WORKDIR /home
+WORKDIR /app
 
-RUN pip3 install -r requirements.txt
+# Install dependencies first for layer caching
+COPY requirements.txt .
+RUN pip install --no-cache-dir -r requirements.txt
+
+# Copy application code
+COPY agents/ agents/
+COPY scripts/ scripts/
+
+ENV PYTHONPATH="/app"
+
+CMD ["python", "scripts/python/cli.py"]

agents/application/creator.py

@@ -1,46 +1,52 @@
+import logging
+
+from tenacity import retry, stop_after_attempt, wait_exponential, retry_if_exception_type
+
 from agents.application.executor import Executor as Agent
 from agents.polymarket.gamma import GammaMarketClient as Gamma
 from agents.polymarket.polymarket import Polymarket
 
+logger = logging.getLogger(__name__)
+
+MAX_RETRIES = 3
+
 
 class Creator:
     def __init__(self):
         self.polymarket = Polymarket()
         self.gamma = Gamma()
         self.agent = Agent()
 
+    @retry(
+        stop=stop_after_attempt(MAX_RETRIES),
+        wait=wait_exponential(multiplier=1, min=2, max=30),
+        retry=retry_if_exception_type((ConnectionError, TimeoutError, RuntimeError)),
+        reraise=True,
+    )
     def one_best_market(self):
         """
-
-        one_best_trade is a strategy that evaluates all events, markets, and orderbooks
-
-        leverages all available information sources accessible to the autonomous agent
-
-        then executes that trade without any human intervention
-
+        Evaluates all events, markets, and orderbooks using the autonomous agent,
+        then proposes a new market idea.
         """
-        try:
-            events = self.polymarket.get_all_tradeable_events()
-            print(f"1. FOUND {len(events)} EVENTS")
+        events = self.polymarket.get_all_tradeable_events()
+        logger.info("1. FOUND %d EVENTS", len(events))
 
-            filtered_events = self.agent.filter_events_with_rag(events)
-            print(f"2. FILTERED {len(filtered_events)} EVENTS")
+        filtered_events = self.agent.filter_events_with_rag(events)
+        logger.info("2. FILTERED %d EVENTS", len(filtered_events))
 
-            markets = self.agent.map_filtered_events_to_markets(filtered_events)
-            print()
-            print(f"3. FOUND {len(markets)} MARKETS")
+        markets = self.agent.map_filtered_events_to_markets(filtered_events)
+        logger.info("3. FOUND %d MARKETS", len(markets))
 
-            print()
-            filtered_markets = self.agent.filter_markets(markets)
-            print(f"4. FILTERED {len(filtered_markets)} MARKETS")
+        filtered_markets = self.agent.filter_markets(markets)
+        logger.info("4. FILTERED %d MARKETS", len(filtered_markets))
 
-            best_market = self.agent.source_best_market_to_create(filtered_markets)
-            print(f"5. IDEA FOR NEW MARKET {best_market}")
-            return best_market
+        if not filtered_markets:
+            logger.warning("No markets passed filtering — skipping")
+            return None
 
-        except Exception as e:
-            print(f"Error {e} \n \n Retrying")
-            self.one_best_market()
+        best_market = self.agent.source_best_market_to_create(filtered_markets)
+        logger.info("5. IDEA FOR NEW MARKET %s", best_market)
+        return best_market
 
     def maintain_positions(self):
         pass

agents/application/cron.py

@@ -1,24 +1,27 @@
-from agents.application.trade import Trader
-
+import logging
 import time
 
-from scheduler import Scheduler
+from scheduler import Scheduler as TimeScheduler
 from scheduler.trigger import Monday
 
+from agents.application.trade import Trader
+
+logger = logging.getLogger(__name__)
+
 
-class Scheduler:
+class TradingScheduler:
     def __init__(self) -> None:
         self.trader = Trader()
-        self.schedule = Scheduler()
+        self.schedule = TimeScheduler()
 
     def start(self) -> None:
+        logger.info("Starting trading scheduler loop")
         while True:
             self.schedule.exec_jobs()
             time.sleep(1)
 
 
-class TradingAgent(Scheduler):
+class TradingAgent(TradingScheduler):
     def __init__(self) -> None:
-        super()
-        self.trader = Trader()
+        super().__init__()
         self.weekly(Monday(), self.trader.one_best_trade)

agents/application/executor.py

@@ -1,11 +1,11 @@
-import os
-import json
 import ast
+import json
+import logging
+import math
+import os
 import re
 from typing import List, Dict, Any
 
-import math
-
 from dotenv import load_dotenv
 from langchain_core.messages import HumanMessage, SystemMessage
 from langchain_openai import ChatOpenAI
@@ -16,6 +16,8 @@
 from agents.application.prompts import Prompter
 from agents.polymarket.polymarket import Polymarket
 
+logger = logging.getLogger(__name__)
+
 def retain_keys(data, keys_to_retain):
     if isinstance(data, dict):
         return {
@@ -129,9 +131,7 @@ def filter_events(self, events: "list[SimpleEvent]") -> str:
 
     def filter_events_with_rag(self, events: "list[SimpleEvent]") -> str:
         prompt = self.prompter.filter_events()
-        print()
-        print("... prompting ... ", prompt)
-        print()
+        logger.info("... prompting ... %s", prompt)
         return self.chroma.events(events, prompt)
 
     def map_filtered_events_to_markets(
@@ -149,9 +149,7 @@ def map_filtered_events_to_markets(
 
     def filter_markets(self, markets) -> "list[tuple]":
         prompt = self.prompter.filter_markets()
-        print()
-        print("... prompting ... ", prompt)
-        print()
+        logger.info("... prompting ... %s", prompt)
         return self.chroma.markets(markets, prompt)
 
     def source_best_trade(self, market_object) -> str:
@@ -163,36 +161,55 @@ def source_best_trade(self, market_object) -> str:
         description = market_document["page_content"]
 
         prompt = self.prompter.superforecaster(question, description, outcomes)
-        print()
-        print("... prompting ... ", prompt)
-        print()
+        logger.info("... prompting superforecaster: %s", prompt)
         result = self.llm.invoke(prompt)
         content = result.content
+        logger.info("Superforecaster result: %s", content)
 
-        print("result: ", content)
-        print()
         prompt = self.prompter.one_best_trade(content, outcomes, outcome_prices)
-        print("... prompting ... ", prompt)
-        print()
+        logger.info("... prompting trade: %s", prompt)
         result = self.llm.invoke(prompt)
         content = result.content
-
-        print("result: ", content)
-        print()
+        logger.info("Trade result: %s", content)
         return content
 
     def format_trade_prompt_for_execution(self, best_trade: str) -> float:
+        """Parse LLM trade output into a safe USDC amount.
+
+        Expected format: 'price:0.5, size:0.1, side:BUY,'
+        Returns: size_fraction * usdc_balance
+        """
         data = best_trade.split(",")
-        # price = re.findall("\d+\.\d+", data[0])[0]
-        size = re.findall("\d+\.\d+", data[1])[0]
+        if len(data) < 2:
+            raise ValueError(
+                f"Trade output has unexpected format (need >=2 comma-separated parts): {best_trade!r}"
+            )
+
+        size_matches = re.findall(r"\d+\.?\d*", data[1])
+        if not size_matches:
+            raise ValueError(
+                f"Could not extract size from trade output: {data[1]!r}"
+            )
+
+        size = float(size_matches[0])
+        if not (0 < size <= 1):
+            raise ValueError(
+                f"Trade size {size} out of safe range (0, 1] — refusing to execute"
+            )
+
         usdc_balance = self.polymarket.get_usdc_balance()
-        return float(size) * usdc_balance
+        amount = size * usdc_balance
+        logger.info(
+            "Trade size fraction: %.4f, USDC balance: %.2f, order amount: %.2f",
+            size,
+            usdc_balance,
+            amount,
+        )
+        return amount
 
     def source_best_market_to_create(self, filtered_markets) -> str:
         prompt = self.prompter.create_new_market(filtered_markets)
-        print()
-        print("... prompting ... ", prompt)
-        print()
+        logger.info("... prompting market creation: %s", prompt)
         result = self.llm.invoke(prompt)
         content = result.content
         return content

agents/application/prompts.py

@@ -33,25 +33,6 @@ def sentiment_analyzer(self, question: str, outcome: str) -> float:
         
         """
 
-    def prompts_polymarket(
-        self, data1: str, data2: str, market_question: str, outcome: str
-    ) -> str:
-        current_market_data = str(data1)
-        current_event_data = str(data2)
-        return f"""
-        You are an AI assistant for users of a prediction market called Polymarket.
-        Users want to place bets based on their beliefs of market outcomes such as political or sports events.
-        
-        Here is data for current Polymarket markets {current_market_data} and 
-        current Polymarket events {current_event_data}.
-
-        Help users identify markets to trade based on their interests or queries.
-        Provide specific information for markets including probabilities of outcomes.
-        Give your response in the following format:
-
-        I believe {market_question} has a likelihood {float} for outcome of {outcome}.
-        """
-
     def prompts_polymarket(self, data1: str, data2: str) -> str:
         current_market_data = str(data1)
         current_event_data = str(data2)