chore: 🤖 add isAssetId helper to check for asset ID

Author: prashantasdeveloper

src/assets/assets.service.ts

@@ -12,13 +12,13 @@ import {
   ResultSet,
 } from '@polymeshassociation/polymesh-sdk/types';
 
-import { ASSET_ID_LENGTH } from '~/assets/assets.consts';
 import { ControllerTransferDto } from '~/assets/dto/controller-transfer.dto';
 import { CreateAssetDto } from '~/assets/dto/create-asset.dto';
 import { IssueDto } from '~/assets/dto/issue.dto';
 import { RedeemTokensDto } from '~/assets/dto/redeem-tokens.dto';
 import { RequiredMediatorsDto } from '~/assets/dto/required-mediators.dto';
 import { SetAssetDocumentsDto } from '~/assets/dto/set-asset-documents.dto';
+import { isAssetId } from '~/common/decorators';
 import { TransactionBaseDto } from '~/common/dto/transaction-base-dto';
 import { TransferOwnershipDto } from '~/common/dto/transfer-ownership.dto';
 import { AppNotFoundError } from '~/common/errors';
@@ -37,7 +37,7 @@ export class AssetsService {
 
   public async findOne(asset: string): Promise<Asset> {
     let getAssetPromise;
-    if (asset.length === ASSET_ID_LENGTH) {
+    if (isAssetId(asset)) {
       getAssetPromise = this.polymeshService.polymeshApi.assets.getAsset({ assetId: asset });
     } else {
       getAssetPromise = this.polymeshService.polymeshApi.assets.getAsset({ ticker: asset });
@@ -49,7 +49,7 @@ export class AssetsService {
 
   public async findFungible(asset: string): Promise<FungibleAsset> {
     let getAssetPromise;
-    if (asset.length === ASSET_ID_LENGTH) {
+    if (isAssetId(asset)) {
       getAssetPromise = this.polymeshService.polymeshApi.assets.getFungibleAsset({
         assetId: asset,
       });

src/common/decorators/validation.ts

@@ -42,6 +42,11 @@ export function IsTicker(validationOptions?: ValidationOptions) {
   );
 }
 
+const assetIdRegex = /0x[0-9A-F]{32}/;
+export const isAssetId = (id: string): boolean => {
+  return assetIdRegex.test(id);
+};
+
 export function IsAsset(validationOptions?: ValidationOptions) {
   // eslint-disable-next-line @typescript-eslint/ban-types
   return function (object: Object, propertyName: string) {
@@ -52,12 +57,9 @@ export function IsAsset(validationOptions?: ValidationOptions) {
       options: validationOptions,
       validator: {
         validate(value: string) {
-          if (value.startsWith('0x')) {
-            // check for Asset ID
-            return value.length === ASSET_ID_LENGTH;
-          }
-
-          return value.length <= MAX_TICKER_LENGTH && value === value.toUpperCase();
+          return (
+            isAssetId(value) || (value.length <= MAX_TICKER_LENGTH && value === value.toUpperCase())
+          );
         },
         defaultMessage(args: ValidationArguments) {
           return `${args.property} must be either a Ticker (${MAX_TICKER_LENGTH} characters uppercase string) or an Asset ID (${ASSET_ID_LENGTH} characters long hex string)`;