feat(settings): clamp default effort to nearest supported level

If the user's defaultReasoningEffort isn't supported by the current
model, fall to the nearest available level by rank (low < medium < high
< xhigh < max) instead of silently no-opping. So 'max' on a model that
caps at 'high' becomes 'high'; 'low' on a model that only supports
'medium+' becomes 'medium'.

Generated-By: PostHog Code
Task-Id: c5674c04-c95c-4bfe-bfcf-248a921b4aae

Author: jonathanlab

apps/code/src/renderer/features/settings/components/sections/GeneralSettings.tsx

@@ -1,11 +1,11 @@
 import { useAuthStateValue } from "@features/auth/hooks/authQueries";
 import { SettingRow } from "@features/settings/components/SettingRow";
 import {
- type AutoConvertLongText,
- type CompletionSound,
- type DefaultInitialTaskMode,
- type DefaultReasoningEffort,
- type DiffOpenMode,
+  type AutoConvertLongText,
+  type CompletionSound,
+  type DefaultInitialTaskMode,
+  type DefaultReasoningEffort,
+  type DiffOpenMode,
   type SendMessagesWith,
   useSettingsStore,
 } from "@features/settings/stores/settingsStore";
@@ -76,21 +76,21 @@ export function GeneralSettings() {
     dockBounceNotifications,
     completionSound,
     completionVolume,
- autoConvertLongText,
- defaultInitialTaskMode,
- defaultReasoningEffort,
- diffOpenMode,
- sendMessagesWith,
- hedgehogMode,
- setDesktopNotifications,
- setDockBadgeNotifications,
- setDockBounceNotifications,
- setCompletionSound,
- setCompletionVolume,
- setAutoConvertLongText,
- setDefaultInitialTaskMode,
- setDefaultReasoningEffort,
- setDiffOpenMode,
+    autoConvertLongText,
+    defaultInitialTaskMode,
+    defaultReasoningEffort,
+    diffOpenMode,
+    sendMessagesWith,
+    hedgehogMode,
+    setDesktopNotifications,
+    setDockBadgeNotifications,
+    setDockBounceNotifications,
+    setCompletionSound,
+    setCompletionVolume,
+    setAutoConvertLongText,
+    setDefaultInitialTaskMode,
+    setDefaultReasoningEffort,
+    setDiffOpenMode,
     setSendMessagesWith,
     setHedgehogMode,
   } = useSettingsStore();
@@ -181,31 +181,31 @@ export function GeneralSettings() {
     [diffOpenMode, setDiffOpenMode],
   );
 
- const handleDefaultInitialTaskModeChange = useCallback(
- (value: DefaultInitialTaskMode) => {
- track(ANALYTICS_EVENTS.SETTING_CHANGED, {
- setting_name: "default_initial_task_mode",
- new_value: value,
- old_value: defaultInitialTaskMode,
- });
- setDefaultInitialTaskMode(value);
- },
- [defaultInitialTaskMode, setDefaultInitialTaskMode],
- );
-
- const handleDefaultReasoningEffortChange = useCallback(
- (value: DefaultReasoningEffort) => {
- track(ANALYTICS_EVENTS.SETTING_CHANGED, {
- setting_name: "default_reasoning_effort",
- new_value: value,
- old_value: defaultReasoningEffort,
- });
- setDefaultReasoningEffort(value);
- },
- [defaultReasoningEffort, setDefaultReasoningEffort],
- );
-
- const handleSendMessagesWithChange = useCallback(
+  const handleDefaultInitialTaskModeChange = useCallback(
+    (value: DefaultInitialTaskMode) => {
+      track(ANALYTICS_EVENTS.SETTING_CHANGED, {
+        setting_name: "default_initial_task_mode",
+        new_value: value,
+        old_value: defaultInitialTaskMode,
+      });
+      setDefaultInitialTaskMode(value);
+    },
+    [defaultInitialTaskMode, setDefaultInitialTaskMode],
+  );
+
+  const handleDefaultReasoningEffortChange = useCallback(
+    (value: DefaultReasoningEffort) => {
+      track(ANALYTICS_EVENTS.SETTING_CHANGED, {
+        setting_name: "default_reasoning_effort",
+        new_value: value,
+        old_value: defaultReasoningEffort,
+      });
+      setDefaultReasoningEffort(value);
+    },
+    [defaultReasoningEffort, setDefaultReasoningEffort],
+  );
+
+  const handleSendMessagesWithChange = useCallback(
     (value: SendMessagesWith) => {
       track(ANALYTICS_EVENTS.SETTING_CHANGED, {
         setting_name: "send_messages_with",
@@ -396,36 +396,36 @@ export function GeneralSettings() {
           <Select.Trigger className="min-w-[100px]" />
           <Select.Content>
             <Select.Item value="plan">Plan</Select.Item>
- <Select.Item value="last_used">Last used</Select.Item>
- </Select.Content>
- </Select.Root>
- </SettingRow>
-
- <SettingRow
- label="Default effort level"
- description="Choose the default reasoning effort for new tasks, or remember your last-used level"
- >
- <Select.Root
- value={defaultReasoningEffort}
- onValueChange={(value) =>
- handleDefaultReasoningEffortChange(value as DefaultReasoningEffort)
- }
- size="1"
- >
- <Select.Trigger className="min-w-[100px]" />
- <Select.Content>
- <Select.Item value="last_used">Last used</Select.Item>
- <Select.Item value="low">Low</Select.Item>
- <Select.Item value="medium">Medium</Select.Item>
- <Select.Item value="high">High</Select.Item>
- <Select.Item value="xhigh">Extra High</Select.Item>
- <Select.Item value="max">Max</Select.Item>
- </Select.Content>
- </Select.Root>
- </SettingRow>
-
- <SettingRow
- label="Send messages with"
+            <Select.Item value="last_used">Last used</Select.Item>
+          </Select.Content>
+        </Select.Root>
+      </SettingRow>
+
+      <SettingRow
+        label="Default effort level"
+        description="Choose the default reasoning effort for new tasks, or remember your last-used level"
+      >
+        <Select.Root
+          value={defaultReasoningEffort}
+          onValueChange={(value) =>
+            handleDefaultReasoningEffortChange(value as DefaultReasoningEffort)
+          }
+          size="1"
+        >
+          <Select.Trigger className="min-w-[100px]" />
+          <Select.Content>
+            <Select.Item value="last_used">Last used</Select.Item>
+            <Select.Item value="low">Low</Select.Item>
+            <Select.Item value="medium">Medium</Select.Item>
+            <Select.Item value="high">High</Select.Item>
+            <Select.Item value="xhigh">Extra High</Select.Item>
+            <Select.Item value="max">Max</Select.Item>
+          </Select.Content>
+        </Select.Root>
+      </SettingRow>
+
+      <SettingRow
+        label="Send messages with"
         description="Choose which key combination sends messages. Use Shift+Enter for new lines"
       >
         <Select.Root

apps/code/src/renderer/features/settings/stores/settingsStore.ts

@@ -24,7 +24,13 @@ export type CompletionSound =
 export type AgentAdapter = "claude" | "codex";
 export type AutoConvertLongText = "off" | "1000" | "2500" | "5000" | "10000";
 export type DefaultInitialTaskMode = "plan" | "last_used";
-export type DefaultReasoningEffort = "low" | "medium" | "high" | "xhigh" | "max" | "last_used";
+export type DefaultReasoningEffort =
+  | "low"
+  | "medium"
+  | "high"
+  | "xhigh"
+  | "max"
+  | "last_used";
 
 export interface HintState {
   count: number;
@@ -54,10 +60,10 @@ interface SettingsStore {
   preventSleepWhileRunning: boolean;
   debugLogsCloudRuns: boolean;
   customInstructions: string;
- defaultInitialTaskMode: DefaultInitialTaskMode;
- lastUsedInitialTaskMode: ExecutionMode;
- defaultReasoningEffort: DefaultReasoningEffort;
- diffOpenMode: DiffOpenMode;
+  defaultInitialTaskMode: DefaultInitialTaskMode;
+  lastUsedInitialTaskMode: ExecutionMode;
+  defaultReasoningEffort: DefaultReasoningEffort;
+  diffOpenMode: DiffOpenMode;
   hedgehogMode: boolean;
   mcpAppsDisabledServers: string[];
   hints: Record<string, HintState>;
@@ -91,10 +97,10 @@ interface SettingsStore {
   setPreventSleepWhileRunning: (enabled: boolean) => void;
   setDebugLogsCloudRuns: (enabled: boolean) => void;
   setCustomInstructions: (instructions: string) => void;
- setDefaultInitialTaskMode: (mode: DefaultInitialTaskMode) => void;
- setLastUsedInitialTaskMode: (mode: ExecutionMode) => void;
- setDefaultReasoningEffort: (effort: DefaultReasoningEffort) => void;
- setDiffOpenMode: (mode: DiffOpenMode) => void;
+  setDefaultInitialTaskMode: (mode: DefaultInitialTaskMode) => void;
+  setLastUsedInitialTaskMode: (mode: ExecutionMode) => void;
+  setDefaultReasoningEffort: (effort: DefaultReasoningEffort) => void;
+  setDiffOpenMode: (mode: DiffOpenMode) => void;
   setHedgehogMode: (enabled: boolean) => void;
   setMcpAppsDisabledServers: (servers: string[]) => void;
 }
@@ -123,10 +129,10 @@ export const useSettingsStore = create<SettingsStore>()(
       preventSleepWhileRunning: false,
       debugLogsCloudRuns: false,
       customInstructions: "",
- defaultInitialTaskMode: "plan",
- lastUsedInitialTaskMode: "plan",
- defaultReasoningEffort: "last_used",
- diffOpenMode: "auto",
+      defaultInitialTaskMode: "plan",
+      lastUsedInitialTaskMode: "plan",
+      defaultReasoningEffort: "last_used",
+      diffOpenMode: "auto",
       hedgehogMode: false,
       mcpAppsDisabledServers: [],
       hints: {},
@@ -198,13 +204,13 @@ export const useSettingsStore = create<SettingsStore>()(
       setDebugLogsCloudRuns: (enabled) => set({ debugLogsCloudRuns: enabled }),
       setCustomInstructions: (instructions) =>
         set({ customInstructions: instructions }),
- setDefaultInitialTaskMode: (mode) =>
- set({ defaultInitialTaskMode: mode }),
- setLastUsedInitialTaskMode: (mode) =>
- set({ lastUsedInitialTaskMode: mode }),
- setDefaultReasoningEffort: (effort) =>
- set({ defaultReasoningEffort: effort }),
- setDiffOpenMode: (mode) => set({ diffOpenMode: mode }),
+      setDefaultInitialTaskMode: (mode) =>
+        set({ defaultInitialTaskMode: mode }),
+      setLastUsedInitialTaskMode: (mode) =>
+        set({ lastUsedInitialTaskMode: mode }),
+      setDefaultReasoningEffort: (effort) =>
+        set({ defaultReasoningEffort: effort }),
+      setDiffOpenMode: (mode) => set({ diffOpenMode: mode }),
       setHedgehogMode: (enabled) => set({ hedgehogMode: enabled }),
       setMcpAppsDisabledServers: (servers) =>
         set({ mcpAppsDisabledServers: servers }),
@@ -234,10 +240,10 @@ export const useSettingsStore = create<SettingsStore>()(
         preventSleepWhileRunning: state.preventSleepWhileRunning,
         debugLogsCloudRuns: state.debugLogsCloudRuns,
         customInstructions: state.customInstructions,
- defaultInitialTaskMode: state.defaultInitialTaskMode,
- lastUsedInitialTaskMode: state.lastUsedInitialTaskMode,
- defaultReasoningEffort: state.defaultReasoningEffort,
- diffOpenMode: state.diffOpenMode,
+        defaultInitialTaskMode: state.defaultInitialTaskMode,
+        lastUsedInitialTaskMode: state.lastUsedInitialTaskMode,
+        defaultReasoningEffort: state.defaultReasoningEffort,
+        diffOpenMode: state.diffOpenMode,
         hedgehogMode: state.hedgehogMode,
         hints: state.hints,
         mcpAppsDisabledServers: state.mcpAppsDisabledServers,