refactor(code): drop [UNPUBLISHED] prefix logic — never shipped

Auto-create at scaffold time was the only thing that produced the
prefix; now that's gone. Cleaning up the dead code:

- usePublishScratchpad: drops the rename step (no prefix to strip)
  and the productName input. Hook just publishes.
- useDeleteScratchpad: drops the project deletion path entirely.
  Drafts only ever reference user-picked projects, which we never
  delete.
- posthogClient.deleteProject + useDeleteProject hook: deleted; no
  consumers remain.
- DraftTaskHeaderActions: takes taskTitle directly instead of
  fetching the linked project to derive a name.
- PublishDialog: stops threading productName through to the publish
  hook; only uses it as a pre-fill for the create-new-project name.

Tests trimmed accordingly.

Generated-By: PostHog Code
Task-Id: 142b4c29-fa5f-4e02-9bc9-de8b22313475

Author: Twixes

apps/code/src/renderer/api/posthogClient.ts

@@ -603,16 +603,6 @@ export class PostHogAPIClient {
     return data as Schemas.Team;
   }
 
-  async deleteProject(projectId: number): Promise<void> {
-    await this.api.delete(
-      // @ts-expect-error this endpoint is not in the generated client
-      "/api/projects/{project_id}/",
-      {
-        path: { project_id: projectId.toString() },
-      },
-    );
-  }
-
   async listSignalSourceConfigs(
     projectId: number,
   ): Promise<SignalSourceConfig[]> {

apps/code/src/renderer/features/posthog-projects/hooks/useCreateProject.test.ts

@@ -8,7 +8,6 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
 const mockClient = vi.hoisted(() => ({
   createProject: vi.fn(),
   updateProject: vi.fn(),
-  deleteProject: vi.fn(),
   getCurrentUser: vi.fn(),
 }));
 
@@ -29,7 +28,6 @@ vi.mock("@utils/logger", () => ({
 
 // Imports after mocks so the modules pick up the mocked dependencies.
 import { useCreateProject } from "./useCreateProject";
-import { useDeleteProject } from "./useDeleteProject";
 import { useUpdateProject } from "./useUpdateProject";
 
 // --- Helpers ------------------------------------------------------------
@@ -55,7 +53,7 @@ function newClient() {
 
 // --- Tests --------------------------------------------------------------
 
-describe("useCreateProject / useUpdateProject / useDeleteProject", () => {
+describe("useCreateProject / useUpdateProject", () => {
   beforeEach(() => {
     vi.clearAllMocks();
   });
@@ -131,52 +129,6 @@ describe("useCreateProject / useUpdateProject / useDeleteProject", () => {
     expect(mockClient.updateProject).toHaveBeenCalledWith(5, { name: "new" });
   });
 
-  it("deleteProject: happy path calls client.deleteProject with the id", async () => {
-    mockClient.deleteProject.mockResolvedValueOnce(undefined);
-
-    const queryClient = newClient();
-    const { result } = renderHook(() => useDeleteProject(), {
-      wrapper: makeWrapper(queryClient),
-    });
-
-    await waitFor(async () => {
-      await result.current.mutateAsync({ projectId: 9 });
-    });
-
-    expect(mockClient.deleteProject).toHaveBeenCalledTimes(1);
-    expect(mockClient.deleteProject).toHaveBeenCalledWith(9);
-  });
-
-  it("deleteProject: 404 from API resolves successfully (already gone)", async () => {
-    mockClient.deleteProject.mockRejectedValueOnce(
-      new Error('Failed request: [404] {"detail":"Not found."}'),
-    );
-
-    const queryClient = newClient();
-    const { result } = renderHook(() => useDeleteProject(), {
-      wrapper: makeWrapper(queryClient),
-    });
-
-    await expect(
-      result.current.mutateAsync({ projectId: 123 }),
-    ).resolves.toBeUndefined();
-  });
-
-  it("deleteProject: 403 surfaces a permissions error", async () => {
-    mockClient.deleteProject.mockRejectedValueOnce(
-      new Error('Failed request: [403] {"detail":"forbidden"}'),
-    );
-
-    const queryClient = newClient();
-    const { result } = renderHook(() => useDeleteProject(), {
-      wrapper: makeWrapper(queryClient),
-    });
-
-    await expect(
-      result.current.mutateAsync({ projectId: 123 }),
-    ).rejects.toThrow(/insufficient permissions/i);
-  });
-
   it("createProject: invalidates the projects-list cache on success", async () => {
     mockClient.createProject.mockResolvedValueOnce({ id: 1, name: "x" });
 

apps/code/src/renderer/features/posthog-projects/hooks/useDeleteProject.ts

@@ -1,14 +1,12 @@
 import { PublishDialog } from "@features/scratchpads/components/PublishDialog";
 import { useDraftTaskIds } from "@features/scratchpads/hooks/useDraftTaskInfo";
-import { useAuthenticatedClient } from "@hooks/useAuthenticatedClient";
 import { UploadSimpleIcon } from "@phosphor-icons/react";
 import { Button } from "@radix-ui/themes";
-import { trpc } from "@renderer/trpc";
-import { useQuery } from "@tanstack/react-query";
 import { useState } from "react";
 
 interface DraftTaskHeaderActionsProps {
   taskId: string;
+  taskTitle: string;
 }
 
 /**
@@ -17,56 +15,22 @@ interface DraftTaskHeaderActionsProps {
  */
 export function DraftTaskHeaderActions({
   taskId,
+  taskTitle,
 }: DraftTaskHeaderActionsProps) {
   const draftTaskIds = useDraftTaskIds();
   const isDraft = draftTaskIds.has(taskId);
 
-  const posthogClient = useAuthenticatedClient();
-
-  const manifestQuery = useQuery(
-    trpc.scratchpad.readManifest.queryOptions(
-      { taskId },
-      {
-        enabled: isDraft,
-        staleTime: 30_000,
-      },
-    ),
-  );
-
-  const projectId = manifestQuery.data?.projectId;
-  const hasLinkedProject = projectId != null;
-  const projectQuery = useQuery({
-    queryKey: ["project", projectId],
-    queryFn: () => {
-      if (!hasLinkedProject) return null;
-      return posthogClient.getProject(projectId).catch(() => null);
-    },
-    enabled: isDraft && hasLinkedProject,
-    staleTime: 60_000,
-  });
-
   const [dialogOpen, setDialogOpen] = useState(false);
 
   if (!isDraft) return null;
 
-  // When no project is linked we still render the Publish button so the user
-  // can see the path forward — the dialog/hook will explain that linking a
-  // project is a prerequisite.
-  const productName = hasLinkedProject
-    ? (projectQuery.data?.name ?? "")
-    : manifestQuery.data
-      ? ""
-      : "";
-  const repoNameDefault = productName;
-
   return (
     <>
       <Button
         size="1"
         variant="soft"
         color="green"
         onClick={() => setDialogOpen(true)}
-        disabled={hasLinkedProject && !productName}
       >
         <UploadSimpleIcon size={12} weight="bold" />
         Publish
@@ -76,8 +40,8 @@ export function DraftTaskHeaderActions({
           open={dialogOpen}
           onOpenChange={setDialogOpen}
           taskId={taskId}
-          defaultRepoName={repoNameDefault}
-          productName={productName}
+          defaultRepoName={taskTitle}
+          productName={taskTitle}
         />
       )}
     </>

apps/code/src/renderer/features/scratchpads/components/DraftTaskHeaderActions.tsx

@@ -84,9 +84,10 @@ function fillRequiredFields() {
   fireEvent.change(screen.getByPlaceholderText("Uber for dogs"), {
     target: { value: "My Product" },
   });
-  fireEvent.change(screen.getByPlaceholderText(/On-demand dog walks/), {
-    target: { value: "An idea" },
-  });
+  fireEvent.change(
+    screen.getByPlaceholderText(/Web app to get a dog delivered on demand/),
+    { target: { value: "An idea" } },
+  );
 }
 
 describe("ProductCreationDialog", () => {
@@ -113,24 +114,24 @@ describe("ProductCreationDialog", () => {
     useScratchpadCreationStore.getState().reset();
   });
 
-  it("defaults rounds to 3 and exposes 1..5 in the segmented control", () => {
+  it("defaults rounds to 3 and exposes 1..4 in the segmented control", () => {
     renderDialog();
-    expect(screen.getByText(/We'll ask up to/)).toBeInTheDocument();
+    expect(screen.getByText(/I'll ask up to/)).toBeInTheDocument();
     expect(
       screen.getByText(/of clarifying questions to shape your product\./),
     ).toBeInTheDocument();
 
     expect(screen.getByRole("radio", { name: "3" })).toBeChecked();
-    for (const n of ["1", "2", "3", "4", "5"]) {
+    for (const n of ["1", "2", "3", "4"]) {
       expect(screen.getByRole("radio", { name: n })).toBeInTheDocument();
     }
 
-    // Switch to 5
-    fireEvent.click(screen.getByRole("radio", { name: "5" }));
-    expect(screen.getByRole("radio", { name: "5" })).toBeChecked();
+    // Switch to 4
+    fireEvent.click(screen.getByRole("radio", { name: "4" }));
+    expect(screen.getByRole("radio", { name: "4" })).toBeChecked();
 
-    // The selector caps at 5 — there is no "6" option rendered.
-    expect(screen.queryByRole("radio", { name: "6" })).toBeNull();
+    // The selector caps at 4 — there is no "5" option rendered.
+    expect(screen.queryByRole("radio", { name: "5" })).toBeNull();
   });
 
   it("submit with default 'later' mode passes no projectId (link decided at publish time)", async () => {

apps/code/src/renderer/features/scratchpads/components/ProductCreationDialog.test.tsx

@@ -18,9 +18,12 @@ import { useState } from "react";
 
 const log = logger.scope("product-creation-dialog");
 
-const ROUND_OPTIONS = [1, 2, 3, 4, 5] as const;
 const MIN_ROUNDS = 1;
-const MAX_ROUNDS = 5;
+const MAX_ROUNDS = 4;
+const ROUND_OPTIONS: number[] = Array.from(
+  { length: MAX_ROUNDS },
+  (_, i) => i + 1,
+);
 const DEFAULT_ROUNDS = 3;
 
 type ProjectMode = "later" | "existing";
@@ -141,32 +144,9 @@ export function ProductCreationDialog() {
             Create a new product
           </Dialog.Title>
 
-          <Text
-            as="div"
-            className="rounded-(--radius-2) border border-(--gray-5) bg-(--gray-2) px-3 py-2 text-(--gray-12) text-[13px] leading-6"
-          >
-            We'll ask up to{" "}
-            <SegmentedControl.Root
-              size="1"
-              value={String(rounds)}
-              onValueChange={(v) => setRounds(clampRounds(Number(v)))}
-              disabled={isSubmitting}
-              aria-label="Clarification rounds"
-              className="!h-[20px] mx-1 inline-flex align-middle text-[12px]"
-            >
-              {ROUND_OPTIONS.map((n) => (
-                <SegmentedControl.Item key={n} value={String(n)}>
-                  {n}
-                </SegmentedControl.Item>
-              ))}
-            </SegmentedControl.Root>{" "}
-            {rounds === 1 ? "round" : "rounds"} of clarifying questions to shape
-            your product.
-          </Text>
-
           <Flex direction="column" gap="1">
             <Text color="gray" className="text-[13px]">
-              Product name
+              What's the name of your new thing?
             </Text>
             <TextField.Root
               value={productName}
@@ -180,12 +160,12 @@ export function ProductCreationDialog() {
 
           <Flex direction="column" gap="1">
             <Text color="gray" className="text-[13px]">
-              Initial idea
+              What would you like me to build?
             </Text>
             <TextArea
               value={initialIdea}
               onChange={(e) => setInitialIdea(e.target.value)}
-              placeholder="On-demand dog walks and rides to the vet. Owners book through a mobile app, walkers/drivers accept gigs nearby, payments and tips are handled in-app..."
+              placeholder="Web app to get a dog delivered on demand, or something."
               size="2"
               rows={5}
               disabled={isSubmitting}
@@ -206,7 +186,7 @@ export function ProductCreationDialog() {
                 <Text as="label" className="text-[13px]">
                   <Flex gap="2" align="center">
                     <RadioGroup.Item value="later" />
-                    Let's do this later
+                    Set up on publish later
                   </Flex>
                 </Text>
                 <Text as="label" className="text-[13px]">
@@ -220,7 +200,7 @@ export function ProductCreationDialog() {
 
             {projectMode === "later" && (
               <Text color="gray" className="text-[13px]">
-                We'll wire up PostHog (analytics, replay, error tracking) with
+                I'll wire up PostHog (analytics, replay, error tracking) with
                 placeholder credentials so the SDK is in place. You'll pick or
                 create a real project at publish time.
               </Text>
@@ -232,6 +212,29 @@ export function ProductCreationDialog() {
                 disabled={isSubmitting}
               />
             )}
+
+            <Text
+              as="div"
+              className="rounded-(--radius-2) border border-(--gray-5) bg-(--gray-2) px-3 py-2 text-(--gray-12) text-[13px] leading-6"
+            >
+              I'll ask up to{" "}
+              <SegmentedControl.Root
+                size="1"
+                value={String(rounds)}
+                onValueChange={(v) => setRounds(clampRounds(Number(v)))}
+                disabled={isSubmitting}
+                aria-label="Clarification rounds"
+                className="!h-[20px] mx-1 inline-flex align-middle text-[12px]"
+              >
+                {ROUND_OPTIONS.map((n) => (
+                  <SegmentedControl.Item key={n} value={String(n)}>
+                    {n}
+                  </SegmentedControl.Item>
+                ))}
+              </SegmentedControl.Root>{" "}
+              {rounds === 1 ? "round" : "rounds"} of clarifying questions to
+              shape your product.
+            </Text>
           </Flex>
 
           {lastError && (