refactor(inbox): move reviewer-seed policy into the store

Collapse the two-step "set filter, then mark initialized" dance into a single
store action that owns the idempotency check. The component effect becomes a
trivial bridge from `useCurrentUser` to the store. Adds tests covering the
seed, the no-op-after-init, and the preserve-existing-choice cases.

Generated-By: PostHog Code
Task-Id: 9fcb5fbc-ec76-4b37-a0bc-dc4556c0d8a6

Author: joshsny

apps/code/src/renderer/features/inbox/components/InboxSignalsTab.tsx

@@ -68,14 +68,8 @@ export function InboxSignalsTab() {
   const suggestedReviewerFilter = useInboxSignalsFilterStore(
     (s) => s.suggestedReviewerFilter,
   );
-  const hasInitializedSuggestedReviewerFilter = useInboxSignalsFilterStore(
-    (s) => s.hasInitializedSuggestedReviewerFilter,
-  );
-  const setSuggestedReviewerFilter = useInboxSignalsFilterStore(
-    (s) => s.setSuggestedReviewerFilter,
-  );
-  const markSuggestedReviewerFilterInitialized = useInboxSignalsFilterStore(
-    (s) => s.markSuggestedReviewerFilterInitialized,
+  const seedSuggestedReviewerFilterWithCurrentUser = useInboxSignalsFilterStore(
+    (s) => s.seedSuggestedReviewerFilterWithCurrentUser,
   );
 
   // ── Current user (seeds reviewer filter on first inbox visit) ───────────
@@ -86,19 +80,9 @@ export function InboxSignalsTab() {
   });
 
   useEffect(() => {
-    if (hasInitializedSuggestedReviewerFilter) return;
     if (!currentUser?.uuid) return;
-    if (suggestedReviewerFilter.length === 0) {
-      setSuggestedReviewerFilter([currentUser.uuid]);
-    }
-    markSuggestedReviewerFilterInitialized();
-  }, [
-    hasInitializedSuggestedReviewerFilter,
-    currentUser?.uuid,
-    suggestedReviewerFilter.length,
-    setSuggestedReviewerFilter,
-    markSuggestedReviewerFilterInitialized,
-  ]);
+    seedSuggestedReviewerFilterWithCurrentUser(currentUser.uuid);
+  }, [currentUser?.uuid, seedSuggestedReviewerFilterWithCurrentUser]);
 
   // ── GitHub integration ───────────────────────────────────────────────
   const { hasGithubIntegration } = useRepositoryIntegration();

apps/code/src/renderer/features/inbox/stores/inboxSignalsFilterStore.test.ts

@@ -18,6 +18,7 @@ describe("inboxSignalsFilterStore", () => {
       ],
       sourceProductFilter: [],
       suggestedReviewerFilter: [],
+      hasInitializedSuggestedReviewerFilter: false,
     });
   });
 
@@ -129,6 +130,45 @@ describe("inboxSignalsFilterStore", () => {
     expect(state.suggestedReviewerFilter).toEqual([]);
   });
 
+  it("seedSuggestedReviewerFilterWithCurrentUser seeds when empty and uninitialized", () => {
+    useInboxSignalsFilterStore
+      .getState()
+      .seedSuggestedReviewerFilterWithCurrentUser("me-uuid");
+
+    const state = useInboxSignalsFilterStore.getState();
+    expect(state.suggestedReviewerFilter).toEqual(["me-uuid"]);
+    expect(state.hasInitializedSuggestedReviewerFilter).toBe(true);
+  });
+
+  it("seedSuggestedReviewerFilterWithCurrentUser is a no-op once initialized", () => {
+    useInboxSignalsFilterStore
+      .getState()
+      .seedSuggestedReviewerFilterWithCurrentUser("me-uuid");
+    useInboxSignalsFilterStore.getState().setSuggestedReviewerFilter([]);
+
+    useInboxSignalsFilterStore
+      .getState()
+      .seedSuggestedReviewerFilterWithCurrentUser("me-uuid");
+
+    expect(
+      useInboxSignalsFilterStore.getState().suggestedReviewerFilter,
+    ).toEqual([]);
+  });
+
+  it("seedSuggestedReviewerFilterWithCurrentUser preserves an existing non-empty filter", () => {
+    useInboxSignalsFilterStore
+      .getState()
+      .setSuggestedReviewerFilter(["someone-else"]);
+
+    useInboxSignalsFilterStore
+      .getState()
+      .seedSuggestedReviewerFilterWithCurrentUser("me-uuid");
+
+    const state = useInboxSignalsFilterStore.getState();
+    expect(state.suggestedReviewerFilter).toEqual(["someone-else"]);
+    expect(state.hasInitializedSuggestedReviewerFilter).toBe(true);
+  });
+
   it("resetFilters preserves sort preferences", () => {
     useInboxSignalsFilterStore.getState().setSort("created_at", "asc");
 

apps/code/src/renderer/features/inbox/stores/inboxSignalsFilterStore.ts

@@ -51,7 +51,12 @@ interface InboxSignalsFilterActions {
   toggleSourceProduct: (source: SourceProduct) => void;
   toggleSuggestedReviewer: (reviewerUuid: string) => void;
   setSuggestedReviewerFilter: (reviewerUuids: string[]) => void;
-  markSuggestedReviewerFilterInitialized: () => void;
+  /**
+   * Seed the reviewer filter with the current user on first inbox visit.
+   * No-op if already initialized, or if the user has actively chosen reviewers.
+   * Always flips the initialized flag so we don't override later user choices.
+   */
+  seedSuggestedReviewerFilterWithCurrentUser: (currentUserUuid: string) => void;
   /** Reset all filters when a deep link arrives so the linked report isn't hidden. */
   resetFilters: () => void;
 }
@@ -100,8 +105,17 @@ export const useInboxSignalsFilterStore = create<InboxSignalsFilterStore>()(
         set({
           suggestedReviewerFilter: Array.from(new Set(reviewerUuids)),
         }),
-      markSuggestedReviewerFilterInitialized: () =>
-        set({ hasInitializedSuggestedReviewerFilter: true }),
+      seedSuggestedReviewerFilterWithCurrentUser: (currentUserUuid) =>
+        set((state) => {
+          if (state.hasInitializedSuggestedReviewerFilter) return {};
+          return {
+            hasInitializedSuggestedReviewerFilter: true,
+            suggestedReviewerFilter:
+              state.suggestedReviewerFilter.length === 0
+                ? [currentUserUuid]
+                : state.suggestedReviewerFilter,
+          };
+        }),
       resetFilters: () =>
         set({
           searchQuery: "",