feat(workspace): add last_user_message_at field for better activity tracking#2181
Open
jonathanlab wants to merge 1 commit into
Open
feat(workspace): add last_user_message_at field for better activity tracking#2181jonathanlab wants to merge 1 commit into
jonathanlab wants to merge 1 commit into
Conversation
…racking Generated-By: PostHog Code Task-Id: bd0d1144-27e7-4128-8a7a-13f8fa183458
Contributor
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
117
to
123
| return { | ||
| timestamps, | ||
| isLoading, | ||
| markAsViewed, | ||
| markActivity, | ||
| getLastViewedAt, | ||
| getLastActivityAt, | ||
| markAsViewed: markViewedMutation.mutate, | ||
| markActivity: markActivityMutation.mutate, | ||
| markUserSend: markUserSendMutation.mutate, | ||
| }; |
Contributor
There was a problem hiding this comment.
markActivity return value is now dead code — no caller destructures it from useTaskViewed(). All usages in React components (useSessionCallbacks, SidebarMenu, CommandCenterView, useTaskDeepLink) destructure only markAsViewed, markUserSend, or timestamps. The only live path for markActivity is taskViewedApi.markActivity (the non-React imperative API), which is unrelated to this hook return. Removing it keeps the API surface aligned with simplicity rule 4.
Suggested change
| return { | |
| timestamps, | |
| isLoading, | |
| markAsViewed, | |
| markActivity, | |
| getLastViewedAt, | |
| getLastActivityAt, | |
| markAsViewed: markViewedMutation.mutate, | |
| markActivity: markActivityMutation.mutate, | |
| markUserSend: markUserSendMutation.mutate, | |
| }; | |
| return { | |
| timestamps, | |
| isLoading, | |
| markAsViewed: markViewedMutation.mutate, | |
| markUserSend: markUserSendMutation.mutate, | |
| }; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sidebar/hooks/useTaskViewed.ts
Line: 117-123
Comment:
The `markActivity` return value is now dead code — no caller destructures it from `useTaskViewed()`. All usages in React components (`useSessionCallbacks`, `SidebarMenu`, `CommandCenterView`, `useTaskDeepLink`) destructure only `markAsViewed`, `markUserSend`, or `timestamps`. The only live path for `markActivity` is `taskViewedApi.markActivity` (the non-React imperative API), which is unrelated to this hook return. Removing it keeps the API surface aligned with simplicity rule 4.
```suggestion
return {
timestamps,
isLoading,
markAsViewed: markViewedMutation.mutate,
markUserSend: markUserSendMutation.mutate,
};
```
How can I resolve this? If you propose a fix, please make it concise.
k11kirky
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: previously we'd based the chronological list on a bunch of stuff:
this felt quite inconsistent, and there were some bugs with old threads moving up in the chronological sort if you opened them without doing anything.
let's simplify!
Added a new
last_user_message_atcolumn to theworkspacestable to track when users last sent messages, enabling proper sorting in the sidebar. Existing data is migrated from thelast_activity_atcolumn.Created with PostHog Code