Commit dba3308
fix(admin): admit iceberg fields in warehouse PUT strict-decode (#557)
PR #554 added the Iceberg fields to ManagedWarehouse (configstore) and
to the upsert column allowlist, but missed the strict-decode struct
managedWarehouseRequest that gates which top-level keys a PUT body may
carry. The doc comment on that struct literally warns: "If you add a
field here without a matching tag on ManagedWarehouse, strict decode
will accept it and the merge will silently drop it."
Without this fix, `PUT /orgs/<id>/warehouse` with `{"iceberg":{...}}`
returns 400 "unknown field iceberg" — making it impossible to enable
Iceberg via admin API on existing warehouses (the whole reason the
drift correction in #555 exists).
Adds the matching test mirroring TestPutWarehouseDisablesPgBouncerWhenSetToFalse.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 2acc015 commit dba3308
2 files changed
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
523 | 523 | | |
524 | 524 | | |
525 | 525 | | |
| 526 | + | |
526 | 527 | | |
527 | 528 | | |
528 | 529 | | |
| |||
536 | 537 | | |
537 | 538 | | |
538 | 539 | | |
| 540 | + | |
| 541 | + | |
539 | 542 | | |
540 | 543 | | |
541 | 544 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
532 | 532 | | |
533 | 533 | | |
534 | 534 | | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
535 | 554 | | |
536 | 555 | | |
537 | 556 | | |
| |||
0 commit comments