active_feature_flags event should filter non active flags (#41)

Author: marandaneto

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Next
 
-- Upsert flags when loading feature flags with computed errors ([#38](https://github.com/PostHog/posthog-android/pull/38)) 
+- Upsert flags when loading feature flags with computed errors ([#38](https://github.com/PostHog/posthog-android/pull/38))
+- `$active_feature_flags` event should filter non active flags ([#41](https://github.com/PostHog/posthog-android/pull/41))
 
 ## 3.0.0-alpha.5 - 2023-10-04
 

posthog/src/main/java/com/posthog/PostHog.kt

@@ -209,7 +209,13 @@ public class PostHog private constructor(
                         val keys = mutableListOf<String>()
                         for (entry in it.entries) {
                             props["\$feature/${entry.key}"] = entry.value
-                            keys.add(entry.key)
+
+                            // only add active feature flags
+                            val active = entry.value as? Boolean ?: true
+
+                            if (active) {
+                                keys.add(entry.key)
+                            }
                         }
                         props["\$active_feature_flags"] = keys
                     }

posthog/src/test/java/com/posthog/PostHogTest.kt

@@ -216,6 +216,9 @@ internal class PostHogTest {
 
     @Test
     fun `getFeatureFlag captures feature flag event if enabled`() {
+        val file = File("src/test/resources/json/basic-decide-with-non-active-flags.json")
+        val responseDecideApi = file.readText()
+
         val http = mockHttp(
             response =
             MockResponse()
@@ -237,6 +240,8 @@ internal class PostHogTest {
         http.takeRequest()
 
         assertTrue(sut.getFeatureFlag("4535-funnel-bar-viz") as Boolean)
+        assertFalse(sut.getFeatureFlag("IAmInactive") as Boolean)
+        assertEquals("SplashV2", sut.getFeatureFlag("splashScreenName") as String)
 
         queueExecutor.shutdownAndAwaitTermination()
 
@@ -250,12 +255,15 @@ internal class PostHogTest {
         assertNotNull(theEvent.timestamp)
         assertNotNull(theEvent.uuid)
 
-        // {$feature/4535-funnel-bar-viz=true, $active_feature_flags=[4535-funnel-bar-viz], $feature_flag=4535-funnel-bar-viz, $feature_flag_response=true}
         assertEquals(true, theEvent.properties!!["\$feature/4535-funnel-bar-viz"])
+        assertEquals(false, theEvent.properties!!["\$feature/IAmInactive"])
+        assertEquals("SplashV2", theEvent.properties!!["\$feature/splashScreenName"])
 
         @Suppress("UNCHECKED_CAST")
         val theFlags = theEvent.properties!!["\$active_feature_flags"] as List<String>
-        assertEquals("4535-funnel-bar-viz", theFlags[0])
+        assertTrue(theFlags.contains("4535-funnel-bar-viz"))
+        assertTrue(theFlags.contains("splashScreenName"))
+        assertFalse(theFlags.contains("IAmInactive"))
 
         assertEquals("4535-funnel-bar-viz", theEvent.properties!!["\$feature_flag"])
         assertEquals(true, theEvent.properties!!["\$feature_flag_response"])

posthog/src/test/resources/json/basic-decide-with-non-active-flags.json

@@ -0,0 +1,33 @@
+{
+  "autocaptureExceptions": false,
+  "toolbarParams": {},
+  "errorsWhileComputingFlags": false,
+  "capturePerformance": true,
+  "autocapture_opt_out": false,
+  "isAuthenticated": false,
+  "supportedCompression": [
+    "gzip",
+    "gzip-js"
+  ],
+  "config": {
+    "enable_collect_everything": true
+  },
+  "featureFlagPayloads": {
+    "thePayload": true
+  },
+  "featureFlags": {
+    "4535-funnel-bar-viz": true,
+    "IAmInactive": false,
+    "splashScreenName": "SplashV2"
+  },
+  "sessionRecording": false,
+  "siteApps": [
+    {
+      "id": 21039.0,
+      "url": "/site_app/21039/EOsOSePYNyTzHkZ3f4mjrjUap8Hy8o2vUTAc6v1ZMFP/576ac89bc8aed72a21d9b19221c2c626/"
+    }
+  ],
+  "editorParams": {
+
+  }
+}