fix: restore full session replay state on in-session re-arm

reevaluateSessionReplayFromCachedConfig() only restored
sessionReplayFlagActive, leaving consoleLogRecordingEnabled (zeroed by
reset()) off until an app restart. Reuse processSessionRecordingConfig on
the cached map so the re-arm restores the full recording state (console
logs, endpoint, sample rate, triggers, duration) the way /config did.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: turnipdabeets

posthog/src/main/java/com/posthog/internal/PostHogRemoteConfig.kt

@@ -398,15 +398,15 @@ public class PostHogRemoteConfig(
         return milliseconds
     }
 
-    // Re-evaluates sessionReplayFlagActive from the cached config (survives reset) + current flags.
+    // Restores the full recording config from cache (survives reset), re-evaluated against current flags.
     private fun reevaluateSessionReplayFromCachedConfig() {
         @Suppress("UNCHECKED_CAST")
         val recordingConfig = config.cachePreferences?.getValue(SESSION_REPLAY) as? Map<String, Any?>
         if (recordingConfig == null) {
             config.logger.log("No cached session replay config to re-evaluate; replay stays disabled.")
             return
         }
-        sessionReplayFlagActive = isRecordingActive(this.featureFlags ?: mapOf(), recordingConfig)
+        processSessionRecordingConfig(recordingConfig)
     }
 
     private fun processSessionRecordingConfig(sessionRecording: Any?) {
@@ -648,8 +648,7 @@ public class PostHogRemoteConfig(
                         this.featureFlagPayloads = normalizedPayloads
                     }
 
-                    // /flags omits sessionRecording (null) -> re-evaluate from the cached config instead of
-                    // clobbering it. An explicit value (e.g. Boolean false when remotely disabled) is still honored.
+                    // /flags usually omits sessionRecording; re-arm from cached config instead of clobbering it.
                     val responseSessionRecording = it.sessionRecording
                     if (responseSessionRecording != null) {
                         processSessionRecordingConfig(responseSessionRecording)

posthog/src/test/java/com/posthog/internal/PostHogRemoteConfigTest.kt

@@ -146,14 +146,46 @@ internal class PostHogRemoteConfigTest {
         )
         assertTrue(secondLatch.await(5, TimeUnit.SECONDS), "second flags load should complete")
 
-        // Explicit false turns replay off and drops the cached config.
+        // A response that explicitly carries false turns replay off and drops the cached config.
         assertFalse(sut.isSessionReplayFlagActive())
         assertNull(preferences.getValue(SESSION_REPLAY))
 
         sut.clear()
         http.shutdown()
     }
 
+    @Test
+    fun `re-arm on a flags reload restores consoleLogRecordingEnabled from the cached config`() {
+        preferences.setValue(SESSION_REPLAY, mapOf("consoleLogRecordingEnabled" to true))
+
+        // /flags omits sessionRecording, so the reload must re-arm from the cached config.
+        val withoutRecording = File("src/test/resources/json/basic-flags-no-session-recording.json").readText()
+        val http = mockHttp(response = MockResponse().setBody(withoutRecording))
+        val url = http.url("/")
+
+        val sut = getSut(host = url.toString())
+
+        assertTrue(sut.isConsoleLogRecordingEnabled())
+
+        sut.clear()
+        assertFalse(sut.isConsoleLogRecordingEnabled())
+
+        val latch = CountDownLatch(1)
+        sut.loadFeatureFlags(
+            "my_identify",
+            anonymousId = "anonId",
+            emptyMap(),
+            onFeatureFlags = PostHogOnFeatureFlags { latch.countDown() },
+        )
+        assertTrue(latch.await(5, TimeUnit.SECONDS), "flags load should complete")
+
+        // Restored from cache, not left clobbered to false.
+        assertTrue(sut.isConsoleLogRecordingEnabled())
+
+        sut.clear()
+        http.shutdown()
+    }
+
     @Test
     fun `flags reload without a cached recording config leaves replay inactive`() {
         val withoutRecording = File("src/test/resources/json/basic-flags-no-session-recording.json").readText()