Skip to content

Commit 082e416

Browse files
authored
Merge pull request #89 from PostHog/fix/semgrep-shell-injection
fix(ci): prevent shell injection in release workflow
2 parents aef75c4 + a248aa7 commit 082e416

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,14 @@ jobs:
142142
id: commit-release
143143
env:
144144
GITHUB_TOKEN: ${{ steps.releaser.outputs.token }}
145+
NEW_VERSION: ${{ steps.sampo-release.outputs.new_version }}
145146
run: |
146147
git add -A
147148
if git diff --staged --quiet; then
148149
echo "No changes to commit"
149150
echo "committed=false" >> "$GITHUB_OUTPUT"
150151
else
151-
git commit -m "chore: Release v${{ steps.sampo-release.outputs.new_version }}"
152+
git commit -m "chore: Release v${NEW_VERSION}"
152153
git push origin master
153154
echo "committed=true" >> "$GITHUB_OUTPUT"
154155
fi
@@ -168,7 +169,8 @@ jobs:
168169
if: steps.commit-release.outputs.committed == 'true'
169170
env:
170171
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
171-
run: gh release create "v${{ steps.sampo-release.outputs.new_version }}" --generate-notes
172+
NEW_VERSION: ${{ steps.sampo-release.outputs.new_version }}
173+
run: gh release create "v${NEW_VERSION}" --generate-notes
172174

173175
# Notify in case of a failure
174176
- name: Send failure event to PostHog

0 commit comments

Comments
 (0)