feat: Enjoy the benefits of /decide?v=4 (#1838)

* Enjoy the benefits of `/decide?v=4`

This is a follow-up to #1837 where we added support for `/decide?v=4` in a backwards compatible fashion, but still made requests to `/decide?v=3`

With this change, we should get more useful debug information in `$feature_flag_called` events.

* Add new patch to changelog

* Import `from-entries` for IE11

Author: haacked

playwright/session-recording/session-recording-network-recorder.spec.ts

@@ -134,7 +134,7 @@ test.beforeEach(async ({ context }) => {
                               // webkit isn't capturing this failed request in the pre-wrapped fetch performance observer records
                               // [/https:\/\/localhost:\d+\/array\/test%20token\/config.js/, 'script'],
                               [
-                                  /https:\/\/localhost:\d+\/decide\/\?v=3&ip=1&_=\d+&ver=1\.\d\d\d\.\d+&compression=base64/,
+                                  /https:\/\/localhost:\d+\/decide\/\?v=4&ip=1&_=\d+&ver=1\.\d\d\d\.\d+&compression=base64/,
                                   'fetch',
                               ],
                               // webkit isn't capturing this failed request in the pre-wrapped fetch performance observer records
@@ -158,7 +158,7 @@ test.beforeEach(async ({ context }) => {
                               [/https:\/\/localhost:\d+\/static\/array.js/, 'script'],
                               [/https:\/\/localhost:\d+\/array\/test%20token\/config.js/, 'script'],
                               [
-                                  /https:\/\/localhost:\d+\/decide\/\?v=3&ip=1&_=\d+&ver=1\.\d\d\d\.\d+&compression=base64/,
+                                  /https:\/\/localhost:\d+\/decide\/\?v=4&ip=1&_=\d+&ver=1\.\d\d\d\.\d+&compression=base64/,
                                   'fetch',
                               ],
                               [

src/__tests__/posthog-core.loaded.test.ts

@@ -41,7 +41,7 @@ describe('loaded() with flags', () => {
             expect(instance._send_request).toHaveBeenCalledTimes(1)
 
             expect(instance._send_request.mock.calls[0][0]).toMatchObject({
-                url: 'https://us.i.posthog.com/decide/?v=3',
+                url: 'https://us.i.posthog.com/decide/?v=4',
                 data: {
                     groups: { org: 'bazinga' },
                 },
@@ -64,7 +64,7 @@ describe('loaded() with flags', () => {
             expect(instance._send_request).toHaveBeenCalledTimes(1)
 
             expect(instance._send_request.mock.calls[0][0]).toMatchObject({
-                url: 'https://us.i.posthog.com/decide/?v=3',
+                url: 'https://us.i.posthog.com/decide/?v=4',
                 data: {
                     groups: { org: 'bazinga' },
                 },
@@ -77,7 +77,7 @@ describe('loaded() with flags', () => {
             expect(instance._send_request).toHaveBeenCalledTimes(2)
 
             expect(instance._send_request.mock.calls[1][0]).toMatchObject({
-                url: 'https://us.i.posthog.com/decide/?v=3',
+                url: 'https://us.i.posthog.com/decide/?v=4',
                 data: {
                     groups: { org: 'bazinga2' },
                 },

src/__tests__/posthog-core.ts

@@ -1219,7 +1219,7 @@ describe('posthog core', () => {
                 })
 
                 expect(sendRequestMock.mock.calls[0][0]).toMatchObject({
-                    url: 'http://localhost/decide/?v=3',
+                    url: 'http://localhost/decide/?v=4',
                 })
             })
 

src/__tests__/utils/request-router.test.ts

@@ -58,7 +58,7 @@ describe('request-router', () => {
         ['  https://app.posthog.com       ', 'https://us.i.posthog.com/'],
         ['https://example.com/', 'https://example.com/'],
     ])('should sanitize the api_host values for "%s"', (apiHost, expected) => {
-        expect(router(apiHost).endpointFor('api', '/decide?v=3')).toEqual(`${expected}decide?v=3`)
+        expect(router(apiHost).endpointFor('api', '/decide?v=4')).toEqual(`${expected}decide?v=4`)
     })
 
     it('should use the ui_host if provided', () => {

src/entrypoints/array.full.es5.ts

@@ -5,6 +5,8 @@
 // it doesn't include recorder which doesn't support IE11,
 // and it doesn't include web-vitals which doesn't support IE11
 
+import 'core-js/features/object/from-entries'
+
 import './surveys'
 import './exception-autocapture'
 import './tracing-headers'

src/posthog-featureflags.ts

@@ -393,7 +393,7 @@ export class PostHogFeatureFlags {
         this._requestInFlight = true
         this.instance._send_request({
             method: 'POST',
-            url: this.instance.requestRouter.endpointFor('api', '/decide/?v=3'),
+            url: this.instance.requestRouter.endpointFor('api', '/decide/?v=4'),
             data,
             compression: this.instance.config.disable_compression ? undefined : Compression.Base64,
             timeout: this.instance.config.feature_flag_request_timeout_ms,
@@ -557,7 +557,7 @@ export class PostHogFeatureFlags {
         const token = this.instance.config.token
         this.instance._send_request({
             method: 'POST',
-            url: this.instance.requestRouter.endpointFor('api', '/decide/?v=3'),
+            url: this.instance.requestRouter.endpointFor('api', '/decide/?v=4'),
             data: {
                 distinct_id: this.instance.get_distinct_id(),
                 token,