Remove getSessionProps

Author: robbie-c

src/__tests__/posthog-core.ts

@@ -529,11 +529,13 @@ describe('posthog core', () => {
             )
 
             posthog.persistence.get_initial_props = () => ({ initial: 'prop' })
+            posthog.sessionPropsManager.getSetOnceInitialSessionPropsProps = () => ({ session: 'prop' })
             posthog.persistence.props[ENABLE_PERSON_PROCESSING] = true // person processing is needed for $set_once
             expect(posthog._calculate_set_once_properties({ key: 'prop' })).toEqual({
                 event_name: '$set_once',
                 token: undefined,
                 initial: 'prop',
+                session: 'prop',
                 key: 'prop',
             })
         })

src/__tests__/session-props.test.ts

@@ -117,11 +117,11 @@ describe('Session Props Manager', () => {
         }
 
         // act
-        const properties = sessionPropsManager.getSessionProps()
+        const properties = sessionPropsManager.getSetOnceInitialSessionPropsProps()
 
         //assert
         expect(properties).toEqual({
-            $client_session_initial_utm_source: 'some-utm-source',
+            utm_source: 'some-utm-source',
         })
     })
 })

src/session-props.ts

@@ -11,8 +11,6 @@ import type { SessionIdManager } from './sessionid'
 import type { PostHogPersistence } from './posthog-persistence'
 import { CLIENT_SESSION_PROPS } from './constants'
 import type { PostHog } from './posthog-core'
-import { each } from './utils'
-import { stripLeadingDollar } from './utils/string-utils'
 
 interface LegacySessionSourceProps {
     initialPathName: string
@@ -80,10 +78,7 @@ export class SessionPropsManager {
         this._persistence.register({ [CLIENT_SESSION_PROPS]: newProps })
     }
 
-    /**
-     * Return all available props. Might want to be filtered depending on the use case.
-     */
-    _props() {
+    getSetOnceInitialSessionPropsProps() {
         const p = this._getStored()?.props
         if (!p) {
             return {}
@@ -102,16 +97,4 @@ export class SessionPropsManager {
             }
         }
     }
-
-    getSessionProps() {
-        const result: Record<string, any> = {}
-        const p = this._props()
-        each(p, function (v, k) {
-            result['$client_session_' + stripLeadingDollar(k)] = v
-        })
-    }
-
-    getSetOnceInitialSessionPropsProps() {
-        return this._props()
-    }
 }