Skip to content

Commit cca8f5a

Browse files
authored
feat: Screen dimensions and UA as person property (#1840)
* Screen dimensions as person property * Fix tests
1 parent 86f5a76 commit cca8f5a

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts

+5
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,13 @@ describe('setAllPersonPropertiesForFlags', () => {
6161
"$device_type": "Mobile",
6262
"$os": "Android",
6363
"$os_version": "4.4.0",
64+
"$raw_user_agent": "Mozilla/5.0 (Android 4.4; Mobile; rv:41.0) Gecko/41.0 Firefox/41.0",
6465
"$referrer": "https://referrer.com",
6566
"$referring_domain": "referrer.com",
67+
"$screen_height": 0,
68+
"$screen_width": 0,
69+
"$viewport_height": 768,
70+
"$viewport_width": 1024,
6671
"_kx": null,
6772
"dclid": null,
6873
"fbclid": null,

src/utils/event-utils.ts

+5
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ export const EVENT_TO_PERSON_PROPERTIES = [
6161
'$os_version',
6262
'$referring_domain',
6363
'$referrer',
64+
'$screen_height',
65+
'$screen_width',
66+
'$viewport_height',
67+
'$viewport_width',
68+
'$raw_user_agent',
6469
]
6570

6671
export const MASKED = '<masked>'

0 commit comments

Comments
 (0)