From dd4683f546f369022e4ac8153e73ee908e71bce3 Mon Sep 17 00:00:00 2001 From: Robbie Coomber Date: Thu, 20 Mar 2025 14:33:21 +0000 Subject: [PATCH 1/2] Screen dimensions as person property --- src/utils/event-utils.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/utils/event-utils.ts b/src/utils/event-utils.ts index 707fe8fdb..083fc06bf 100644 --- a/src/utils/event-utils.ts +++ b/src/utils/event-utils.ts @@ -61,6 +61,10 @@ export const EVENT_TO_PERSON_PROPERTIES = [ '$os_version', '$referring_domain', '$referrer', + '$screen_height', + '$screen_width', + '$viewport_height', + '$viewport_width', ] export const MASKED = '' From dcd44031927582b359b8b6993fe82052f3f9992d Mon Sep 17 00:00:00 2001 From: Robbie Coomber Date: Thu, 20 Mar 2025 14:57:46 +0000 Subject: [PATCH 2/2] Fix tests --- ...PersonProfilePropertiesAsPersonPropertiesForFlags.test.ts | 5 +++++ src/utils/event-utils.ts | 1 + 2 files changed, 6 insertions(+) diff --git a/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts b/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts index 6169d9387..9488d62a2 100644 --- a/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts +++ b/src/__tests__/customizations/setAllPersonProfilePropertiesAsPersonPropertiesForFlags.test.ts @@ -61,8 +61,13 @@ describe('setAllPersonPropertiesForFlags', () => { "$device_type": "Mobile", "$os": "Android", "$os_version": "4.4.0", + "$raw_user_agent": "Mozilla/5.0 (Android 4.4; Mobile; rv:41.0) Gecko/41.0 Firefox/41.0", "$referrer": "https://referrer.com", "$referring_domain": "referrer.com", + "$screen_height": 0, + "$screen_width": 0, + "$viewport_height": 768, + "$viewport_width": 1024, "_kx": null, "dclid": null, "fbclid": null, diff --git a/src/utils/event-utils.ts b/src/utils/event-utils.ts index 083fc06bf..1d670eff1 100644 --- a/src/utils/event-utils.ts +++ b/src/utils/event-utils.ts @@ -65,6 +65,7 @@ export const EVENT_TO_PERSON_PROPERTIES = [ '$screen_width', '$viewport_height', '$viewport_width', + '$raw_user_agent', ] export const MASKED = ''