revert(survey): drop the three iteration-tracking computed fields

Walking back the additive part of this PR. Exposing current_iteration,
current_iteration_start_date, and iteration_start_dates_json triggered a
"Provider produced inconsistent result after apply" error in
TestSurvey_ClearNumericLimits step 2: PostHog returns
iteration_start_dates: [] (empty array) for non-recurring surveys, which
jsonStringValue serialises as "[]", but the plan held null carried over by
UseStateForUnknown.

Reconciling that empty-array-vs-null mismatch is doable but adds non-trivial
complexity (custom plan modifier, or normalising "[]" to null in the mapper)
for what is purely cosmetic state — these fields aren't load-bearing for
clearing or for any user-facing flow. Simpler to keep the surface area
matching the original PR and revisit as a follow-up if anyone actually wants
to read iteration progress through Terraform state.

Author: vdekrijger

docs/resources/survey.md

@@ -99,11 +99,8 @@ resource "posthog_survey" "feature_feedback" {
 
 - `created_at` (String) RFC3339 creation timestamp of the survey.
 - `created_by_json` (String) JSON object describing the survey creator.
-- `current_iteration` (Number) Current iteration index for `recurring` surveys. Read-only.
-- `current_iteration_start_date` (String) RFC3339 start date of the current iteration. Read-only.
 - `id` (String) UUID of the survey.
 - `internal_targeting_flag_json` (String) JSON object describing the internal targeting feature flag returned by the API.
-- `iteration_start_dates_json` (String) JSON array of RFC3339 start dates for past and current iterations. Read-only.
 - `linked_flag_json` (String) JSON object describing the linked feature flag returned by the API.
 - `targeting_flag_json` (String) JSON object describing the targeting feature flag returned by the API.
 

internal/resource/survey.go

@@ -10,7 +10,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/boolplanmodifier"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -68,9 +67,6 @@ type SurveyTFModel struct {
 	LinkedFlagJSON               types.String `tfsdk:"linked_flag_json"`
 	TargetingFlagJSON            types.String `tfsdk:"targeting_flag_json"`
 	InternalTargetingFlagJSON    types.String `tfsdk:"internal_targeting_flag_json"`
-	CurrentIteration             types.Int64  `tfsdk:"current_iteration"`
-	CurrentIterationStartDate    types.String `tfsdk:"current_iteration_start_date"`
-	IterationStartDatesJSON      types.String `tfsdk:"iteration_start_dates_json"`
 }
 
 type SurveyOps struct{}
@@ -244,27 +240,6 @@ func (o SurveyOps) Schema() schema.Schema {
 				Computed:            true,
 				MarkdownDescription: "JSON object describing the internal targeting feature flag returned by the API.",
 			},
-			"current_iteration": schema.Int64Attribute{
-				Computed:            true,
-				MarkdownDescription: "Current iteration index for `recurring` surveys. Read-only.",
-				PlanModifiers: []planmodifier.Int64{
-					int64planmodifier.UseStateForUnknown(),
-				},
-			},
-			"current_iteration_start_date": schema.StringAttribute{
-				Computed:            true,
-				MarkdownDescription: "RFC3339 start date of the current iteration. Read-only.",
-				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.UseStateForUnknown(),
-				},
-			},
-			"iteration_start_dates_json": schema.StringAttribute{
-				Computed:            true,
-				MarkdownDescription: "JSON array of RFC3339 start dates for past and current iterations. Read-only.",
-				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.UseStateForUnknown(),
-				},
-			},
 		},
 	}
 }
@@ -491,9 +466,6 @@ func mapSurveyComputedFields(resp httpclient.Survey, model *SurveyTFModel) {
 	model.LinkedFlagJSON = jsonStringValue(resp.LinkedFlag)
 	model.TargetingFlagJSON = jsonStringValue(resp.TargetingFlag)
 	model.InternalTargetingFlagJSON = jsonStringValue(resp.InternalTargetingFlag)
-	model.CurrentIteration = util.PtrToInt64(resp.CurrentIteration)
-	model.CurrentIterationStartDate = core.PtrToStringNullIfEmptyTrimmed(resp.CurrentIterationStartDate)
-	model.IterationStartDatesJSON = jsonStringValue(resp.IterationStartDates)
 }
 
 func applyNormalizedJSONString(apiData interface{}, current string, target *types.String) {

internal/resource/survey_test.go

@@ -244,9 +244,6 @@ func TestSurveyMapResponseToModel(t *testing.T) {
 		ResponsesLimit:               util.Int64Ptr(10),
 		IterationCount:               util.Int64Ptr(2),
 		IterationFrequencyDays:       util.Int64Ptr(7),
-		IterationStartDates:          []interface{}{testSurveyStartDate, testSurveySamplingStartDate},
-		CurrentIteration:             util.Int64Ptr(1),
-		CurrentIterationStartDate:    util.StringPtr(testSurveyStartDate),
 		ResponseSamplingStartDate:    util.StringPtr(testSurveySamplingStartDate),
 		ResponseSamplingIntervalType: util.StringPtr("week"),
 		ResponseSamplingInterval:     util.Int64Ptr(2),
@@ -292,9 +289,6 @@ func TestSurveyMapResponseToModel(t *testing.T) {
 	assert.JSONEq(t, `{"id":11}`, model.LinkedFlagJSON.ValueString())
 	assert.JSONEq(t, `{"id":12}`, model.TargetingFlagJSON.ValueString())
 	assert.JSONEq(t, `{"id":13}`, model.InternalTargetingFlagJSON.ValueString())
-	assert.Equal(t, int64(1), model.CurrentIteration.ValueInt64())
-	assert.Equal(t, testSurveyStartDate, model.CurrentIterationStartDate.ValueString())
-	assert.JSONEq(t, `["2026-04-20T00:00:00Z","2026-04-22T00:00:00Z"]`, model.IterationStartDatesJSON.ValueString())
 }
 
 func TestSurveyCRUDWrapperMethods(t *testing.T) {