Skip to content

Commit eef174a

Browse files
authored
Merge pull request #17291 from rgacogne/ddist-document-api-read-write-flush
dnsdist: Document that flushing the cache is allowed in read-only mode
2 parents 61a0977 + 1cb2a6e commit eef174a

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

pdns/dnsdistdist/dnsdist-settings-definitions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ webserver:
469469
- name: "api_read_write"
470470
type: "bool"
471471
default: "false"
472-
description: "Allow modifications via the API. Optionally saving these changes to disk. Modifications done via the API will not be written to the configuration by default and will not persist after a reload"
472+
description: "Allow modifications of the configuration via the API. Optionally saving these changes to disk. Modifications done via the API will not be written to the configuration by default and will not persist after a reload. Note that flushing the content of the packet cache via DELETE requests is still allowed even if the API is read-only"
473473

474474
console:
475475
description: "Console-related settings"

pdns/dnsdistdist/docs/reference/config.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,11 +404,12 @@ Webserver configuration
404404

405405
.. function:: setAPIWritable(allow [,dir])
406406

407-
Allow modifications via the API.
407+
Allow modifications of the configuration via the API.
408408
Optionally saving these changes to disk.
409-
Modifications done via the API will not be written to the configuration by default and will not persist after a reload
409+
Modifications done via the API will not be written to the configuration by default and will not persist after a reload.
410+
Note that flushing the content of the packet cache via DELETE requests is still allowed even if the API is read-only.
410411

411-
:param bool allow: Set to true to allow modification through the API
412+
:param bool allow: Set to true to allow modification of the configuration through the API
412413
:param str dir: A valid directory where the configuration files will be written by the API.
413414

414415
.. function:: setWebserverConfig(options)

0 commit comments

Comments
 (0)