metrics: Simplify the label for dns and url errors to a single string for lower cardinality and better reproducibility in tests

neilcook · neilcook · commit 658fd0b2b019 · 2025-10-29T12:29:57.000Z
diff --git a/backends/s3/s3.go b/backends/s3/s3.go
@@ -592,11 +592,11 @@ func errorToMetricsLabel(err error) string {
 	}
 	var dnsErr *net.DNSError
 	if errors.As(err, &dnsErr) {
-		return dnsErr.Error()
+		return "DNSError"
 	}
 	var urlErr *url.Error
 	if errors.As(err, &urlErr) {
-		return urlErr.Err.Error()
+		return "URLError"
 	}
 	errRes := minio.ToErrorResponse(err)
 	if errRes.Code != "" {

Original file line number	Diff line number	Diff line change
`@@ -592,11 +592,11 @@ func errorToMetricsLabel(err error) string {`
`592`	`592`	`}`
`593`	`593`	`var dnsErr *net.DNSError`
`594`	`594`	`if errors.As(err, &dnsErr) {`
`595`		`- return dnsErr.Error()`
	`595`	`+ return "DNSError"`
`596`	`596`	`}`
`597`	`597`	`var urlErr *url.Error`
`598`	`598`	`if errors.As(err, &urlErr) {`
`599`		`- return urlErr.Err.Error()`
	`599`	`+ return "URLError"`
`600`	`600`	`}`
`601`	`601`	`errRes := minio.ToErrorResponse(err)`
`602`	`602`	`if errRes.Code != "" {`