Skip to content

Commit 32a418d

Browse files
Release 2.1.5
1 parent 7253472 commit 32a418d

File tree

9 files changed

+18
-11
lines changed

9 files changed

+18
-11
lines changed

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.ge.predix.audit</groupId>
55
<artifactId>audit-sdk</artifactId>
6-
<version>2.1.4</version>
6+
<version>2.1.5</version>
77
<packaging>jar</packaging>
88
<name>audit-sdk</name>
99
<url>http://maven.apache.org</url>

src/main/java/com/ge/predix/audit/sdk/AbstractAuditClientImpl.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import com.ge.predix.eventhub.client.Client;
1212
import com.ge.predix.eventhub.configuration.EventHubConfiguration;
1313
import com.ge.predix.eventhub.configuration.PublishConfiguration;
14+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
1415
import lombok.AccessLevel;
1516
import lombok.Getter;
1617
import lombok.Setter;
@@ -77,7 +78,7 @@ public AbstractAuditClientImpl(AuditConfiguration configuration, TracingHandler
7778
this.automaticTokenRenew = (configuration.getAuthenticationMethod() != AuthenticationMethod.AUTH_TOKEN );
7879

7980
if(configuration.isTraceEnabled()){
80-
tracingExecutor = Executors.newScheduledThreadPool(1);
81+
tracingExecutor = Executors.newScheduledThreadPool(1, new ThreadFactoryBuilder().setNameFormat("AUDIT-AbstractAuditClientImpl-%d").build());
8182
startTracingRepetitive();
8283
}
8384
this.logPrefix = generateLogPrefix(configuration.getAuditZoneId());

src/main/java/com/ge/predix/audit/sdk/AuditClientAsyncImpl.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import com.google.common.collect.Maps;
3535
import com.google.common.collect.Queues;
3636

37+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
3738
import lombok.Getter;
3839
import lombok.Setter;
3940

@@ -81,7 +82,7 @@ public AuditClientAsyncImpl(AuditConfiguration configuration, AuditCallback<T> c
8182
this.queueSize = configuration.getMaxNumberOfEventsInCache();
8283
this.eventQueue = Queues.newLinkedBlockingQueue(queueSize);
8384

84-
retryExecutorService = Executors.newScheduledThreadPool(1);
85+
retryExecutorService = Executors.newScheduledThreadPool(1, new ThreadFactoryBuilder().setNameFormat("AUDIT-AuditClientAsyncImpl-%d").build());
8586
retryExecutorService.scheduleAtFixedRate(
8687
this::handleNotAcceptedEvents, noAckLimit, noAckLimit, TimeUnit.MILLISECONDS);
8788
handleEventHubCallback();

src/main/java/com/ge/predix/audit/sdk/DirectMemoryMonitor.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.ge.predix.audit.sdk.util.CustomLogger;
44
import com.ge.predix.audit.sdk.util.LoggerUtils;
5+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
56
import io.netty.util.internal.PlatformDependent;
67

78
import java.lang.reflect.Field;
@@ -45,7 +46,7 @@ public synchronized void startMeasuringDirectMemory() {
4546
if (!initialized) {
4647
initialized = true;
4748
directMemoryCounter = initDirectMemoryCounter();
48-
executorService = Executors.newSingleThreadScheduledExecutor();
49+
executorService = Executors.newSingleThreadScheduledExecutor(new ThreadFactoryBuilder().setNameFormat("AUDIT-DirectMemoryMonitor-%d").build());
4950
executorService.scheduleAtFixedRate(this::printDirectMemoryCount, 1, 10, TimeUnit.SECONDS);
5051
}
5152
else {

src/main/java/com/ge/predix/audit/sdk/ExponentialReconnectStrategy.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.ge.predix.audit.sdk.util.CustomLogger;
44
import com.ge.predix.audit.sdk.util.LoggerUtils;
5+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
56

67
import java.util.concurrent.Executors;
78
import java.util.concurrent.ScheduledExecutorService;
@@ -32,7 +33,7 @@ public class ExponentialReconnectStrategy implements ReconnectStrategy {
3233

3334
public ExponentialReconnectStrategy(Runnable actionToPerform, String logPrefix) {
3435
this.logPrefix = logPrefix;
35-
threadExecutor = Executors.newSingleThreadScheduledExecutor();
36+
threadExecutor = Executors.newSingleThreadScheduledExecutor(new ThreadFactoryBuilder().setNameFormat("AUDIT-ExponentialReconnectStrategy-%d").build());
3637
curIndex = new AtomicInteger(0);
3738
this.actionToPerform = actionToPerform;
3839
isBetweenIntervals = new AtomicBoolean(false);

src/main/java/com/ge/predix/audit/sdk/message/tracing/TracingMessageSenderImpl.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ protected TracingMessageSenderImpl(String destination, String token, CloseableHt
4646
this.token = token;
4747
this.objectMapper = new ObjectMapper();
4848
this.uriBuilder = new URIBuilder(destination);
49-
this.executor = Executors.newFixedThreadPool(1, new ThreadFactoryBuilder().setNameFormat("TracingMessageSenderImpl-%d").build());
49+
this.executor = Executors.newFixedThreadPool(1, new ThreadFactoryBuilder().setNameFormat("AUDIT-TracingMessageSenderImpl-%d").build());
5050
this.httpClient = closeableHttpClient;
5151
}
5252

src/main/java/com/ge/predix/audit/sdk/routing/RoutingAuditClient.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.ge.predix.audit.sdk.util.LoggerUtils;
2424
import com.google.common.collect.Lists;
2525
import com.google.common.collect.Queues;
26+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
2627
import org.apache.http.impl.client.CloseableHttpClient;
2728
import org.apache.http.impl.client.HttpClientBuilder;
2829

@@ -67,7 +68,7 @@ public RoutingAuditClient(RoutingAuditConfiguration configuration, RoutingAuditC
6768
monitor.startMeasuringDirectMemory();
6869
}
6970
routingAuditPublisher = init(configuration, callback);
70-
executor = Executors.newSingleThreadExecutor();
71+
executor = Executors.newSingleThreadExecutor(new ThreadFactoryBuilder().setNameFormat("AUDIT-RoutingAuditClient-%d").build());
7172
handleEvents();
7273
}
7374

@@ -189,7 +190,7 @@ private RoutingAuditPublisher<T> init(RoutingAuditConfiguration configuration, R
189190
AuditEventsConverter converter = new AuditEventsConverter(new AppNameClient(tokenClient, appNameConfig.getAppNamePrefix()));
190191
//shutdown client
191192
AuditAsyncShutdownHandler<T> shutdownClient = new AuditAsyncShutdownHandler<>(configuration.getTenantAuditConfig(), tokenServiceClient,
192-
Executors.newFixedThreadPool(routingResourceConfig.getNumOfConnections()));
193+
Executors.newFixedThreadPool(routingResourceConfig.getNumOfConnections(), new ThreadFactoryBuilder().setNameFormat("AUDIT-RoutingAuditClient(shutdown)-%d").build()));
193194

194195
//Dedicated tenants cache
195196
ICache<String, AuditAsyncClientHolder<T>> dedicatedClients = new AsyncClientHolderICacheImpl<>(shutdownClient,

src/main/java/com/ge/predix/audit/sdk/routing/cache/impl/AsyncClientHolderICacheImpl.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.ge.predix.audit.sdk.util.LoggerUtils;
1010
import com.google.common.cache.Cache;
1111
import com.google.common.cache.CacheBuilder;
12+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
1213

1314
import java.util.Map;
1415
import java.util.Optional;
@@ -28,7 +29,7 @@ public class AsyncClientHolderICacheImpl<T extends AuditEvent> implements ICache
2829
public AsyncClientHolderICacheImpl(AuditAsyncShutdownHandler<T> shutdownHandler, AuditCacheRefresher<T> refresher,
2930
long connectionLifeTime, int numOfConnections, long refreshPeriod){
3031
tenantClientCache = buildCache(shutdownHandler, connectionLifeTime, numOfConnections);
31-
maintenanceExecutor = new ScheduledThreadPoolExecutor(1);
32+
maintenanceExecutor = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().setNameFormat("AUDIT-AsyncClientHolderICacheImpl-%d").build());
3233
this.shutdownHandler = shutdownHandler;
3334
startCacheRefresh(refresher, refreshPeriod);
3435
}

src/test/java/com/ge/predix/audit/sdk/routing/RoutingAuditClientTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.ge.predix.audit.sdk.message.AuditEnums;
77
import com.ge.predix.audit.sdk.message.AuditEventV2;
88
import com.google.common.collect.Queues;
9+
import com.google.common.util.concurrent.ThreadFactoryBuilder;
910
import org.junit.Test;
1011

1112
import java.util.ArrayList;
@@ -26,7 +27,7 @@
2627
@SuppressWarnings("unchecked")
2728
public class RoutingAuditClientTest {
2829

29-
private ExecutorService executorService = Executors.newFixedThreadPool(1);
30+
private ExecutorService executorService = Executors.newFixedThreadPool(1, new ThreadFactoryBuilder().setNameFormat("AUDIT-RoutingAuditClientTest-%d").build());
3031
private RoutingTestHelper<AuditEventV2> cb = new RoutingTestHelper<>();
3132
private RoutingAuditPublisher<AuditEventV2> publisher = mock(RoutingAuditPublisher.class);
3233
private AtomicReference<AuditClientState> atomicReference = spy(new AtomicReference<>(AuditClientState.CONNECTED));
@@ -121,7 +122,7 @@ public void auditTooManyEventsCauseException() throws InterruptedException {
121122
@Test
122123
public void shouldNotLetAuditWhenStatusIsShutdown() {
123124
routingAuditClient = new RoutingAuditClient<>(Queues.newLinkedBlockingQueue(2),
124-
Executors.newFixedThreadPool(1), publisher, new AtomicReference<>(AuditClientState.SHUTDOWN), cb);
125+
Executors.newFixedThreadPool(1, new ThreadFactoryBuilder().setNameFormat("AUDIT-RoutingAuditClientTest-%d").build()), publisher, new AtomicReference<>(AuditClientState.SHUTDOWN), cb);
125126

126127
assertThatThrownBy(() -> routingAuditClient.audit(AuditEventV2.builder().publisherType(AuditEnums.PublisherType.APP_SERVICE)
127128
.categoryType(AuditEnums.CategoryType.ADMINISTRATIONS)

0 commit comments

Comments
 (0)