Skip to content

chore: Set redirect_path default in function#1833

Merged
jlowin merged 2 commits into
PrefectHQ:mainfrom
ruhulio:ruhul/set-redirect-path-default-in-function
Sep 15, 2025
Merged

chore: Set redirect_path default in function#1833
jlowin merged 2 commits into
PrefectHQ:mainfrom
ruhulio:ruhul/set-redirect-path-default-in-function

Conversation

@ruhulio

@ruhulio ruhulio commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Description

Set redirect_path default in function instead of as a parameter default in OAuthProxy.

This simplifies how the subclasses need to handle redirect_path and creates a single source of truth for the default as well.

Contributors Checklist

  • My change closes #(issue number)
  • I have followed the repository's development workflow
  • I have tested my changes manually and by adding relevant tests
  • I have performed all required documentation updates

Review Checklist

  • I have self-reviewed my changes
  • My Pull Request is ready for review

@marvin-context-protocol marvin-context-protocol Bot added enhancement Improvement to existing functionality. For issues and smaller PR improvements. server Related to FastMCP server implementation or server-side functionality. auth Related to authentication (Bearer, JWT, OAuth, WorkOS) for client or server. labels Sep 15, 2025
@jlowin

jlowin commented Sep 15, 2025

Copy link
Copy Markdown
Member

@ruhulio the windows test failure isn't your fault - it's become flaky in the last day or two.

@jlowin jlowin merged commit 2df8a0f into PrefectHQ:main Sep 15, 2025
3 of 4 checks passed
@ruhulio ruhulio deleted the ruhul/set-redirect-path-default-in-function branch September 15, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth Related to authentication (Bearer, JWT, OAuth, WorkOS) for client or server. enhancement Improvement to existing functionality. For issues and smaller PR improvements. server Related to FastMCP server implementation or server-side functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants