Merge pull request #7 from borlum/dev

Referencing issue #9928 of PrestaShop/PrestaShop

Author: PierreRambaud

VATNumberTaxManager.php

@@ -28,9 +28,37 @@ class VATNumberTaxManager implements TaxManagerInterface
 {
 	public static function isAvailableForThisAddress(Address $address)
 	{
-		return (!empty($address->vat_number)
-			&& $address->id_country != Configuration::get('VATNUMBER_COUNTRY')
-			&& Configuration::get('VATNUMBER_MANAGEMENT')
+		/*
+		HOTFIX
+		
+		For some reason, this check is called 6 times (?)
+
+		1 w. the real address
+		2 w.o. the real address
+
+		1 w. the real address
+		2 w.o. the real address
+
+		=> [1 0 0 1 0 0]
+
+		So we need to filter out the weird calls...
+
+		We do this by caching the correct calls between calls;
+		by creating a static variable, which we save the address to,
+		if it does not contain NULL in some of the other fields.
+		*/
+
+		static $cached_address = NULL;
+
+		if ($address->id_customer != NULL) {
+			$cached_address = $address;
+		}
+
+		// Now, check on the cached address object
+		return (!empty($cached_address->vat_number)
+		    && !empty($cached_address->id_country)
+		    && $cached_address->id_country != Configuration::get('VATNUMBER_COUNTRY')
+		    && Configuration::get('VATNUMBER_MANAGEMENT')
 		);
 	}