Maintenance: bump packages + lint (#103)

* bump packages
* lint files
* Bump again and simplify peerDeps
* update yarn.lock
* rimraf the dist on build
* Commit the package-lock for npm users
* better eslint configuration
* Add eslint-plugin-import and review example imports
* add prettier-plugin-organize-imports
* fix tests + fix a small lint
* eslint FULL 100% fixes

Co-authored-by: Alexandre Decollas <[email protected]>

Author: jokesterfr

.eslintignore

@@ -1 +1,4 @@
-*.js
+index.js
+examples/**/*.js
+dist/
+documentation/

.eslintrc.json

@@ -25,6 +25,7 @@
     "@typescript-eslint/no-empty-interface": "off",
     "@typescript-eslint/ban-types": "off",
     "@typescript-eslint/ban-ts-comment": "off",
+    "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-unused-vars": "warn",
     "@typescript-eslint/no-empty-function": "off",
     "no-mixed-spaces-and-tabs": "off"

.gitignore

@@ -38,5 +38,3 @@ lerna-debug.log*
 
 #Config
 .env
-
-package-lock.json

documentation/injectables/HeroRepository.html

@@ -462,7 +462,7 @@ <h3 id="methods">Methods</h3>
                                         <span class="modifier-icon method fa fa-play ">
                                             <span class="fa fa-"></span>
                                         </span>
-                                    <code>findOneById(id: number)</code>
+                                    <code>findOneById(id: string)</code>
                                 </td>
                             </tr>
 
@@ -513,7 +513,7 @@ <h3 id="methods">Methods</h3>
 
 @Injectable()
 export class HeroRepository {
-  async findOneById(id: number): Promise&lt;Hero&gt; {
+  async findOneById(id: string): Promise&lt;Hero&gt; {
     return new Hero(id);
   }
 

examples/src/heroes/aggregates/hero.aggregate.ts

@@ -1,17 +1,17 @@
+import { EventStoreAggregateRoot } from '../../../../src';
+import { HeroDamagedEnemyEvent } from '../events/impl/hero-damaged-enemy.event';
+import { HeroDropItemEvent } from '../events/impl/hero-drop-item.event';
 import { HeroFoundItemEvent } from '../events/impl/hero-found-item.event';
 import { HeroKilledDragonEvent } from '../events/impl/hero-killed-dragon.event';
-import { HeroDropItemEvent } from '../events/impl/hero-drop-item.event';
-import { HeroDamagedEnemyEvent } from '../events/impl/hero-damaged-enemy.event';
-import { EventStoreAggregateRoot } from '../../../../src';
 
 export class Hero extends EventStoreAggregateRoot {
-  constructor(private readonly id) {
+  constructor(private readonly id: string) {
     super();
     // comment this line to test correlation-id auto-generated stream
     this.streamName = `hero-${id}`;
   }
 
-  damageEnemy(dragonId: string, hitPoint: number) {
+  damageEnemy(dragonId: string, hitPoint: number): Promise<void> {
     return this.apply(
       new HeroDamagedEnemyEvent({
         heroId: this.id,
@@ -22,7 +22,7 @@ export class Hero extends EventStoreAggregateRoot {
     );
   }
 
-  killEnemy(dragonId: string) {
+  killEnemy(dragonId: string): Promise<void> {
     // logic
     return this.apply(
       new HeroKilledDragonEvent({
@@ -32,7 +32,7 @@ export class Hero extends EventStoreAggregateRoot {
     );
   }
 
-  addItem(itemId: string) {
+  addItem(itemId: string): Promise<void> {
     // logic
     return this.apply(
       new HeroFoundItemEvent({
@@ -42,7 +42,7 @@ export class Hero extends EventStoreAggregateRoot {
     );
   }
 
-  dropItem(itemId: string) {
+  dropItem(itemId: string): Promise<void> {
     return this.apply(
       new HeroDropItemEvent({
         heroId: this.id,

examples/src/heroes/commands/handlers/drop-ancient-item.handler.ts

@@ -1,8 +1,8 @@
 import { CommandHandler, ICommandHandler } from '@nestjs/cqrs';
 import * as clc from 'cli-color';
+import { WriteEventBus } from '../../../../../src/';
 import { HeroRepository } from '../../repository/hero.repository';
 import { DropAncientItemCommand } from '../impl/drop-ancient-item.command';
-import { WriteEventBus } from '../../../../../src/';
 
 @CommandHandler(DropAncientItemCommand)
 export class DropAncientItemHandler
@@ -13,11 +13,11 @@ export class DropAncientItemHandler
     private readonly publisher: WriteEventBus,
   ) {}
 
-  async execute(command: DropAncientItemCommand) {
+  async execute(command: DropAncientItemCommand): Promise<void> {
     console.log(clc.yellowBright('Async DropAncientItemCommand...'));
 
     const { heroId, itemId } = command;
-    const hero = await this.repository.findOneById(+heroId);
+    const hero = await this.repository.findOneById(heroId);
     hero.autoCommit = true;
     hero.maxAge = 600; // 10 min
     hero.addPublisher((events, context) =>

examples/src/heroes/commands/handlers/index.ts

@@ -1,4 +1,4 @@
-import { KillDragonHandler } from './kill-dragon.handler';
 import { DropAncientItemHandler } from './drop-ancient-item.handler';
+import { KillDragonHandler } from './kill-dragon.handler';
 
 export const CommandHandlers = [KillDragonHandler, DropAncientItemHandler];

examples/src/heroes/commands/handlers/kill-dragon.handler.ts

@@ -1,10 +1,10 @@
+import * as constants from '@eventstore/db-client/dist/constants';
+import { WriteEventBus } from '@nestjs-geteventstore/cqrs';
 import { CommandHandler, ICommandHandler } from '@nestjs/cqrs';
 import * as clc from 'cli-color';
+import { Hero } from '../../aggregates/hero.aggregate';
 import { HeroRepository } from '../../repository/hero.repository';
 import { KillDragonCommand } from '../impl/kill-dragon.command';
-import { WriteEventBus } from '@nestjs-geteventstore/cqrs';
-import * as constants from '@eventstore/db-client/dist/constants';
-import { Hero } from '../../aggregates/hero.aggregate';
 
 @CommandHandler(KillDragonCommand)
 export class KillDragonHandler implements ICommandHandler<KillDragonCommand> {
@@ -26,7 +26,7 @@ export class KillDragonHandler implements ICommandHandler<KillDragonCommand> {
     //   this.publisher.publishAll.bind(this.publisher),
     // );
     const hero: Hero = (
-      await this.repository.findOneById(+heroId)
+      await this.repository.findOneById(heroId)
     ).addPublisher<WriteEventBus>(this.publisher);
 
     await hero.damageEnemy(dragonId, 2);

examples/src/heroes/event-store-heroes.module.ts

@@ -1,9 +1,12 @@
+import { CqrsEventStoreModule } from '@nestjs-geteventstore/cqrs-event-store.module';
+import { IEventStoreSubsystems } from '@nestjs-geteventstore/event-store/config';
+import { EventStoreConnectionConfig } from '@nestjs-geteventstore/event-store/config/event-store-connection-config';
+import { EventBusConfigType } from '@nestjs-geteventstore/interfaces';
 import { Module } from '@nestjs/common';
 import { TerminusModule } from '@nestjs/terminus';
 import { ContextModule } from 'nestjs-context';
-import { LoggerModule } from 'nestjs-pino-stackdriver/dist';
+import { LoggerModule } from 'nestjs-pino-stackdriver';
 import { resolve } from 'path';
-
 import { CommandHandlers } from './commands/handlers';
 import { EventHandlers } from './events/handlers';
 import { heroesEvents } from './events/impl';
@@ -12,10 +15,6 @@ import { HeroesGameController } from './heroes.controller';
 import { QueryHandlers } from './queries/handlers';
 import { HeroRepository } from './repository/hero.repository';
 import { HeroesGameSagas } from './sagas/heroes.sagas';
-import { CqrsEventStoreModule } from '@nestjs-geteventstore/cqrs-event-store.module';
-import { IEventStoreSubsystems } from '@nestjs-geteventstore/event-store/config';
-import { EventStoreConnectionConfig } from '@nestjs-geteventstore/event-store/config/event-store-connection-config';
-import { EventBusConfigType } from '@nestjs-geteventstore/interfaces';
 
 const eventStoreConnectionConfig: EventStoreConnectionConfig = {
   connectionSettings: {

examples/src/heroes/events/handlers/hero-found-item.handler.ts

@@ -4,8 +4,11 @@ import { HeroFoundItemEvent } from '../impl/hero-found-item.event';
 
 @EventsHandler(HeroFoundItemEvent)
 export class HeroFoundItemHandler implements IEventHandler<HeroFoundItemEvent> {
-  handle(event: HeroFoundItemEvent) {
-    console.log(clc.yellowBright('Async HeroFoundItemEventHandler...'));
-    //throw new Error(`Error handling ${event.constructor.name}`);
+  async handle(event: HeroFoundItemEvent): Promise<void> {
+    console.log(
+      clc.yellowBright(
+        `HeroFoundItemEventHandler handling HeroFoundItemEvent#${event.data.heroId}`,
+      ),
+    );
   }
 }

examples/src/heroes/events/handlers/hero-killed-dragon.handler.ts

@@ -5,8 +5,9 @@ import { HeroKilledDragonEvent } from '../impl/hero-killed-dragon.event';
 
 @EventsHandler(HeroKilledDragonEvent)
 export class HeroKilledDragonHandler
-  implements IEventHandler<HeroKilledDragonEvent> {
-  async handle(event: HeroKilledDragonEvent) {
+  implements IEventHandler<HeroKilledDragonEvent>
+{
+  async handle(event: HeroKilledDragonEvent): Promise<void> {
     console.log(clc.greenBright('HeroKilledDragonEventHandler...'));
     await event.ack();
   }

examples/src/heroes/events/handlers/index.ts

@@ -1,4 +1,4 @@
-import { HeroKilledDragonHandler } from './hero-killed-dragon.handler';
 import { HeroFoundItemHandler } from './hero-found-item.handler';
+import { HeroKilledDragonHandler } from './hero-killed-dragon.handler';
 
 export const EventHandlers = [HeroKilledDragonHandler, HeroFoundItemHandler];

examples/src/heroes/events/impl/hero-damaged-enemy.event.ts

@@ -1,5 +1,5 @@
-import { ValidateNested } from 'class-validator';
 import { Type } from 'class-transformer';
+import { ValidateNested } from 'class-validator';
 import { EventStoreEvent } from '../../../../../src';
 import { HeroDamagedEnemyDto } from '../../dto/hero-damaged-enemy.dto';
 

examples/src/heroes/events/impl/hero-drop-item.event.ts

@@ -1,12 +1,12 @@
-import { EventStoreEvent } from '../../../../../src';
+import { EventOptionsType, EventStoreEvent } from '../../../../../src';
 
 export class HeroDropItemEvent extends EventStoreEvent {
   constructor(
     public readonly data: {
       heroId: string;
       itemId: string;
     },
-    options?,
+    options?: EventOptionsType,
   ) {
     super(data, options);
   }

examples/src/heroes/events/impl/hero-found-item.event.ts

@@ -1,12 +1,12 @@
-import { EventStoreEvent } from '../../../../../src';
+import { EventOptionsType, EventStoreEvent } from '../../../../../src';
 
 export class HeroFoundItemEvent extends EventStoreEvent {
   constructor(
     public readonly data: {
       heroId: string;
       itemId: string;
     },
-    options?,
+    options?: EventOptionsType,
   ) {
     super(data, options);
   }

examples/src/heroes/events/impl/index.ts

@@ -1,7 +1,7 @@
+import { HeroDamagedEnemyEvent } from './hero-damaged-enemy.event';
+import { HeroDropItemEvent } from './hero-drop-item.event';
 import { HeroFoundItemEvent } from './hero-found-item.event';
 import { HeroKilledDragonEvent } from './hero-killed-dragon.event';
-import { HeroDropItemEvent } from './hero-drop-item.event';
-import { HeroDamagedEnemyEvent } from './hero-damaged-enemy.event';
 
 export const heroesEvents = {
   HeroDamagedEnemyEvent,

examples/src/heroes/health.controller.ts

@@ -1,5 +1,5 @@
-import { HealthCheck, HealthIndicatorResult } from '@nestjs/terminus';
 import { Controller, Get } from '@nestjs/common';
+import { HealthCheck, HealthIndicatorResult } from '@nestjs/terminus';
 import { EventStoreHealthIndicator } from '../../../src';
 
 @Controller('health')

examples/src/heroes/heroes.controller.ts

@@ -1,8 +1,8 @@
 import { Body, Controller, Get, Param, Put } from '@nestjs/common';
 import { CommandBus, QueryBus } from '@nestjs/cqrs';
+import { Hero } from './aggregates/hero.aggregate';
 import { KillDragonCommand } from './commands/impl/kill-dragon.command';
 import { KillDragonDto } from './interfaces/kill-dragon-dto.interface';
-import { Hero } from './aggregates/hero.aggregate';
 import { GetHeroesQuery } from './queries/impl';
 
 @Controller('hero')
@@ -13,7 +13,10 @@ export class HeroesGameController {
   ) {}
 
   @Put(':id/kill')
-  async killDragon(@Param('id') id: string, @Body() dto: KillDragonDto) {
+  async killDragon(
+    @Param('id') id: string,
+    @Body() dto: KillDragonDto,
+  ): Promise<any> {
     return this.commandBus
       .execute(new KillDragonCommand(id, dto.dragonId))
       .catch((e) => console.log('e : ', e));

examples/src/heroes/queries/handlers/get-heroes.handler.ts

@@ -1,13 +1,15 @@
 import { IQueryHandler, QueryHandler } from '@nestjs/cqrs';
 import * as clc from 'cli-color';
+import { Hero } from '../../aggregates/hero.aggregate';
 import { HeroRepository } from '../../repository/hero.repository';
 import { GetHeroesQuery } from '../impl';
 
 @QueryHandler(GetHeroesQuery)
 export class GetHeroesHandler implements IQueryHandler<GetHeroesQuery> {
   constructor(private readonly repository: HeroRepository) {}
 
-  async execute(query: GetHeroesQuery) {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  async execute(query: GetHeroesQuery): Promise<Hero[]> {
     console.log(clc.yellowBright('Async GetHeroesQuery...'));
     return this.repository.findAll();
   }

examples/src/heroes/repository/hero.repository.ts

@@ -4,7 +4,7 @@ import { userHero } from './fixtures/user';
 
 @Injectable()
 export class HeroRepository {
-  async findOneById(id: number): Promise<Hero> {
+  async findOneById(id: string): Promise<Hero> {
     return new Hero(id);
   }
 

examples/src/heroes/sagas/heroes.sagas.ts

@@ -1,10 +1,10 @@
 import { Injectable } from '@nestjs/common';
 import { ICommand, Saga } from '@nestjs/cqrs';
 import * as clc from 'cli-color';
-import { v4 } from 'uuid';
 import { Context, CONTEXT_CORRELATION_ID } from 'nestjs-context';
 import { Observable } from 'rxjs';
 import { delay, filter, map } from 'rxjs/operators';
+import { v4 } from 'uuid';
 import { DropAncientItemCommand } from '../commands/impl/drop-ancient-item.command';
 import { HeroKilledDragonEvent } from '../events/impl/hero-killed-dragon.event';
 

examples/src/heroes/write.controller.ts

@@ -8,7 +8,10 @@ export class WriteController {
   constructor(private readonly commandBus: CommandBus) {}
 
   @Put(':id/kill')
-  async killDragon(@Param('id') id: string, @Body() dto: KillDragonDto) {
+  async killDragon(
+    @Param('id') id: string,
+    @Body() dto: KillDragonDto,
+  ): Promise<any> {
     return this.commandBus.execute(new KillDragonCommand(id, dto.dragonId));
   }
 }