fix: restore install/upgrade on PS 9.0.x

Two bugs broke ps_mbo install/upgrade on PrestaShop 9.0.x:

- ResolvesServices was used inside the UseHooks trait, so getTraitNames()
  (class_uses(UseHooks::class)) turned it into a bogus "ResolvesServices"
  hook and registration failed. Move the trait onto the ps_mbo class so
  getRequiredService() stays available without being scanned as a hook.
- The 'upload' action on route admin_module_manage_action only exists since
  PS 9.1.0; generating its URL threw InvalidParameterException on 9.0.x.
  Add the 'upload' action URL only when _PS_VERSION_ >= 9.1.0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: intraordinaire

ps_mbo.php

@@ -41,6 +41,7 @@ class ps_mbo extends Module
     use PrestaShop\Module\Mbo\Traits\HaveTabs;
     use PrestaShop\Module\Mbo\Traits\UseHooks;
     use PrestaShop\Module\Mbo\Traits\HaveConfigurationPage;
+    use PrestaShop\Module\Mbo\Traits\ResolvesServices;
 
     public const MODULE_NAME = 'ps_mbo';
 

src/Service/View/ContextBuilder.php

@@ -184,19 +184,33 @@ private function getCommonContextContent(): array
             'shop_business_sector' => $shopActivity['name'],
             'overrides_on_shop' => $overrideChecker->listOverridesFromPsDirectory(),
             'actions_token' => UrlHelper::getQueryParameterValue($mboResetUrl, '_token'),
-            'actions_url' => [
-                'install' => $this->generateActionUrl('install'),
-                'uninstall' => $this->generateActionUrl('uninstall'),
-                'delete' => $this->generateActionUrl('delete'),
-                'enable' => $this->generateActionUrl('enable'),
-                'disable' => $this->generateActionUrl('disable'),
-                'reset' => $this->generateActionUrl('reset'),
-                'upgrade' => $this->generateActionUrl('upgrade'),
-                'upload' => $this->generateActionUrl('upload'),
-            ],
+            'actions_url' => $this->getActionsUrl(),
         ];
     }
 
+    /**
+     * @return array<string, string>
+     */
+    private function getActionsUrl(): array
+    {
+        $actionsUrl = [
+            'install' => $this->generateActionUrl('install'),
+            'uninstall' => $this->generateActionUrl('uninstall'),
+            'delete' => $this->generateActionUrl('delete'),
+            'enable' => $this->generateActionUrl('enable'),
+            'disable' => $this->generateActionUrl('disable'),
+            'reset' => $this->generateActionUrl('reset'),
+            'upgrade' => $this->generateActionUrl('upgrade'),
+        ];
+
+        // The 'upload' action on route admin_module_manage_action exists only since PS 9.1.0
+        if (version_compare(_PS_VERSION_, '9.1.0', '>=')) {
+            $actionsUrl['upload'] = $this->generateActionUrl('upload');
+        }
+
+        return $actionsUrl;
+    }
+
     private function generateActionUrl(string $action): string
     {
         $params = [

src/Traits/UseHooks.php

@@ -30,7 +30,6 @@
 
 trait UseHooks
 {
-    use ResolvesServices;
     use Hooks\UseDashboardZoneOne;
     use Hooks\UseDashboardZoneThree {
         Hooks\UseDashboardZoneOne::smartyDisplayTpl insteadof \PrestaShop\Module\Mbo\Traits\Hooks\UseDashboardZoneThree;